2015-12-03 13:26:16 +03:00
|
|
|
<?php
|
|
|
|
/**
|
2016-07-21 17:49:16 +03:00
|
|
|
* @copyright Copyright (c) 2016, ownCloud, Inc.
|
|
|
|
*
|
|
|
|
* @author Joas Schilling <coding@schilljs.com>
|
2017-11-06 17:56:42 +03:00
|
|
|
* @author Morris Jobke <hey@morrisjobke.de>
|
2016-07-21 17:49:16 +03:00
|
|
|
* @author Roeland Jago Douma <roeland@famdouma.nl>
|
2016-01-12 17:02:16 +03:00
|
|
|
* @author Vincent Petry <pvince81@owncloud.com>
|
|
|
|
*
|
|
|
|
* @license AGPL-3.0
|
|
|
|
*
|
|
|
|
* This code is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
|
|
* as published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU Affero General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
|
|
*
|
2015-12-03 13:26:16 +03:00
|
|
|
*/
|
|
|
|
|
2016-05-25 17:04:15 +03:00
|
|
|
namespace OCA\DAV\Tests\unit\SystemTag;
|
2015-12-03 13:26:16 +03:00
|
|
|
|
|
|
|
|
|
|
|
use OC\SystemTag\SystemTag;
|
2017-10-24 16:26:53 +03:00
|
|
|
use OCP\IUser;
|
2017-10-25 01:03:28 +03:00
|
|
|
use OCP\SystemTag\ISystemTagManager;
|
2015-12-03 13:26:16 +03:00
|
|
|
use OCP\SystemTag\TagNotFoundException;
|
|
|
|
use OCP\SystemTag\TagAlreadyExistsException;
|
2016-05-11 16:39:24 +03:00
|
|
|
use OCP\SystemTag\ISystemTag;
|
2016-12-05 18:51:16 +03:00
|
|
|
use Sabre\DAV\Exception\Forbidden;
|
2015-12-03 13:26:16 +03:00
|
|
|
|
2016-05-25 17:04:15 +03:00
|
|
|
class SystemTagNodeTest extends \Test\TestCase {
|
2015-12-03 13:26:16 +03:00
|
|
|
|
|
|
|
/**
|
2016-12-05 18:51:16 +03:00
|
|
|
* @var \OCP\SystemTag\ISystemTagManager|\PHPUnit_Framework_MockObject_MockObject
|
2015-12-03 13:26:16 +03:00
|
|
|
*/
|
|
|
|
private $tagManager;
|
|
|
|
|
2016-05-11 16:39:24 +03:00
|
|
|
/**
|
|
|
|
* @var \OCP\IUser
|
|
|
|
*/
|
|
|
|
private $user;
|
|
|
|
|
2015-12-03 13:26:16 +03:00
|
|
|
protected function setUp() {
|
|
|
|
parent::setUp();
|
|
|
|
|
2017-10-25 01:03:28 +03:00
|
|
|
$this->tagManager = $this->getMockBuilder(ISystemTagManager::class)
|
2016-07-15 10:52:46 +03:00
|
|
|
->getMock();
|
2017-10-24 16:26:53 +03:00
|
|
|
$this->user = $this->getMockBuilder(IUser::class)
|
2016-07-15 10:52:46 +03:00
|
|
|
->getMock();
|
2016-01-20 13:47:23 +03:00
|
|
|
}
|
2015-12-03 13:26:16 +03:00
|
|
|
|
2016-01-20 13:47:23 +03:00
|
|
|
protected function getTagNode($isAdmin = true, $tag = null) {
|
|
|
|
if ($tag === null) {
|
|
|
|
$tag = new SystemTag(1, 'Test', true, true);
|
|
|
|
}
|
|
|
|
return new \OCA\DAV\SystemTag\SystemTagNode(
|
|
|
|
$tag,
|
2016-05-11 16:39:24 +03:00
|
|
|
$this->user,
|
2016-01-20 13:47:23 +03:00
|
|
|
$isAdmin,
|
|
|
|
$this->tagManager
|
|
|
|
);
|
2015-12-03 13:26:16 +03:00
|
|
|
}
|
|
|
|
|
2016-01-20 13:47:23 +03:00
|
|
|
public function adminFlagProvider() {
|
|
|
|
return [[true], [false]];
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider adminFlagProvider
|
|
|
|
*/
|
|
|
|
public function testGetters($isAdmin) {
|
|
|
|
$tag = new SystemTag('1', 'Test', true, true);
|
|
|
|
$node = $this->getTagNode($isAdmin, $tag);
|
|
|
|
$this->assertEquals('1', $node->getName());
|
|
|
|
$this->assertEquals($tag, $node->getSystemTag());
|
2015-12-03 13:26:16 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2016-05-24 17:07:38 +03:00
|
|
|
* @expectedException \Sabre\DAV\Exception\MethodNotAllowed
|
2015-12-03 13:26:16 +03:00
|
|
|
*/
|
|
|
|
public function testSetName() {
|
2016-01-20 13:47:23 +03:00
|
|
|
$this->getTagNode()->setName('2');
|
|
|
|
}
|
|
|
|
|
|
|
|
public function tagNodeProvider() {
|
|
|
|
return [
|
|
|
|
// admin
|
|
|
|
[
|
|
|
|
true,
|
|
|
|
new SystemTag(1, 'Original', true, true),
|
|
|
|
['Renamed', true, true]
|
|
|
|
],
|
|
|
|
[
|
|
|
|
true,
|
|
|
|
new SystemTag(1, 'Original', true, true),
|
|
|
|
['Original', false, false]
|
|
|
|
],
|
|
|
|
// non-admin
|
|
|
|
[
|
|
|
|
// renaming allowed
|
|
|
|
false,
|
|
|
|
new SystemTag(1, 'Original', true, true),
|
|
|
|
['Rename', true, true]
|
|
|
|
],
|
|
|
|
];
|
2015-12-03 13:26:16 +03:00
|
|
|
}
|
|
|
|
|
2016-01-20 13:47:23 +03:00
|
|
|
/**
|
|
|
|
* @dataProvider tagNodeProvider
|
|
|
|
*/
|
2016-12-05 18:51:16 +03:00
|
|
|
public function testUpdateTag($isAdmin, ISystemTag $originalTag, $changedArgs) {
|
2016-05-11 16:39:24 +03:00
|
|
|
$this->tagManager->expects($this->once())
|
|
|
|
->method('canUserSeeTag')
|
|
|
|
->with($originalTag)
|
|
|
|
->will($this->returnValue($originalTag->isUserVisible() || $isAdmin));
|
|
|
|
$this->tagManager->expects($this->once())
|
|
|
|
->method('canUserAssignTag')
|
|
|
|
->with($originalTag)
|
|
|
|
->will($this->returnValue($originalTag->isUserAssignable() || $isAdmin));
|
2015-12-03 13:26:16 +03:00
|
|
|
$this->tagManager->expects($this->once())
|
|
|
|
->method('updateTag')
|
2016-01-20 13:47:23 +03:00
|
|
|
->with(1, $changedArgs[0], $changedArgs[1], $changedArgs[2]);
|
|
|
|
$this->getTagNode($isAdmin, $originalTag)
|
|
|
|
->update($changedArgs[0], $changedArgs[1], $changedArgs[2]);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function tagNodeProviderPermissionException() {
|
|
|
|
return [
|
|
|
|
[
|
|
|
|
// changing permissions not allowed
|
|
|
|
new SystemTag(1, 'Original', true, true),
|
|
|
|
['Original', false, true],
|
|
|
|
'Sabre\DAV\Exception\Forbidden',
|
|
|
|
],
|
|
|
|
[
|
|
|
|
// changing permissions not allowed
|
|
|
|
new SystemTag(1, 'Original', true, true),
|
|
|
|
['Original', true, false],
|
|
|
|
'Sabre\DAV\Exception\Forbidden',
|
|
|
|
],
|
|
|
|
[
|
|
|
|
// changing permissions not allowed
|
|
|
|
new SystemTag(1, 'Original', true, true),
|
|
|
|
['Original', false, false],
|
|
|
|
'Sabre\DAV\Exception\Forbidden',
|
|
|
|
],
|
|
|
|
[
|
|
|
|
// changing non-assignable not allowed
|
|
|
|
new SystemTag(1, 'Original', true, false),
|
|
|
|
['Rename', true, false],
|
|
|
|
'Sabre\DAV\Exception\Forbidden',
|
|
|
|
],
|
|
|
|
[
|
|
|
|
// changing non-assignable not allowed
|
|
|
|
new SystemTag(1, 'Original', true, false),
|
|
|
|
['Original', true, true],
|
|
|
|
'Sabre\DAV\Exception\Forbidden',
|
|
|
|
],
|
|
|
|
[
|
|
|
|
// invisible tag does not exist
|
|
|
|
new SystemTag(1, 'Original', false, false),
|
|
|
|
['Rename', false, false],
|
|
|
|
'Sabre\DAV\Exception\NotFound',
|
|
|
|
],
|
|
|
|
];
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider tagNodeProviderPermissionException
|
|
|
|
*/
|
2016-12-05 18:51:16 +03:00
|
|
|
public function testUpdateTagPermissionException(ISystemTag $originalTag, $changedArgs, $expectedException = null) {
|
2016-05-11 16:39:24 +03:00
|
|
|
$this->tagManager->expects($this->any())
|
|
|
|
->method('canUserSeeTag')
|
|
|
|
->with($originalTag)
|
|
|
|
->will($this->returnValue($originalTag->isUserVisible()));
|
|
|
|
$this->tagManager->expects($this->any())
|
|
|
|
->method('canUserAssignTag')
|
|
|
|
->with($originalTag)
|
|
|
|
->will($this->returnValue($originalTag->isUserAssignable()));
|
2016-01-20 13:47:23 +03:00
|
|
|
$this->tagManager->expects($this->never())
|
|
|
|
->method('updateTag');
|
|
|
|
|
|
|
|
$thrown = null;
|
|
|
|
|
|
|
|
try {
|
|
|
|
$this->getTagNode(false, $originalTag)
|
|
|
|
->update($changedArgs[0], $changedArgs[1], $changedArgs[2]);
|
|
|
|
} catch (\Exception $e) {
|
|
|
|
$thrown = $e;
|
|
|
|
}
|
|
|
|
|
|
|
|
$this->assertInstanceOf($expectedException, $thrown);
|
2015-12-03 13:26:16 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2016-05-24 17:07:38 +03:00
|
|
|
* @expectedException \Sabre\DAV\Exception\Conflict
|
2015-12-03 13:26:16 +03:00
|
|
|
*/
|
|
|
|
public function testUpdateTagAlreadyExists() {
|
2016-05-11 16:39:24 +03:00
|
|
|
$tag = new SystemTag(1, 'tag1', true, true);
|
|
|
|
$this->tagManager->expects($this->any())
|
|
|
|
->method('canUserSeeTag')
|
|
|
|
->with($tag)
|
|
|
|
->will($this->returnValue(true));
|
|
|
|
$this->tagManager->expects($this->any())
|
|
|
|
->method('canUserAssignTag')
|
|
|
|
->with($tag)
|
|
|
|
->will($this->returnValue(true));
|
2015-12-03 13:26:16 +03:00
|
|
|
$this->tagManager->expects($this->once())
|
|
|
|
->method('updateTag')
|
2016-05-11 16:39:24 +03:00
|
|
|
->with(1, 'Renamed', true, true)
|
2015-12-03 13:26:16 +03:00
|
|
|
->will($this->throwException(new TagAlreadyExistsException()));
|
2016-05-11 16:39:24 +03:00
|
|
|
$this->getTagNode(false, $tag)->update('Renamed', true, true);
|
2015-12-03 13:26:16 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2016-05-24 17:07:38 +03:00
|
|
|
* @expectedException \Sabre\DAV\Exception\NotFound
|
2015-12-03 13:26:16 +03:00
|
|
|
*/
|
|
|
|
public function testUpdateTagNotFound() {
|
2016-05-11 16:39:24 +03:00
|
|
|
$tag = new SystemTag(1, 'tag1', true, true);
|
|
|
|
$this->tagManager->expects($this->any())
|
|
|
|
->method('canUserSeeTag')
|
|
|
|
->with($tag)
|
|
|
|
->will($this->returnValue(true));
|
|
|
|
$this->tagManager->expects($this->any())
|
|
|
|
->method('canUserAssignTag')
|
|
|
|
->with($tag)
|
|
|
|
->will($this->returnValue(true));
|
2015-12-03 13:26:16 +03:00
|
|
|
$this->tagManager->expects($this->once())
|
|
|
|
->method('updateTag')
|
2016-05-11 16:39:24 +03:00
|
|
|
->with(1, 'Renamed', true, true)
|
2015-12-03 13:26:16 +03:00
|
|
|
->will($this->throwException(new TagNotFoundException()));
|
2016-05-11 16:39:24 +03:00
|
|
|
$this->getTagNode(false, $tag)->update('Renamed', true, true);
|
2015-12-03 13:26:16 +03:00
|
|
|
}
|
|
|
|
|
2016-01-20 13:47:23 +03:00
|
|
|
/**
|
|
|
|
* @dataProvider adminFlagProvider
|
|
|
|
*/
|
|
|
|
public function testDeleteTag($isAdmin) {
|
2016-05-11 16:39:24 +03:00
|
|
|
$tag = new SystemTag(1, 'tag1', true, true);
|
2016-12-05 18:51:16 +03:00
|
|
|
$this->tagManager->expects($isAdmin ? $this->once() : $this->never())
|
2016-05-11 16:39:24 +03:00
|
|
|
->method('canUserSeeTag')
|
|
|
|
->with($tag)
|
|
|
|
->will($this->returnValue(true));
|
2016-12-05 18:51:16 +03:00
|
|
|
$this->tagManager->expects($isAdmin ? $this->once() : $this->never())
|
2015-12-03 13:26:16 +03:00
|
|
|
->method('deleteTags')
|
|
|
|
->with('1');
|
2016-12-05 18:51:16 +03:00
|
|
|
if (!$isAdmin) {
|
2018-01-24 20:10:16 +03:00
|
|
|
$this->expectException(Forbidden::class);
|
2016-12-05 18:51:16 +03:00
|
|
|
}
|
2016-05-11 16:39:24 +03:00
|
|
|
$this->getTagNode($isAdmin, $tag)->delete();
|
2016-01-20 13:47:23 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
public function tagNodeDeleteProviderPermissionException() {
|
|
|
|
return [
|
|
|
|
[
|
|
|
|
// cannot delete invisible tag
|
|
|
|
new SystemTag(1, 'Original', false, true),
|
2016-12-05 18:51:16 +03:00
|
|
|
'Sabre\DAV\Exception\Forbidden',
|
2016-01-20 13:47:23 +03:00
|
|
|
],
|
|
|
|
[
|
|
|
|
// cannot delete non-assignable tag
|
|
|
|
new SystemTag(1, 'Original', true, false),
|
|
|
|
'Sabre\DAV\Exception\Forbidden',
|
|
|
|
],
|
|
|
|
];
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider tagNodeDeleteProviderPermissionException
|
|
|
|
*/
|
2016-05-11 16:39:24 +03:00
|
|
|
public function testDeleteTagPermissionException(ISystemTag $tag, $expectedException) {
|
|
|
|
$this->tagManager->expects($this->any())
|
|
|
|
->method('canUserSeeTag')
|
|
|
|
->with($tag)
|
|
|
|
->will($this->returnValue($tag->isUserVisible()));
|
2016-01-20 13:47:23 +03:00
|
|
|
$this->tagManager->expects($this->never())
|
|
|
|
->method('deleteTags');
|
|
|
|
|
2018-01-24 20:10:16 +03:00
|
|
|
$this->expectException($expectedException);
|
2016-12-05 18:51:16 +03:00
|
|
|
$this->getTagNode(false, $tag)->delete();
|
2015-12-03 13:26:16 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2016-05-24 17:07:38 +03:00
|
|
|
* @expectedException \Sabre\DAV\Exception\NotFound
|
2015-12-03 13:26:16 +03:00
|
|
|
*/
|
|
|
|
public function testDeleteTagNotFound() {
|
2016-05-11 16:39:24 +03:00
|
|
|
$tag = new SystemTag(1, 'tag1', true, true);
|
|
|
|
$this->tagManager->expects($this->any())
|
|
|
|
->method('canUserSeeTag')
|
|
|
|
->with($tag)
|
|
|
|
->will($this->returnValue($tag->isUserVisible()));
|
2015-12-03 13:26:16 +03:00
|
|
|
$this->tagManager->expects($this->once())
|
|
|
|
->method('deleteTags')
|
|
|
|
->with('1')
|
|
|
|
->will($this->throwException(new TagNotFoundException()));
|
2016-12-05 18:51:16 +03:00
|
|
|
$this->getTagNode(true, $tag)->delete();
|
2015-12-03 13:26:16 +03:00
|
|
|
}
|
|
|
|
}
|