2016-04-11 14:19:22 +03:00
|
|
|
<?php
|
|
|
|
/**
|
|
|
|
* @author Lukas Reschke <lukas@owncloud.com>
|
|
|
|
* @author Victor Dubiniuk <dubiniuk@owncloud.com>
|
|
|
|
*
|
|
|
|
* @copyright Copyright (c) 2015, ownCloud, Inc.
|
|
|
|
* @license AGPL-3.0
|
|
|
|
*
|
|
|
|
* This code is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
|
|
* as published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU Affero General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
2016-05-20 16:38:20 +03:00
|
|
|
namespace Test\Updater;
|
2016-04-11 14:19:22 +03:00
|
|
|
|
|
|
|
use OC\Updater\VersionCheck;
|
|
|
|
use OCP\IConfig;
|
|
|
|
use OCP\Util;
|
|
|
|
|
|
|
|
class VersionCheckTest extends \Test\TestCase {
|
|
|
|
/** @var IConfig| \PHPUnit_Framework_MockObject_MockObject */
|
|
|
|
private $config;
|
2016-04-18 18:28:10 +03:00
|
|
|
/** @var VersionCheck | \PHPUnit_Framework_MockObject_MockObject*/
|
2016-04-11 14:19:22 +03:00
|
|
|
private $updater;
|
|
|
|
|
|
|
|
public function setUp() {
|
|
|
|
parent::setUp();
|
2016-04-18 18:28:10 +03:00
|
|
|
$this->config = $this->getMockBuilder('\OCP\IConfig')
|
2016-04-11 14:19:22 +03:00
|
|
|
->disableOriginalConstructor()
|
|
|
|
->getMock();
|
2016-04-18 18:28:10 +03:00
|
|
|
$clientService = $this->getMockBuilder('\OCP\Http\Client\IClientService')
|
2016-04-11 14:19:22 +03:00
|
|
|
->disableOriginalConstructor()
|
|
|
|
->getMock();
|
|
|
|
|
2016-09-07 21:27:27 +03:00
|
|
|
$this->updater = $this->getMockBuilder(VersionCheck::class)
|
|
|
|
->setMethods(['getUrlContent'])
|
|
|
|
->setConstructorArgs([$clientService, $this->config])
|
|
|
|
->getMock();
|
2016-04-11 14:19:22 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @param string $baseUrl
|
|
|
|
* @return string
|
|
|
|
*/
|
|
|
|
private function buildUpdateUrl($baseUrl) {
|
2016-09-06 15:11:30 +03:00
|
|
|
return $baseUrl . '?version='.implode('x', Util::getVersion()).'xinstalledatxlastupdatedatx'.\OC_Util::getChannel().'xx';
|
2016-04-11 14:19:22 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
public function testCheckInCache() {
|
|
|
|
$expectedResult = [
|
|
|
|
'version' => '8.0.4.2',
|
|
|
|
'versionstring' => 'ownCloud 8.0.4',
|
|
|
|
'url' => 'https://download.owncloud.org/community/owncloud-8.0.4.zip',
|
|
|
|
'web' => 'http://doc.owncloud.org/server/8.0/admin_manual/maintenance/upgrade.html',
|
|
|
|
];
|
|
|
|
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(0))
|
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'lastupdatedat')
|
|
|
|
->will($this->returnValue(time()));
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(1))
|
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'lastupdateResult')
|
|
|
|
->will($this->returnValue(json_encode($expectedResult)));
|
|
|
|
|
|
|
|
$this->assertSame($expectedResult, $this->updater->check());
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testCheckWithoutUpdateUrl() {
|
|
|
|
$expectedResult = [
|
|
|
|
'version' => '8.0.4.2',
|
|
|
|
'versionstring' => 'ownCloud 8.0.4',
|
|
|
|
'url' => 'https://download.owncloud.org/community/owncloud-8.0.4.zip',
|
|
|
|
'web' => 'http://doc.owncloud.org/server/8.0/admin_manual/maintenance/upgrade.html',
|
|
|
|
];
|
|
|
|
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(0))
|
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'lastupdatedat')
|
|
|
|
->will($this->returnValue(0));
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(1))
|
2016-05-09 12:25:58 +03:00
|
|
|
->method('getSystemValue')
|
2016-09-07 18:15:03 +03:00
|
|
|
->with('updater.server.url', 'https://updates.nextcloud.com/server/')
|
|
|
|
->willReturn('https://updates.nextcloud.com/server/');
|
2016-05-09 12:25:58 +03:00
|
|
|
$this->config
|
|
|
|
->expects($this->at(2))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('setAppValue')
|
|
|
|
->with('core', 'lastupdatedat', $this->isType('integer'));
|
|
|
|
$this->config
|
2016-05-09 12:25:58 +03:00
|
|
|
->expects($this->at(4))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'installedat')
|
|
|
|
->will($this->returnValue('installedat'));
|
|
|
|
$this->config
|
2016-05-09 12:25:58 +03:00
|
|
|
->expects($this->at(5))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'lastupdatedat')
|
|
|
|
->will($this->returnValue('lastupdatedat'));
|
|
|
|
$this->config
|
2016-05-09 12:25:58 +03:00
|
|
|
->expects($this->at(6))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('setAppValue')
|
|
|
|
->with('core', 'lastupdateResult', json_encode($expectedResult));
|
|
|
|
|
|
|
|
$updateXml = '<?xml version="1.0"?>
|
|
|
|
<owncloud>
|
|
|
|
<version>8.0.4.2</version>
|
|
|
|
<versionstring>ownCloud 8.0.4</versionstring>
|
|
|
|
<url>https://download.owncloud.org/community/owncloud-8.0.4.zip</url>
|
|
|
|
<web>http://doc.owncloud.org/server/8.0/admin_manual/maintenance/upgrade.html</web>
|
|
|
|
</owncloud>';
|
2016-04-18 18:28:10 +03:00
|
|
|
$this->updater
|
2016-04-11 14:19:22 +03:00
|
|
|
->expects($this->once())
|
|
|
|
->method('getUrlContent')
|
2016-09-07 18:15:03 +03:00
|
|
|
->with($this->buildUpdateUrl('https://updates.nextcloud.com/server/'))
|
2016-04-11 14:19:22 +03:00
|
|
|
->will($this->returnValue($updateXml));
|
|
|
|
|
|
|
|
$this->assertSame($expectedResult, $this->updater->check());
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testCheckWithInvalidXml() {
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(0))
|
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'lastupdatedat')
|
|
|
|
->will($this->returnValue(0));
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(1))
|
2016-05-09 12:25:58 +03:00
|
|
|
->method('getSystemValue')
|
2016-09-07 18:15:03 +03:00
|
|
|
->with('updater.server.url', 'https://updates.nextcloud.com/server/')
|
|
|
|
->willReturn('https://updates.nextcloud.com/server/');
|
2016-05-09 12:25:58 +03:00
|
|
|
$this->config
|
|
|
|
->expects($this->at(2))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('setAppValue')
|
|
|
|
->with('core', 'lastupdatedat', $this->isType('integer'));
|
|
|
|
$this->config
|
2016-05-09 12:25:58 +03:00
|
|
|
->expects($this->at(4))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'installedat')
|
|
|
|
->will($this->returnValue('installedat'));
|
|
|
|
$this->config
|
2016-05-09 12:25:58 +03:00
|
|
|
->expects($this->at(5))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'lastupdatedat')
|
|
|
|
->will($this->returnValue('lastupdatedat'));
|
|
|
|
$this->config
|
2016-05-09 12:25:58 +03:00
|
|
|
->expects($this->at(6))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('setAppValue')
|
|
|
|
->with('core', 'lastupdateResult', 'false');
|
|
|
|
|
|
|
|
$updateXml = 'Invalid XML Response!';
|
2016-04-18 18:28:10 +03:00
|
|
|
$this->updater
|
2016-04-11 14:19:22 +03:00
|
|
|
->expects($this->once())
|
|
|
|
->method('getUrlContent')
|
2016-09-07 18:15:03 +03:00
|
|
|
->with($this->buildUpdateUrl('https://updates.nextcloud.com/server/'))
|
2016-04-11 14:19:22 +03:00
|
|
|
->will($this->returnValue($updateXml));
|
|
|
|
|
|
|
|
$this->assertSame([], $this->updater->check());
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testCheckWithEmptyValidXmlResponse() {
|
|
|
|
$expectedResult = [
|
|
|
|
'version' => '',
|
|
|
|
'versionstring' => '',
|
|
|
|
'url' => '',
|
|
|
|
'web' => '',
|
|
|
|
];
|
|
|
|
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(0))
|
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'lastupdatedat')
|
|
|
|
->will($this->returnValue(0));
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(1))
|
2016-05-09 12:25:58 +03:00
|
|
|
->method('getSystemValue')
|
2016-09-07 18:15:03 +03:00
|
|
|
->with('updater.server.url', 'https://updates.nextcloud.com/server/')
|
|
|
|
->willReturn('https://updates.nextcloud.com/server/');
|
2016-05-09 12:25:58 +03:00
|
|
|
$this->config
|
|
|
|
->expects($this->at(2))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('setAppValue')
|
|
|
|
->with('core', 'lastupdatedat', $this->isType('integer'));
|
|
|
|
$this->config
|
2016-05-09 12:25:58 +03:00
|
|
|
->expects($this->at(4))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'installedat')
|
|
|
|
->will($this->returnValue('installedat'));
|
|
|
|
$this->config
|
2016-05-09 12:25:58 +03:00
|
|
|
->expects($this->at(5))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'lastupdatedat')
|
|
|
|
->will($this->returnValue('lastupdatedat'));
|
|
|
|
|
|
|
|
$updateXml = '<?xml version="1.0"?>
|
|
|
|
<owncloud>
|
|
|
|
<version></version>
|
|
|
|
<versionstring></versionstring>
|
|
|
|
<url></url>
|
|
|
|
<web></web>
|
|
|
|
</owncloud>';
|
2016-04-18 18:28:10 +03:00
|
|
|
$this->updater
|
2016-04-11 14:19:22 +03:00
|
|
|
->expects($this->once())
|
|
|
|
->method('getUrlContent')
|
2016-09-07 18:15:03 +03:00
|
|
|
->with($this->buildUpdateUrl('https://updates.nextcloud.com/server/'))
|
2016-04-11 14:19:22 +03:00
|
|
|
->will($this->returnValue($updateXml));
|
|
|
|
|
|
|
|
$this->assertSame($expectedResult, $this->updater->check());
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testCheckWithEmptyInvalidXmlResponse() {
|
|
|
|
$expectedResult = [];
|
|
|
|
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(0))
|
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'lastupdatedat')
|
|
|
|
->will($this->returnValue(0));
|
|
|
|
$this->config
|
|
|
|
->expects($this->at(1))
|
2016-05-09 12:25:58 +03:00
|
|
|
->method('getSystemValue')
|
2016-09-07 18:15:03 +03:00
|
|
|
->with('updater.server.url', 'https://updates.nextcloud.com/server/')
|
|
|
|
->willReturn('https://updates.nextcloud.com/server/');
|
2016-05-09 12:25:58 +03:00
|
|
|
$this->config
|
|
|
|
->expects($this->at(2))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('setAppValue')
|
|
|
|
->with('core', 'lastupdatedat', $this->isType('integer'));
|
|
|
|
$this->config
|
2016-05-09 12:25:58 +03:00
|
|
|
->expects($this->at(4))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'installedat')
|
|
|
|
->will($this->returnValue('installedat'));
|
|
|
|
$this->config
|
2016-05-09 12:25:58 +03:00
|
|
|
->expects($this->at(5))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('getAppValue')
|
|
|
|
->with('core', 'lastupdatedat')
|
|
|
|
->will($this->returnValue('lastupdatedat'));
|
|
|
|
$this->config
|
2016-05-09 12:25:58 +03:00
|
|
|
->expects($this->at(6))
|
2016-04-11 14:19:22 +03:00
|
|
|
->method('setAppValue')
|
|
|
|
->with('core', 'lastupdateResult', json_encode($expectedResult));
|
|
|
|
|
|
|
|
$updateXml = '';
|
2016-04-18 18:28:10 +03:00
|
|
|
$this->updater
|
2016-04-11 14:19:22 +03:00
|
|
|
->expects($this->once())
|
|
|
|
->method('getUrlContent')
|
2016-09-07 18:15:03 +03:00
|
|
|
->with($this->buildUpdateUrl('https://updates.nextcloud.com/server/'))
|
2016-04-11 14:19:22 +03:00
|
|
|
->will($this->returnValue($updateXml));
|
|
|
|
|
|
|
|
$this->assertSame($expectedResult, $this->updater->check());
|
|
|
|
}
|
|
|
|
}
|