2011-11-19 14:56:40 +04:00
|
|
|
<?php
|
|
|
|
/**
|
2015-03-26 13:44:34 +03:00
|
|
|
* @author Arthur Schiwon <blizzz@owncloud.com>
|
|
|
|
* @author Bart Visscher <bartv@thisnet.nl>
|
|
|
|
* @author Björn Schießle <schiessle@owncloud.com>
|
|
|
|
* @author Frank Karlitschek <frank@owncloud.org>
|
2015-10-26 15:54:55 +03:00
|
|
|
* @author Joas Schilling <nickvergessen@owncloud.com>
|
2015-03-26 13:44:34 +03:00
|
|
|
* @author Lukas Reschke <lukas@owncloud.com>
|
|
|
|
* @author Morris Jobke <hey@morrisjobke.de>
|
|
|
|
* @author Robin Appelman <icewind@owncloud.com>
|
2016-01-12 17:02:16 +03:00
|
|
|
* @author Robin McCorkell <robin@mccorkell.me.uk>
|
2015-06-25 12:43:55 +03:00
|
|
|
* @author Steffen Lindner <mail@steffen-lindner.de>
|
2015-03-26 13:44:34 +03:00
|
|
|
* @author Thomas Müller <thomas.mueller@tmit.eu>
|
|
|
|
* @author Victor Dubiniuk <dubiniuk@owncloud.com>
|
|
|
|
* @author Vincent Petry <pvince81@owncloud.com>
|
|
|
|
*
|
2016-01-12 17:02:16 +03:00
|
|
|
* @copyright Copyright (c) 2016, ownCloud, Inc.
|
2015-03-26 13:44:34 +03:00
|
|
|
* @license AGPL-3.0
|
|
|
|
*
|
|
|
|
* This code is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
|
|
* as published by the Free Software Foundation.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU Affero General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
|
|
*
|
2011-11-19 14:56:40 +04:00
|
|
|
*/
|
2015-02-26 13:37:37 +03:00
|
|
|
|
2013-07-06 19:00:00 +04:00
|
|
|
namespace OC;
|
2014-07-24 19:18:54 +04:00
|
|
|
|
2013-07-06 19:00:00 +04:00
|
|
|
use OC\Hooks\BasicEmitter;
|
Add code integrity check
This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository.
Furthermore, there is a basic implementation to display problems with the code integrity on the update screen.
Code signing basically happens the following way:
- There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release :wink:). This certificate is not intended to be used for signing directly and only is used to sign new certificates.
- Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID.
- The command generates a signature.json file of the following format:
```json
{
"hashes": {
"/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d",
"/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9"
},
"certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----",
"signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl"
}
```
`hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`.
Steps to do in other PRs, this is already a quite huge one:
- Add nag screen in case the code check fails to ensure that administrators are aware of this.
- Add code verification also to OCC upgrade and unify display code more.
- Add enforced code verification to apps shipped from the appstore with a level of "official"
- Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release
- Add some developer documentation on how devs can request their own certificate
- Check when installing ownCloud
- Add support for CRLs to allow revoking certificates
**Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature:
```
➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt
Successfully signed "core"
```
Then increase the version and you should see something like the following:
![2015-11-04_12-02-57](https://cloud.githubusercontent.com/assets/878997/10936336/6adb1d14-82ec-11e5-8f06-9a74801c9abf.png)
As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen.
For packaging stable releases this requires the following additional steps as a last action before zipping:
1. Run `./occ integrity:sign-core` once
2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.
2015-11-03 22:26:06 +03:00
|
|
|
use OC\IntegrityCheck\Checker;
|
2015-02-17 14:00:39 +03:00
|
|
|
use OC_App;
|
2015-03-13 14:16:16 +03:00
|
|
|
use OC_Installer;
|
2015-02-17 14:00:39 +03:00
|
|
|
use OCP\IConfig;
|
2015-02-19 04:15:21 +03:00
|
|
|
use OC\Setup;
|
2015-04-30 12:52:30 +03:00
|
|
|
use OCP\ILogger;
|
2016-04-19 16:36:11 +03:00
|
|
|
use Symfony\Component\EventDispatcher\GenericEvent;
|
2013-07-06 19:00:00 +04:00
|
|
|
|
2011-11-19 14:56:40 +04:00
|
|
|
/**
|
2013-07-08 23:13:23 +04:00
|
|
|
* Class that handles autoupdating of ownCloud
|
2013-07-06 19:00:00 +04:00
|
|
|
*
|
|
|
|
* Hooks provided in scope \OC\Updater
|
|
|
|
* - maintenanceStart()
|
|
|
|
* - maintenanceEnd()
|
|
|
|
* - dbUpgrade()
|
|
|
|
* - failure(string $message)
|
2011-11-19 14:56:40 +04:00
|
|
|
*/
|
2013-07-06 19:00:00 +04:00
|
|
|
class Updater extends BasicEmitter {
|
|
|
|
|
2015-04-30 12:52:30 +03:00
|
|
|
/** @var ILogger $log */
|
2013-07-06 19:00:00 +04:00
|
|
|
private $log;
|
2014-11-25 22:41:15 +03:00
|
|
|
|
2015-02-17 14:00:39 +03:00
|
|
|
/** @var IConfig */
|
2014-12-10 01:13:38 +03:00
|
|
|
private $config;
|
2013-07-06 19:00:00 +04:00
|
|
|
|
Add code integrity check
This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository.
Furthermore, there is a basic implementation to display problems with the code integrity on the update screen.
Code signing basically happens the following way:
- There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release :wink:). This certificate is not intended to be used for signing directly and only is used to sign new certificates.
- Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID.
- The command generates a signature.json file of the following format:
```json
{
"hashes": {
"/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d",
"/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9"
},
"certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----",
"signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl"
}
```
`hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`.
Steps to do in other PRs, this is already a quite huge one:
- Add nag screen in case the code check fails to ensure that administrators are aware of this.
- Add code verification also to OCC upgrade and unify display code more.
- Add enforced code verification to apps shipped from the appstore with a level of "official"
- Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release
- Add some developer documentation on how devs can request their own certificate
- Check when installing ownCloud
- Add support for CRLs to allow revoking certificates
**Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature:
```
➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt
Successfully signed "core"
```
Then increase the version and you should see something like the following:
![2015-11-04_12-02-57](https://cloud.githubusercontent.com/assets/878997/10936336/6adb1d14-82ec-11e5-8f06-9a74801c9abf.png)
As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen.
For packaging stable releases this requires the following additional steps as a last action before zipping:
1. Run `./occ integrity:sign-core` once
2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.
2015-11-03 22:26:06 +03:00
|
|
|
/** @var Checker */
|
|
|
|
private $checker;
|
|
|
|
|
2015-02-17 14:00:39 +03:00
|
|
|
/** @var bool */
|
2014-06-05 18:19:24 +04:00
|
|
|
private $simulateStepEnabled;
|
|
|
|
|
2015-02-17 14:00:39 +03:00
|
|
|
/** @var bool */
|
2014-06-05 18:19:24 +04:00
|
|
|
private $updateStepEnabled;
|
|
|
|
|
2015-05-20 18:06:00 +03:00
|
|
|
/** @var bool */
|
|
|
|
private $skip3rdPartyAppsDisable;
|
|
|
|
|
2015-09-29 15:35:32 +03:00
|
|
|
private $logLevelNames = [
|
|
|
|
0 => 'Debug',
|
|
|
|
1 => 'Info',
|
|
|
|
2 => 'Warning',
|
|
|
|
3 => 'Error',
|
|
|
|
4 => 'Fatal',
|
|
|
|
];
|
|
|
|
|
2013-07-06 19:00:00 +04:00
|
|
|
/**
|
2015-02-17 14:00:39 +03:00
|
|
|
* @param IConfig $config
|
Add code integrity check
This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository.
Furthermore, there is a basic implementation to display problems with the code integrity on the update screen.
Code signing basically happens the following way:
- There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release :wink:). This certificate is not intended to be used for signing directly and only is used to sign new certificates.
- Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID.
- The command generates a signature.json file of the following format:
```json
{
"hashes": {
"/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d",
"/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9"
},
"certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----",
"signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl"
}
```
`hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`.
Steps to do in other PRs, this is already a quite huge one:
- Add nag screen in case the code check fails to ensure that administrators are aware of this.
- Add code verification also to OCC upgrade and unify display code more.
- Add enforced code verification to apps shipped from the appstore with a level of "official"
- Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release
- Add some developer documentation on how devs can request their own certificate
- Check when installing ownCloud
- Add support for CRLs to allow revoking certificates
**Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature:
```
➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt
Successfully signed "core"
```
Then increase the version and you should see something like the following:
![2015-11-04_12-02-57](https://cloud.githubusercontent.com/assets/878997/10936336/6adb1d14-82ec-11e5-8f06-9a74801c9abf.png)
As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen.
For packaging stable releases this requires the following additional steps as a last action before zipping:
1. Run `./occ integrity:sign-core` once
2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.
2015-11-03 22:26:06 +03:00
|
|
|
* @param Checker $checker
|
2015-04-30 12:52:30 +03:00
|
|
|
* @param ILogger $log
|
2013-07-06 19:00:00 +04:00
|
|
|
*/
|
2016-04-11 14:19:22 +03:00
|
|
|
public function __construct(IConfig $config,
|
Add code integrity check
This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository.
Furthermore, there is a basic implementation to display problems with the code integrity on the update screen.
Code signing basically happens the following way:
- There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release :wink:). This certificate is not intended to be used for signing directly and only is used to sign new certificates.
- Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID.
- The command generates a signature.json file of the following format:
```json
{
"hashes": {
"/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d",
"/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9"
},
"certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----",
"signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl"
}
```
`hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`.
Steps to do in other PRs, this is already a quite huge one:
- Add nag screen in case the code check fails to ensure that administrators are aware of this.
- Add code verification also to OCC upgrade and unify display code more.
- Add enforced code verification to apps shipped from the appstore with a level of "official"
- Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release
- Add some developer documentation on how devs can request their own certificate
- Check when installing ownCloud
- Add support for CRLs to allow revoking certificates
**Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature:
```
➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt
Successfully signed "core"
```
Then increase the version and you should see something like the following:
![2015-11-04_12-02-57](https://cloud.githubusercontent.com/assets/878997/10936336/6adb1d14-82ec-11e5-8f06-9a74801c9abf.png)
As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen.
For packaging stable releases this requires the following additional steps as a last action before zipping:
1. Run `./occ integrity:sign-core` once
2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.
2015-11-03 22:26:06 +03:00
|
|
|
Checker $checker,
|
2015-06-28 12:25:28 +03:00
|
|
|
ILogger $log = null) {
|
2013-07-06 19:00:00 +04:00
|
|
|
$this->log = $log;
|
2014-12-10 01:13:38 +03:00
|
|
|
$this->config = $config;
|
Add code integrity check
This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository.
Furthermore, there is a basic implementation to display problems with the code integrity on the update screen.
Code signing basically happens the following way:
- There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release :wink:). This certificate is not intended to be used for signing directly and only is used to sign new certificates.
- Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID.
- The command generates a signature.json file of the following format:
```json
{
"hashes": {
"/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d",
"/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9"
},
"certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----",
"signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl"
}
```
`hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`.
Steps to do in other PRs, this is already a quite huge one:
- Add nag screen in case the code check fails to ensure that administrators are aware of this.
- Add code verification also to OCC upgrade and unify display code more.
- Add enforced code verification to apps shipped from the appstore with a level of "official"
- Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release
- Add some developer documentation on how devs can request their own certificate
- Check when installing ownCloud
- Add support for CRLs to allow revoking certificates
**Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature:
```
➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt
Successfully signed "core"
```
Then increase the version and you should see something like the following:
![2015-11-04_12-02-57](https://cloud.githubusercontent.com/assets/878997/10936336/6adb1d14-82ec-11e5-8f06-9a74801c9abf.png)
As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen.
For packaging stable releases this requires the following additional steps as a last action before zipping:
1. Run `./occ integrity:sign-core` once
2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.
2015-11-03 22:26:06 +03:00
|
|
|
$this->checker = $checker;
|
2014-06-05 18:19:24 +04:00
|
|
|
$this->simulateStepEnabled = true;
|
|
|
|
$this->updateStepEnabled = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Sets whether the database migration simulation must
|
|
|
|
* be enabled.
|
|
|
|
* This can be set to false to skip this test.
|
|
|
|
*
|
|
|
|
* @param bool $flag true to enable simulation, false otherwise
|
|
|
|
*/
|
|
|
|
public function setSimulateStepEnabled($flag) {
|
|
|
|
$this->simulateStepEnabled = $flag;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Sets whether the update must be performed.
|
|
|
|
* This can be set to false to skip the actual update.
|
|
|
|
*
|
|
|
|
* @param bool $flag true to enable update, false otherwise
|
|
|
|
*/
|
|
|
|
public function setUpdateStepEnabled($flag) {
|
|
|
|
$this->updateStepEnabled = $flag;
|
2013-07-06 19:00:00 +04:00
|
|
|
}
|
2011-11-19 14:56:40 +04:00
|
|
|
|
2015-05-20 18:06:00 +03:00
|
|
|
/**
|
|
|
|
* Sets whether the update disables 3rd party apps.
|
|
|
|
* This can be set to true to skip the disable.
|
|
|
|
*
|
|
|
|
* @param bool $flag false to not disable, true otherwise
|
|
|
|
*/
|
|
|
|
public function setSkip3rdPartyAppsDisable($flag) {
|
|
|
|
$this->skip3rdPartyAppsDisable = $flag;
|
|
|
|
}
|
|
|
|
|
2013-07-06 19:00:00 +04:00
|
|
|
/**
|
|
|
|
* runs the update actions in maintenance mode, does not upgrade the source files
|
2014-02-28 14:59:30 +04:00
|
|
|
* except the main .htaccess file
|
2014-06-05 18:19:24 +04:00
|
|
|
*
|
|
|
|
* @return bool true if the operation succeeded, false otherwise
|
2013-07-06 19:00:00 +04:00
|
|
|
*/
|
|
|
|
public function upgrade() {
|
2016-04-27 11:51:02 +03:00
|
|
|
$this->emitRepairEvents();
|
|
|
|
|
2015-09-29 15:35:32 +03:00
|
|
|
$logLevel = $this->config->getSystemValue('loglevel', \OCP\Util::WARN);
|
|
|
|
$this->emit('\OC\Updater', 'setDebugLogLevel', [ $logLevel, $this->logLevelNames[$logLevel] ]);
|
|
|
|
$this->config->setSystemValue('loglevel', \OCP\Util::DEBUG);
|
|
|
|
|
2015-05-19 11:27:53 +03:00
|
|
|
$wasMaintenanceModeEnabled = $this->config->getSystemValue('maintenance', false);
|
|
|
|
|
|
|
|
if(!$wasMaintenanceModeEnabled) {
|
|
|
|
$this->config->setSystemValue('maintenance', true);
|
|
|
|
$this->emit('\OC\Updater', 'maintenanceEnabled');
|
|
|
|
}
|
2014-06-10 13:47:27 +04:00
|
|
|
|
2015-02-17 14:00:39 +03:00
|
|
|
$installedVersion = $this->config->getSystemValue('version', '0.0.0');
|
2015-12-18 17:26:54 +03:00
|
|
|
$currentVersion = implode('.', \OCP\Util::getVersion());
|
2015-10-09 15:08:22 +03:00
|
|
|
$this->log->debug('starting upgrade from ' . $installedVersion . ' to ' . $currentVersion, array('app' => 'core'));
|
2014-02-18 19:26:37 +04:00
|
|
|
|
2015-06-23 11:03:27 +03:00
|
|
|
$success = true;
|
2014-06-10 13:47:27 +04:00
|
|
|
try {
|
|
|
|
$this->doUpgrade($currentVersion, $installedVersion);
|
|
|
|
} catch (\Exception $exception) {
|
2015-10-09 14:46:59 +03:00
|
|
|
$this->log->logException($exception, ['app' => 'core']);
|
2015-06-23 11:03:27 +03:00
|
|
|
$this->emit('\OC\Updater', 'failure', array(get_class($exception) . ': ' .$exception->getMessage()));
|
|
|
|
$success = false;
|
2014-06-10 13:47:27 +04:00
|
|
|
}
|
|
|
|
|
2015-06-23 11:03:27 +03:00
|
|
|
$this->emit('\OC\Updater', 'updateEnd', array($success));
|
2015-05-19 11:27:53 +03:00
|
|
|
|
2015-06-23 15:45:53 +03:00
|
|
|
if(!$wasMaintenanceModeEnabled && $success) {
|
2015-05-19 11:27:53 +03:00
|
|
|
$this->config->setSystemValue('maintenance', false);
|
|
|
|
$this->emit('\OC\Updater', 'maintenanceDisabled');
|
|
|
|
} else {
|
|
|
|
$this->emit('\OC\Updater', 'maintenanceActive');
|
|
|
|
}
|
2015-06-23 11:03:27 +03:00
|
|
|
|
2015-09-29 15:35:32 +03:00
|
|
|
$this->emit('\OC\Updater', 'resetLogLevel', [ $logLevel, $this->logLevelNames[$logLevel] ]);
|
|
|
|
$this->config->setSystemValue('loglevel', $logLevel);
|
|
|
|
|
2015-06-23 11:03:27 +03:00
|
|
|
return $success;
|
2014-06-10 13:47:27 +04:00
|
|
|
}
|
|
|
|
|
2015-08-30 17:21:55 +03:00
|
|
|
/**
|
|
|
|
* Return version from which this version is allowed to upgrade from
|
|
|
|
*
|
|
|
|
* @return string allowed previous version
|
|
|
|
*/
|
|
|
|
private function getAllowedPreviousVersion() {
|
|
|
|
// this should really be a JSON file
|
|
|
|
require \OC::$SERVERROOT . '/version.php';
|
2015-10-09 14:46:59 +03:00
|
|
|
/** @var array $OC_VersionCanBeUpgradedFrom */
|
2015-08-30 17:21:55 +03:00
|
|
|
return implode('.', $OC_VersionCanBeUpgradedFrom);
|
|
|
|
}
|
|
|
|
|
2014-09-18 19:45:30 +04:00
|
|
|
/**
|
|
|
|
* Whether an upgrade to a specified version is possible
|
|
|
|
* @param string $oldVersion
|
|
|
|
* @param string $newVersion
|
2015-08-30 17:21:55 +03:00
|
|
|
* @param string $allowedPreviousVersion
|
2014-09-18 19:45:30 +04:00
|
|
|
* @return bool
|
|
|
|
*/
|
2015-08-30 17:21:55 +03:00
|
|
|
public function isUpgradePossible($oldVersion, $newVersion, $allowedPreviousVersion) {
|
2015-08-31 15:31:17 +03:00
|
|
|
return (version_compare($allowedPreviousVersion, $oldVersion, '<=')
|
2016-01-07 16:13:46 +03:00
|
|
|
&& (version_compare($oldVersion, $newVersion, '<=') || $this->config->getSystemValue('debug', false)));
|
2014-09-18 19:45:30 +04:00
|
|
|
}
|
|
|
|
|
2014-06-10 13:47:27 +04:00
|
|
|
/**
|
|
|
|
* runs the update actions in maintenance mode, does not upgrade the source files
|
|
|
|
* except the main .htaccess file
|
|
|
|
*
|
|
|
|
* @param string $currentVersion current version to upgrade to
|
|
|
|
* @param string $installedVersion previous version from which to upgrade from
|
|
|
|
*
|
2014-09-18 19:45:30 +04:00
|
|
|
* @throws \Exception
|
2014-06-10 13:47:27 +04:00
|
|
|
*/
|
|
|
|
private function doUpgrade($currentVersion, $installedVersion) {
|
2014-09-18 19:45:30 +04:00
|
|
|
// Stop update if the update is over several major versions
|
2015-08-30 17:21:55 +03:00
|
|
|
$allowedPreviousVersion = $this->getAllowedPreviousVersion();
|
|
|
|
if (!self::isUpgradePossible($installedVersion, $currentVersion, $allowedPreviousVersion)) {
|
|
|
|
throw new \Exception('Updates between multiple major versions and downgrades are unsupported.');
|
2014-09-18 19:45:30 +04:00
|
|
|
}
|
|
|
|
|
2015-02-19 04:15:21 +03:00
|
|
|
// Update .htaccess files
|
|
|
|
try {
|
|
|
|
Setup::updateHtaccess();
|
|
|
|
Setup::protectDataDirectory();
|
|
|
|
} catch (\Exception $e) {
|
|
|
|
throw new \Exception($e->getMessage());
|
2014-02-28 14:59:30 +04:00
|
|
|
}
|
|
|
|
|
2014-03-14 16:03:18 +04:00
|
|
|
// create empty file in data dir, so we can later find
|
|
|
|
// out that this is indeed an ownCloud data directory
|
|
|
|
// (in case it didn't exist before)
|
2015-02-17 14:00:39 +03:00
|
|
|
file_put_contents($this->config->getSystemValue('datadirectory', \OC::$SERVERROOT . '/data') . '/.ocdata', '');
|
2014-03-14 16:03:18 +04:00
|
|
|
|
2014-06-10 13:47:27 +04:00
|
|
|
// pre-upgrade repairs
|
2016-04-27 11:51:02 +03:00
|
|
|
$repair = new Repair(Repair::getBeforeUpgradeRepairSteps(), \OC::$server->getEventDispatcher());
|
2014-06-10 13:47:27 +04:00
|
|
|
$repair->run();
|
2014-02-18 19:26:37 +04:00
|
|
|
|
2014-06-04 18:40:53 +04:00
|
|
|
// simulate DB upgrade
|
2014-06-05 18:19:24 +04:00
|
|
|
if ($this->simulateStepEnabled) {
|
2014-07-24 19:18:54 +04:00
|
|
|
$this->checkCoreUpgrade();
|
2014-06-10 13:47:27 +04:00
|
|
|
|
|
|
|
// simulate apps DB upgrade
|
2014-07-24 19:18:54 +04:00
|
|
|
$this->checkAppUpgrade($currentVersion);
|
2014-06-10 13:47:27 +04:00
|
|
|
|
2013-07-06 19:00:00 +04:00
|
|
|
}
|
2013-11-26 17:12:48 +04:00
|
|
|
|
2014-06-10 13:47:27 +04:00
|
|
|
if ($this->updateStepEnabled) {
|
2014-07-24 19:18:54 +04:00
|
|
|
$this->doCoreUpgrade();
|
2014-06-04 18:40:53 +04:00
|
|
|
|
2015-03-13 14:16:16 +03:00
|
|
|
// update all shipped apps
|
|
|
|
$disabledApps = $this->checkAppsRequirements();
|
2014-07-24 19:18:54 +04:00
|
|
|
$this->doAppUpgrade();
|
2014-06-04 18:40:53 +04:00
|
|
|
|
2015-03-13 14:16:16 +03:00
|
|
|
// upgrade appstore apps
|
|
|
|
$this->upgradeAppStoreApps($disabledApps);
|
|
|
|
|
2016-02-23 12:31:11 +03:00
|
|
|
// install new shipped apps on upgrade
|
|
|
|
OC_App::loadApps('authentication');
|
2016-03-21 18:31:59 +03:00
|
|
|
$errors = OC_Installer::installShippedApps(true);
|
|
|
|
foreach ($errors as $appId => $exception) {
|
|
|
|
/** @var \Exception $exception */
|
|
|
|
$this->log->logException($exception, ['app' => $appId]);
|
|
|
|
$this->emit('\OC\Updater', 'failure', [$appId . ': ' . $exception->getMessage()]);
|
|
|
|
}
|
2016-02-23 12:31:11 +03:00
|
|
|
|
2014-06-10 13:47:27 +04:00
|
|
|
// post-upgrade repairs
|
2016-04-27 11:51:02 +03:00
|
|
|
$repair = new Repair(Repair::getRepairSteps(), \OC::$server->getEventDispatcher());
|
2014-06-04 18:40:53 +04:00
|
|
|
$repair->run();
|
|
|
|
|
|
|
|
//Invalidate update feed
|
2015-02-17 14:00:39 +03:00
|
|
|
$this->config->setAppValue('core', 'lastupdatedat', 0);
|
2014-07-24 01:38:17 +04:00
|
|
|
|
2016-01-12 20:41:11 +03:00
|
|
|
// Check for code integrity if not disabled
|
|
|
|
if(\OC::$server->getIntegrityCodeChecker()->isCodeCheckEnforced()) {
|
Add code integrity check
This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository.
Furthermore, there is a basic implementation to display problems with the code integrity on the update screen.
Code signing basically happens the following way:
- There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release :wink:). This certificate is not intended to be used for signing directly and only is used to sign new certificates.
- Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID.
- The command generates a signature.json file of the following format:
```json
{
"hashes": {
"/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d",
"/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9"
},
"certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----",
"signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl"
}
```
`hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`.
Steps to do in other PRs, this is already a quite huge one:
- Add nag screen in case the code check fails to ensure that administrators are aware of this.
- Add code verification also to OCC upgrade and unify display code more.
- Add enforced code verification to apps shipped from the appstore with a level of "official"
- Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release
- Add some developer documentation on how devs can request their own certificate
- Check when installing ownCloud
- Add support for CRLs to allow revoking certificates
**Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature:
```
➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt
Successfully signed "core"
```
Then increase the version and you should see something like the following:
![2015-11-04_12-02-57](https://cloud.githubusercontent.com/assets/878997/10936336/6adb1d14-82ec-11e5-8f06-9a74801c9abf.png)
As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen.
For packaging stable releases this requires the following additional steps as a last action before zipping:
1. Run `./occ integrity:sign-core` once
2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.
2015-11-03 22:26:06 +03:00
|
|
|
$this->emit('\OC\Updater', 'startCheckCodeIntegrity');
|
|
|
|
$this->checker->runInstanceVerification();
|
|
|
|
$this->emit('\OC\Updater', 'finishedCheckCodeIntegrity');
|
|
|
|
}
|
|
|
|
|
2014-07-24 01:38:17 +04:00
|
|
|
// only set the final version if everything went well
|
2015-12-18 17:26:54 +03:00
|
|
|
$this->config->setSystemValue('version', implode('.', \OCP\Util::getVersion()));
|
2014-06-04 18:40:53 +04:00
|
|
|
}
|
2013-07-06 19:00:00 +04:00
|
|
|
}
|
2014-07-24 19:18:54 +04:00
|
|
|
|
|
|
|
protected function checkCoreUpgrade() {
|
2015-10-21 10:17:38 +03:00
|
|
|
$this->emit('\OC\Updater', 'dbSimulateUpgradeBefore');
|
|
|
|
|
2014-07-24 19:18:54 +04:00
|
|
|
// simulate core DB upgrade
|
|
|
|
\OC_DB::simulateUpdateDbFromStructure(\OC::$SERVERROOT . '/db_structure.xml');
|
|
|
|
|
|
|
|
$this->emit('\OC\Updater', 'dbSimulateUpgrade');
|
|
|
|
}
|
|
|
|
|
|
|
|
protected function doCoreUpgrade() {
|
2015-10-21 10:17:38 +03:00
|
|
|
$this->emit('\OC\Updater', 'dbUpgradeBefore');
|
|
|
|
|
2014-07-24 19:18:54 +04:00
|
|
|
// do the real upgrade
|
|
|
|
\OC_DB::updateDbFromStructure(\OC::$SERVERROOT . '/db_structure.xml');
|
|
|
|
|
|
|
|
$this->emit('\OC\Updater', 'dbUpgrade');
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2014-09-18 19:45:30 +04:00
|
|
|
* @param string $version the oc version to check app compatibility with
|
2014-07-24 19:18:54 +04:00
|
|
|
*/
|
|
|
|
protected function checkAppUpgrade($version) {
|
|
|
|
$apps = \OC_App::getEnabledApps();
|
2015-10-21 10:17:38 +03:00
|
|
|
$this->emit('\OC\Updater', 'appUpgradeCheckBefore');
|
2014-07-24 19:18:54 +04:00
|
|
|
|
|
|
|
foreach ($apps as $appId) {
|
2015-02-17 14:00:39 +03:00
|
|
|
$info = \OC_App::getAppInfo($appId);
|
|
|
|
$compatible = \OC_App::isAppCompatible($version, $info);
|
|
|
|
$isShipped = \OC_App::isShipped($appId);
|
2014-07-24 19:18:54 +04:00
|
|
|
|
2015-02-17 14:00:39 +03:00
|
|
|
if ($compatible && $isShipped && \OC_App::shouldUpgrade($appId)) {
|
2014-11-11 19:26:08 +03:00
|
|
|
/**
|
|
|
|
* FIXME: The preupdate check is performed before the database migration, otherwise database changes
|
|
|
|
* are not possible anymore within it. - Consider this when touching the code.
|
|
|
|
* @link https://github.com/owncloud/core/issues/10980
|
|
|
|
* @see \OC_App::updateApp
|
|
|
|
*/
|
|
|
|
if (file_exists(\OC_App::getAppPath($appId) . '/appinfo/preupdate.php')) {
|
|
|
|
$this->includePreUpdate($appId);
|
|
|
|
}
|
2014-07-24 19:18:54 +04:00
|
|
|
if (file_exists(\OC_App::getAppPath($appId) . '/appinfo/database.xml')) {
|
2015-10-21 10:17:38 +03:00
|
|
|
$this->emit('\OC\Updater', 'appSimulateUpdate', array($appId));
|
2014-07-24 19:18:54 +04:00
|
|
|
\OC_DB::simulateUpdateDbFromStructure(\OC_App::getAppPath($appId) . '/appinfo/database.xml');
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
$this->emit('\OC\Updater', 'appUpgradeCheck');
|
|
|
|
}
|
|
|
|
|
2014-11-11 19:26:08 +03:00
|
|
|
/**
|
|
|
|
* Includes the pre-update file. Done here to prevent namespace mixups.
|
|
|
|
* @param string $appId
|
|
|
|
*/
|
|
|
|
private function includePreUpdate($appId) {
|
|
|
|
include \OC_App::getAppPath($appId) . '/appinfo/preupdate.php';
|
|
|
|
}
|
|
|
|
|
2015-02-03 21:02:25 +03:00
|
|
|
/**
|
|
|
|
* upgrades all apps within a major ownCloud upgrade. Also loads "priority"
|
|
|
|
* (types authentication, filesystem, logging, in that order) afterwards.
|
|
|
|
*
|
|
|
|
* @throws NeedsUpdateException
|
|
|
|
*/
|
2014-07-24 19:18:54 +04:00
|
|
|
protected function doAppUpgrade() {
|
|
|
|
$apps = \OC_App::getEnabledApps();
|
2015-02-03 21:02:25 +03:00
|
|
|
$priorityTypes = array('authentication', 'filesystem', 'logging');
|
|
|
|
$pseudoOtherType = 'other';
|
|
|
|
$stacks = array($pseudoOtherType => array());
|
2014-07-24 19:18:54 +04:00
|
|
|
|
|
|
|
foreach ($apps as $appId) {
|
2015-02-03 21:02:25 +03:00
|
|
|
$priorityType = false;
|
|
|
|
foreach ($priorityTypes as $type) {
|
|
|
|
if(!isset($stacks[$type])) {
|
|
|
|
$stacks[$type] = array();
|
|
|
|
}
|
|
|
|
if (\OC_App::isType($appId, $type)) {
|
|
|
|
$stacks[$type][] = $appId;
|
|
|
|
$priorityType = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!$priorityType) {
|
|
|
|
$stacks[$pseudoOtherType][] = $appId;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
foreach ($stacks as $type => $stack) {
|
|
|
|
foreach ($stack as $appId) {
|
|
|
|
if (\OC_App::shouldUpgrade($appId)) {
|
2016-04-19 16:36:11 +03:00
|
|
|
$this->emit('\OC\Updater', 'appUpgradeStarted', [$appId, \OC_App::getAppVersion($appId)]);
|
2015-02-03 21:02:25 +03:00
|
|
|
\OC_App::updateApp($appId);
|
2016-04-19 16:36:11 +03:00
|
|
|
$this->emit('\OC\Updater', 'appUpgrade', [$appId, \OC_App::getAppVersion($appId)]);
|
2015-02-03 21:02:25 +03:00
|
|
|
}
|
|
|
|
if($type !== $pseudoOtherType) {
|
|
|
|
// load authentication, filesystem and logging apps after
|
|
|
|
// upgrading them. Other apps my need to rely on modifying
|
|
|
|
// user and/or filesystem aspects.
|
|
|
|
\OC_App::loadApp($appId, false);
|
|
|
|
}
|
2014-07-24 19:18:54 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2015-02-17 14:00:39 +03:00
|
|
|
|
|
|
|
/**
|
|
|
|
* check if the current enabled apps are compatible with the current
|
|
|
|
* ownCloud version. disable them if not.
|
|
|
|
* This is important if you upgrade ownCloud and have non ported 3rd
|
|
|
|
* party apps installed.
|
2015-06-28 12:25:28 +03:00
|
|
|
*
|
|
|
|
* @return array
|
|
|
|
* @throws \Exception
|
2015-02-17 14:00:39 +03:00
|
|
|
*/
|
|
|
|
private function checkAppsRequirements() {
|
2015-02-24 14:51:55 +03:00
|
|
|
$isCoreUpgrade = $this->isCodeUpgrade();
|
2015-02-17 14:00:39 +03:00
|
|
|
$apps = OC_App::getEnabledApps();
|
2015-12-18 17:26:54 +03:00
|
|
|
$version = \OCP\Util::getVersion();
|
2015-03-13 14:16:16 +03:00
|
|
|
$disabledApps = [];
|
2015-02-17 14:00:39 +03:00
|
|
|
foreach ($apps as $app) {
|
|
|
|
// check if the app is compatible with this version of ownCloud
|
|
|
|
$info = OC_App::getAppInfo($app);
|
|
|
|
if(!OC_App::isAppCompatible($version, $info)) {
|
|
|
|
OC_App::disable($app);
|
|
|
|
$this->emit('\OC\Updater', 'incompatibleAppDisabled', array($app));
|
|
|
|
}
|
2015-02-24 14:51:55 +03:00
|
|
|
// no need to disable any app in case this is a non-core upgrade
|
|
|
|
if (!$isCoreUpgrade) {
|
|
|
|
continue;
|
|
|
|
}
|
2015-02-19 17:59:20 +03:00
|
|
|
// shipped apps will remain enabled
|
|
|
|
if (OC_App::isShipped($app)) {
|
|
|
|
continue;
|
2015-02-17 14:00:39 +03:00
|
|
|
}
|
2015-02-19 17:59:20 +03:00
|
|
|
// authentication and session apps will remain enabled as well
|
|
|
|
if (OC_App::isType($app, ['session', 'authentication'])) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2015-05-20 18:06:00 +03:00
|
|
|
// disable any other 3rd party apps if not overriden
|
|
|
|
if(!$this->skip3rdPartyAppsDisable) {
|
|
|
|
\OC_App::disable($app);
|
|
|
|
$disabledApps[]= $app;
|
|
|
|
$this->emit('\OC\Updater', 'thirdPartyAppDisabled', array($app));
|
|
|
|
};
|
2015-02-17 14:00:39 +03:00
|
|
|
}
|
2015-03-13 14:16:16 +03:00
|
|
|
return $disabledApps;
|
2015-02-17 14:00:39 +03:00
|
|
|
}
|
2015-02-24 14:51:55 +03:00
|
|
|
|
2015-06-28 12:25:28 +03:00
|
|
|
/**
|
|
|
|
* @return bool
|
|
|
|
*/
|
2015-02-24 14:51:55 +03:00
|
|
|
private function isCodeUpgrade() {
|
|
|
|
$installedVersion = $this->config->getSystemValue('version', '0.0.0');
|
2015-12-18 17:26:54 +03:00
|
|
|
$currentVersion = implode('.', \OCP\Util::getVersion());
|
2015-02-24 14:51:55 +03:00
|
|
|
if (version_compare($currentVersion, $installedVersion, '>')) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
2015-03-13 14:16:16 +03:00
|
|
|
|
2015-06-28 12:25:28 +03:00
|
|
|
/**
|
|
|
|
* @param array $disabledApps
|
|
|
|
* @throws \Exception
|
|
|
|
*/
|
|
|
|
private function upgradeAppStoreApps(array $disabledApps) {
|
2015-03-13 14:16:16 +03:00
|
|
|
foreach($disabledApps as $app) {
|
2015-10-09 14:44:30 +03:00
|
|
|
try {
|
|
|
|
if (OC_Installer::isUpdateAvailable($app)) {
|
|
|
|
$ocsId = \OC::$server->getConfig()->getAppValue($app, 'ocsid', '');
|
2015-03-13 14:16:16 +03:00
|
|
|
|
2015-10-09 14:44:30 +03:00
|
|
|
$this->emit('\OC\Updater', 'upgradeAppStoreApp', array($app));
|
|
|
|
OC_Installer::updateAppByOCSId($ocsId);
|
|
|
|
}
|
|
|
|
} catch (\Exception $ex) {
|
|
|
|
$this->log->logException($ex, ['app' => 'core']);
|
2015-03-13 14:16:16 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2016-04-19 16:36:11 +03:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Forward messages emitted by the repair routine
|
|
|
|
*/
|
|
|
|
private function emitRepairEvents() {
|
|
|
|
$dispatcher = \OC::$server->getEventDispatcher();
|
|
|
|
$dispatcher->addListener('\OC\Repair::warning', function ($event) {
|
|
|
|
if ($event instanceof GenericEvent) {
|
|
|
|
$this->emit('\OC\Updater', 'repairWarning', $event->getArguments());
|
|
|
|
}
|
|
|
|
});
|
|
|
|
$dispatcher->addListener('\OC\Repair::error', function ($event) {
|
|
|
|
if ($event instanceof GenericEvent) {
|
|
|
|
$this->emit('\OC\Updater', 'repairError', $event->getArguments());
|
|
|
|
}
|
|
|
|
});
|
|
|
|
$dispatcher->addListener('\OC\Repair::info', function ($event) {
|
|
|
|
if ($event instanceof GenericEvent) {
|
|
|
|
$this->emit('\OC\Updater', 'repairInfo', $event->getArguments());
|
|
|
|
}
|
|
|
|
});
|
|
|
|
$dispatcher->addListener('\OC\Repair::step', function ($event) {
|
|
|
|
if ($event instanceof GenericEvent) {
|
|
|
|
$this->emit('\OC\Updater', 'repairStep', $event->getArguments());
|
|
|
|
}
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
2013-07-06 19:00:00 +04:00
|
|
|
}
|
2014-02-18 19:26:37 +04:00
|
|
|
|