nextcloud/apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php

434 lines
12 KiB
PHP
Raw Normal View History

<?php
/**
2016-07-21 17:49:16 +03:00
* @copyright Copyright (c) 2016, ownCloud, Inc.
*
* @author Joas Schilling <coding@schilljs.com>
* @author Morris Jobke <hey@morrisjobke.de>
2016-07-21 19:13:36 +03:00
* @author Robin Appelman <robin@icewind.nl>
* @author Roeland Jago Douma <roeland@famdouma.nl>
2016-01-12 17:02:16 +03:00
* @author Thomas Müller <thomas.mueller@tmit.eu>
* @author Vincent Petry <pvince81@owncloud.com>
*
* @license AGPL-3.0
*
* This code is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License, version 3,
* as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License, version 3,
* along with this program. If not, see <http://www.gnu.org/licenses/>
2016-01-12 17:02:16 +03:00
*
*/
2015-10-30 18:05:25 +03:00
namespace OCA\DAV\Tests\Unit\Connector\Sabre;
use OC\Files\FileInfo;
use OC\Files\Storage\Wrapper\Quota;
use OCA\DAV\Connector\Sabre\Directory;
use OCP\Files\ForbiddenException;
class TestViewDirectory extends \OC\Files\View {
private $updatables;
private $deletables;
private $canRename;
public function __construct($updatables, $deletables, $canRename = true) {
$this->updatables = $updatables;
$this->deletables = $deletables;
$this->canRename = $canRename;
}
public function isUpdatable($path) {
return $this->updatables[$path];
}
public function isCreatable($path) {
return $this->updatables[$path];
}
public function isDeletable($path) {
return $this->deletables[$path];
}
public function rename($path1, $path2) {
return $this->canRename;
}
public function getRelativePath($path) {
return $path;
}
}
2016-05-25 16:39:52 +03:00
/**
* @group DB
*/
2016-05-25 17:04:15 +03:00
class DirectoryTest extends \Test\TestCase {
2015-10-30 18:05:25 +03:00
/** @var \OC\Files\View | \PHPUnit_Framework_MockObject_MockObject */
private $view;
2015-10-30 18:05:25 +03:00
/** @var \OC\Files\FileInfo | \PHPUnit_Framework_MockObject_MockObject */
private $info;
protected function setUp(): void {
parent::setUp();
$this->view = $this->createMock('OC\Files\View');
$this->info = $this->createMock('OC\Files\FileInfo');
$this->info->expects($this->any())
->method('isReadable')
->willReturn(true);
}
private function getDir($path = '/') {
$this->view->expects($this->once())
->method('getRelativePath')
->willReturn($path);
$this->info->expects($this->once())
->method('getPath')
->willReturn($path);
return new Directory($this->view, $this->info);
}
public function testDeleteRootFolderFails() {
$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
$this->info->expects($this->any())
->method('isDeletable')
->willReturn(true);
$this->view->expects($this->never())
->method('rmdir');
$dir = $this->getDir();
$dir->delete();
}
public function testDeleteForbidden() {
$this->expectException(\OCA\DAV\Connector\Sabre\Exception\Forbidden::class);
// deletion allowed
$this->info->expects($this->once())
->method('isDeletable')
->willReturn(true);
// but fails
$this->view->expects($this->once())
->method('rmdir')
->with('sub')
->willThrowException(new ForbiddenException('', true));
$dir = $this->getDir('sub');
$dir->delete();
}
public function testDeleteFolderWhenAllowed() {
// deletion allowed
$this->info->expects($this->once())
->method('isDeletable')
->willReturn(true);
// but fails
$this->view->expects($this->once())
->method('rmdir')
->with('sub')
->willReturn(true);
$dir = $this->getDir('sub');
$dir->delete();
}
public function testDeleteFolderFailsWhenNotAllowed() {
$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
$this->info->expects($this->once())
->method('isDeletable')
->willReturn(false);
$dir = $this->getDir('sub');
$dir->delete();
}
public function testDeleteFolderThrowsWhenDeletionFailed() {
$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
// deletion allowed
$this->info->expects($this->once())
->method('isDeletable')
->willReturn(true);
// but fails
$this->view->expects($this->once())
->method('rmdir')
->with('sub')
->willReturn(false);
$dir = $this->getDir('sub');
$dir->delete();
}
public function testGetChildren() {
$info1 = $this->getMockBuilder(FileInfo::class)
->disableOriginalConstructor()
->getMock();
$info2 = $this->getMockBuilder(FileInfo::class)
->disableOriginalConstructor()
->getMock();
$info1->expects($this->any())
->method('getName')
->willReturn('first');
$info1->expects($this->any())
->method('getEtag')
->willReturn('abc');
$info2->expects($this->any())
->method('getName')
->willReturn('second');
$info2->expects($this->any())
->method('getEtag')
->willReturn('def');
$this->view->expects($this->once())
->method('getDirectoryContent')
->with('')
->willReturn(array($info1, $info2));
$this->view->expects($this->any())
->method('getRelativePath')
->willReturn('');
$dir = new Directory($this->view, $this->info);
$nodes = $dir->getChildren();
$this->assertEquals(2, count($nodes));
// calling a second time just returns the cached values,
// does not call getDirectoryContents again
$dir->getChildren();
}
public function testGetChildrenNoPermission() {
$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
$info = $this->createMock(FileInfo::class);
$info->expects($this->any())
->method('isReadable')
->willReturn(false);
$dir = new Directory($this->view, $info);
$dir->getChildren();
}
public function testGetChildNoPermission() {
$this->expectException(\Sabre\DAV\Exception\NotFound::class);
$this->info->expects($this->any())
->method('isReadable')
->willReturn(false);
$dir = new Directory($this->view, $this->info);
$dir->getChild('test');
}
public function testGetChildThrowStorageNotAvailableException() {
$this->expectException(\Sabre\DAV\Exception\ServiceUnavailable::class);
$this->view->expects($this->once())
->method('getFileInfo')
->willThrowException(new \OCP\Files\StorageNotAvailableException());
$dir = new Directory($this->view, $this->info);
$dir->getChild('.');
}
public function testGetChildThrowInvalidPath() {
$this->expectException(\OCA\DAV\Connector\Sabre\Exception\InvalidPath::class);
$this->view->expects($this->once())
->method('verifyPath')
->willThrowException(new \OCP\Files\InvalidPathException());
$this->view->expects($this->never())
->method('getFileInfo');
$dir = new Directory($this->view, $this->info);
$dir->getChild('.');
}
2015-02-13 19:59:47 +03:00
public function testGetQuotaInfoUnlimited() {
$storage = $this->getMockBuilder(Quota::class)
2015-02-13 19:59:47 +03:00
->disableOriginalConstructor()
->getMock();
$storage->expects($this->any())
->method('instanceOfStorage')
->willReturnMap([
'\OCA\Files_Sharing\SharedStorage' => false,
'\OC\Files\Storage\Wrapper\Quota' => false,
]);
$storage->expects($this->never())
->method('getQuota');
2015-02-13 19:59:47 +03:00
$storage->expects($this->once())
->method('free_space')
->willReturn(800);
$this->info->expects($this->once())
->method('getSize')
->willReturn(200);
$this->info->expects($this->once())
->method('getStorage')
->willReturn($storage);
$dir = new Directory($this->view, $this->info);
$this->assertEquals([200, -3], $dir->getQuotaInfo()); //200 used, unlimited
}
public function testGetQuotaInfoSpecific() {
$storage = $this->getMockBuilder(Quota::class)
->disableOriginalConstructor()
->getMock();
$storage->expects($this->any())
2015-02-13 19:59:47 +03:00
->method('instanceOfStorage')
->willReturnMap([
['\OCA\Files_Sharing\SharedStorage', false],
['\OC\Files\Storage\Wrapper\Quota', true],
]);
2015-02-13 19:59:47 +03:00
$storage->expects($this->once())
->method('getQuota')
->willReturn(1000);
2015-02-13 19:59:47 +03:00
$storage->expects($this->once())
->method('free_space')
->willReturn(800);
2015-02-13 19:59:47 +03:00
$this->info->expects($this->once())
->method('getSize')
->willReturn(200);
2015-02-13 19:59:47 +03:00
$this->info->expects($this->once())
->method('getStorage')
->willReturn($storage);
2015-02-13 19:59:47 +03:00
$dir = new Directory($this->view, $this->info);
2015-02-13 19:59:47 +03:00
$this->assertEquals([200, 800], $dir->getQuotaInfo()); //200 used, 800 free
}
/**
* @dataProvider moveFailedProvider
*/
public function testMoveFailed($source, $destination, $updatables, $deletables) {
$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
$this->moveTest($source, $destination, $updatables, $deletables);
}
/**
* @dataProvider moveSuccessProvider
*/
public function testMoveSuccess($source, $destination, $updatables, $deletables) {
$this->moveTest($source, $destination, $updatables, $deletables);
$this->addToAssertionCount(1);
}
/**
* @dataProvider moveFailedInvalidCharsProvider
*/
public function testMoveFailedInvalidChars($source, $destination, $updatables, $deletables) {
$this->expectException(\OCA\DAV\Connector\Sabre\Exception\InvalidPath::class);
$this->moveTest($source, $destination, $updatables, $deletables);
}
public function moveFailedInvalidCharsProvider() {
return [
['a/b', 'a/*', ['a' => true, 'a/b' => true, 'a/c*' => false], []],
];
}
public function moveFailedProvider() {
return [
['a/b', 'a/c', ['a' => false, 'a/b' => false, 'a/c' => false], []],
['a/b', 'b/b', ['a' => false, 'a/b' => false, 'b' => false, 'b/b' => false], []],
['a/b', 'b/b', ['a' => false, 'a/b' => true, 'b' => false, 'b/b' => false], []],
['a/b', 'b/b', ['a' => true, 'a/b' => true, 'b' => false, 'b/b' => false], []],
['a/b', 'b/b', ['a' => true, 'a/b' => true, 'b' => true, 'b/b' => false], ['a/b' => false]],
['a/b', 'a/c', ['a' => false, 'a/b' => true, 'a/c' => false], []],
];
}
public function moveSuccessProvider() {
return [
['a/b', 'b/b', ['a' => true, 'a/b' => true, 'b' => true, 'b/b' => false], ['a/b' => true]],
// older files with special chars can still be renamed to valid names
['a/b*', 'b/b', ['a' => true, 'a/b*' => true, 'b' => true, 'b/b' => false], ['a/b*' => true]],
];
}
/**
* @param $source
* @param $destination
* @param $updatables
*/
private function moveTest($source, $destination, $updatables, $deletables) {
$view = new TestViewDirectory($updatables, $deletables);
$sourceInfo = new FileInfo($source, null, null, [], null);
$targetInfo = new FileInfo(dirname($destination), null, null, [], null);
$sourceNode = new Directory($view, $sourceInfo);
$targetNode = $this->getMockBuilder(Directory::class)
->setMethods(['childExists'])
->setConstructorArgs([$view, $targetInfo])
->getMock();
$targetNode->expects($this->any())->method('childExists')
->with(basename($destination))
->willReturn(false);
$this->assertTrue($targetNode->moveInto(basename($destination), $source, $sourceNode));
}
public function testFailingMove() {
$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
$this->expectExceptionMessage('Could not copy directory b, target exists');
$source = 'a/b';
$destination = 'c/b';
$updatables = ['a' => true, 'a/b' => true, 'b' => true, 'c/b' => false];
$deletables = ['a/b' => true];
$view = new TestViewDirectory($updatables, $deletables);
$sourceInfo = new FileInfo($source, null, null, [], null);
$targetInfo = new FileInfo(dirname($destination), null, null, [], null);
$sourceNode = new Directory($view, $sourceInfo);
$targetNode = $this->getMockBuilder(Directory::class)
->setMethods(['childExists'])
->setConstructorArgs([$view, $targetInfo])
->getMock();
$targetNode->expects($this->once())->method('childExists')
->with(basename($destination))
->willReturn(true);
$targetNode->moveInto(basename($destination), $source, $sourceNode);
}
}