nextcloud/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php

451 lines
13 KiB
PHP
Raw Normal View History

2015-08-09 22:19:35 +03:00
<?php
2015-08-11 16:43:44 +03:00
/**
2016-07-21 17:49:16 +03:00
* @copyright Copyright (c) 2016, ownCloud, Inc.
*
* @author Arthur Schiwon <blizzz@arthur-schiwon.de>
* @author Bjoern Schiessle <bjoern@schiessle.org>
2016-07-21 17:49:16 +03:00
* @author Joas Schilling <coding@schilljs.com>
* @author Lukas Reschke <lukas@statuscode.ch>
* @author Robin Appelman <robin@icewind.nl>
2016-07-21 17:49:16 +03:00
* @author Roeland Jago Douma <roeland@famdouma.nl>
2016-01-12 17:02:16 +03:00
* @author Thomas Müller <thomas.mueller@tmit.eu>
2015-08-11 16:43:44 +03:00
*
* @license AGPL-3.0
*
* This code is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License, version 3,
* as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License, version 3,
* along with this program. If not, see <http://www.gnu.org/licenses/>
*
*/
namespace OCA\Files_Sharing\Tests\Controller;
2015-08-09 22:19:35 +03:00
use OCA\Files_Sharing\Controller\ShareesAPIController;
2016-05-17 12:42:03 +03:00
use OCA\Files_Sharing\Tests\TestCase;
2015-09-15 16:51:54 +03:00
use OCP\AppFramework\Http;
use OCP\AppFramework\OCS\OCSBadRequestException;
use OCP\Collaboration\Collaborators\ISearch;
use OCP\IConfig;
use OCP\IRequest;
use OCP\IURLGenerator;
2015-08-26 11:51:26 +03:00
use OCP\Share;
use OCP\Share\IManager;
2015-08-09 22:19:35 +03:00
2015-11-03 03:52:41 +03:00
/**
* Class ShareesTest
*
* @group DB
*
* @package OCA\Files_Sharing\Tests\API
*/
class ShareesAPIControllerTest extends TestCase {
/** @var ShareesAPIController */
2015-08-11 16:43:44 +03:00
protected $sharees;
2015-08-09 22:19:35 +03:00
/** @var string */
protected $uid;
/** @var IRequest|\PHPUnit_Framework_MockObject_MockObject */
2015-08-26 11:51:26 +03:00
protected $request;
/** @var IManager|\PHPUnit_Framework_MockObject_MockObject */
protected $shareManager;
/** @var ISearch|\PHPUnit_Framework_MockObject_MockObject */
protected $collaboratorSearch;
2015-08-11 16:43:44 +03:00
protected function setUp() {
parent::setUp();
2015-08-09 22:19:35 +03:00
$this->uid = 'test123';
$this->request = $this->createMock(IRequest::class);
$this->shareManager = $this->createMock(IManager::class);
2015-08-09 22:19:35 +03:00
/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject $configMock */
$configMock = $this->createMock(IConfig::class);
/** @var IURLGenerator|\PHPUnit_Framework_MockObject_MockObject $urlGeneratorMock */
$urlGeneratorMock = $this->createMock(IURLGenerator::class);
$this->collaboratorSearch = $this->createMock(ISearch::class);
$this->sharees = new ShareesAPIController(
$this->uid,
'files_sharing',
$this->request,
$configMock,
$urlGeneratorMock,
$this->shareManager,
$this->collaboratorSearch
2015-08-11 16:43:44 +03:00
);
2015-08-09 22:19:35 +03:00
}
2015-08-12 16:03:50 +03:00
public function dataSearch() {
$noRemote = [Share::SHARE_TYPE_USER, Share::SHARE_TYPE_GROUP, Share::SHARE_TYPE_EMAIL];
$allTypes = [Share::SHARE_TYPE_USER, Share::SHARE_TYPE_GROUP, Share::SHARE_TYPE_REMOTE, Share::SHARE_TYPE_REMOTE_GROUP, Share::SHARE_TYPE_EMAIL];
2015-08-12 18:05:20 +03:00
2015-08-12 16:03:50 +03:00
return [
[[], '', 'yes', true, true, true, $noRemote, false, true, true],
2015-08-12 16:03:50 +03:00
// Test itemType
[[
'search' => '',
], '', 'yes', true, true, true, $noRemote, false, true, true],
2015-08-12 16:03:50 +03:00
[[
'search' => 'foobar',
], '', 'yes', true, true, true, $noRemote, false, true, true],
2015-08-12 16:03:50 +03:00
[[
'search' => 0,
], '', 'yes', true, true, true, $noRemote, false, true, true],
2015-08-12 16:03:50 +03:00
// Test itemType
[[
'itemType' => '',
], '', 'yes', true, true, true, $noRemote, false, true, true],
2015-08-12 16:03:50 +03:00
[[
'itemType' => 'folder',
], '', 'yes', true, true, true, $allTypes, false, true, true],
2015-08-12 16:03:50 +03:00
[[
'itemType' => 0,
], '', 'yes', true, true , true, $noRemote, false, true, true],
2015-08-12 16:03:50 +03:00
// Test shareType
[[
'itemType' => 'call',
], '', 'yes', true, true, true, $noRemote, false, true, true],
[[
'itemType' => 'folder',
], '', 'yes', true, true, true, $allTypes, false, true, true],
2015-08-12 16:03:50 +03:00
[[
'itemType' => 'folder',
2015-08-12 16:03:50 +03:00
'shareType' => 0,
], '', 'yes', true, true, false, [0], false, true, true],
2015-08-12 16:03:50 +03:00
[[
'itemType' => 'folder',
2015-08-12 16:03:50 +03:00
'shareType' => '0',
], '', 'yes', true, true, false, [0], false, true, true],
2015-08-12 16:03:50 +03:00
[[
'itemType' => 'folder',
2015-08-12 16:03:50 +03:00
'shareType' => 1,
], '', 'yes', true, true, false, [1], false, true, true],
2015-08-12 16:03:50 +03:00
[[
'itemType' => 'folder',
2015-08-12 18:05:20 +03:00
'shareType' => 12,
], '', 'yes', true, true, false, [], false, true, true],
2015-08-12 16:03:50 +03:00
[[
'itemType' => 'folder',
2015-08-12 16:03:50 +03:00
'shareType' => 'foobar',
], '', 'yes', true, true, true, $allTypes, false, true, true],
2015-08-12 18:05:20 +03:00
[[
'itemType' => 'folder',
2015-08-12 18:05:20 +03:00
'shareType' => [0, 1, 2],
], '', 'yes', false, false, false, [0, 1], false, true, true],
2015-08-12 18:05:20 +03:00
[[
'itemType' => 'folder',
2015-08-12 18:05:20 +03:00
'shareType' => [0, 1],
], '', 'yes', false, false, false, [0, 1], false, true, true],
[[
'itemType' => 'folder',
'shareType' => $allTypes,
], '', 'yes', true, true, true, $allTypes, false, true, true],
2015-08-12 18:05:20 +03:00
[[
'itemType' => 'folder',
2015-08-12 18:05:20 +03:00
'shareType' => $allTypes,
], '', 'yes', false, false, false, [0, 1], false, true, true],
2015-08-12 18:05:20 +03:00
[[
'itemType' => 'folder',
2015-08-12 18:05:20 +03:00
'shareType' => $allTypes,
], '', 'yes', true, false, false, [0, 6], false, true, false],
[[
'itemType' => 'folder',
'shareType' => $allTypes,
], '', 'yes', false, false, true, [0, 4], false, true, false],
[[
'itemType' => 'folder',
'shareType' => $allTypes,
], '', 'yes', true, true, false, [0, 6, 9], false, true, false],
2015-08-12 16:03:50 +03:00
// Test pagination
[[
'itemType' => 'folder',
2015-08-12 16:03:50 +03:00
'page' => 1,
], '', 'yes', true, true, true, $allTypes, false, true, true],
2015-08-12 16:03:50 +03:00
[[
'itemType' => 'folder',
2015-08-12 16:03:50 +03:00
'page' => 10,
], '', 'yes', true, true, true, $allTypes, false, true, true],
2015-08-12 16:03:50 +03:00
2015-09-15 13:14:14 +03:00
// Test perPage
2015-08-12 16:03:50 +03:00
[[
'itemType' => 'folder',
2015-09-15 13:14:14 +03:00
'perPage' => 1,
], '', 'yes', true, true, true, $allTypes, false, true, true],
2015-08-12 16:03:50 +03:00
[[
'itemType' => 'folder',
2015-09-15 13:14:14 +03:00
'perPage' => 10,
], '', 'yes', true, true, true, $allTypes, false, true, true],
2015-08-12 16:03:50 +03:00
// Test $shareWithGroupOnly setting
[[
'itemType' => 'folder',
], 'no', 'yes', true, true, true, $allTypes, false, true, true],
[[
'itemType' => 'folder',
], 'yes', 'yes', true, true, true, $allTypes, true, true, true],
// Test $shareeEnumeration setting
[[
'itemType' => 'folder',
], 'no', 'yes', true, true, true, $allTypes, false, true, true],
[[
'itemType' => 'folder',
], 'no', 'no', true, true, true, $allTypes, false, false, true],
2015-08-12 16:03:50 +03:00
];
}
/**
* @dataProvider dataSearch
*
* @param array $getData
* @param string $apiSetting
* @param string $enumSetting
2015-08-12 18:05:20 +03:00
* @param bool $remoteSharingEnabled
* @param bool $isRemoteGroupSharingEnabled
* @param bool $emailSharingEnabled
2015-08-12 18:05:20 +03:00
* @param array $shareTypes
2015-08-12 16:03:50 +03:00
* @param bool $shareWithGroupOnly
* @param bool $shareeEnumeration
* @param bool $allowGroupSharing
* @throws OCSBadRequestException
2015-08-12 16:03:50 +03:00
*/
public function testSearch($getData, $apiSetting, $enumSetting, $remoteSharingEnabled, $isRemoteGroupSharingEnabled, $emailSharingEnabled, $shareTypes, $shareWithGroupOnly, $shareeEnumeration, $allowGroupSharing) {
$search = isset($getData['search']) ? $getData['search'] : '';
$itemType = isset($getData['itemType']) ? $getData['itemType'] : 'irrelevant';
$page = isset($getData['page']) ? $getData['page'] : 1;
$perPage = isset($getData['perPage']) ? $getData['perPage'] : 200;
$shareType = isset($getData['shareType']) ? $getData['shareType'] : null;
2015-08-12 16:03:50 +03:00
/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject $config */
$config = $this->createMock(IConfig::class);
$config->expects($this->exactly(2))
2015-08-12 16:03:50 +03:00
->method('getAppValue')
->with('core', $this->anything(), $this->anything())
->willReturnMap([
['core', 'shareapi_only_share_with_group_members', 'no', $apiSetting],
['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', $enumSetting],
]);
2015-08-12 16:03:50 +03:00
$this->shareManager->expects($itemType === 'file' || $itemType === 'folder' ? $this->once() : $this->never())
->method('allowGroupSharing')
->willReturn($allowGroupSharing);
/** @var string */
$uid = 'test123';
/** @var IRequest|\PHPUnit_Framework_MockObject_MockObject $request */
$request = $this->createMock(IRequest::class);
/** @var IURLGenerator|\PHPUnit_Framework_MockObject_MockObject $urlGenerator */
$urlGenerator = $this->createMock(IURLGenerator::class);
/** @var \PHPUnit_Framework_MockObject_MockObject|\OCA\Files_Sharing\Controller\ShareesAPIController $sharees */
$sharees = $this->getMockBuilder('\OCA\Files_Sharing\Controller\ShareesAPIController')
2015-08-12 16:03:50 +03:00
->setConstructorArgs([
$uid,
'files_sharing',
$request,
2015-08-12 16:03:50 +03:00
$config,
$urlGenerator,
$this->shareManager,
$this->collaboratorSearch
2015-08-12 16:03:50 +03:00
])
->setMethods(['isRemoteSharingAllowed', 'shareProviderExists', 'isRemoteGroupSharingAllowed'])
2015-08-12 16:03:50 +03:00
->getMock();
$this->collaboratorSearch->expects($this->once())
->method('search')
->with($search, $shareTypes, $this->anything(), $perPage, $perPage * ($page -1))
->willReturn([[], false]);
2015-08-12 18:05:20 +03:00
$sharees->expects($this->any())
->method('isRemoteSharingAllowed')
->with($itemType)
->willReturn($remoteSharingEnabled);
2015-08-12 16:03:50 +03:00
$sharees->expects($this->any())
->method('isRemoteGroupSharingAllowed')
->with($itemType)
->willReturn($isRemoteGroupSharingEnabled);
$this->shareManager->expects($this->any())
->method('shareProviderExists')
->will($this->returnCallback(function($shareType) use ($emailSharingEnabled) {
if ($shareType === \OCP\Share::SHARE_TYPE_EMAIL) {
return $emailSharingEnabled;
} else {
return false;
}
}));
$this->assertInstanceOf(Http\DataResponse::class, $sharees->search($search, $itemType, $page, $perPage, $shareType));
2015-08-12 16:03:50 +03:00
2015-08-26 11:51:26 +03:00
$this->assertSame($shareWithGroupOnly, $this->invokePrivate($sharees, 'shareWithGroupOnly'));
$this->assertSame($shareeEnumeration, $this->invokePrivate($sharees, 'shareeEnumeration'));
2015-08-12 16:03:50 +03:00
}
public function dataSearchInvalid() {
return [
// Test invalid pagination
[[
'page' => 0,
2015-09-15 16:51:54 +03:00
], 'Invalid page'],
[[
'page' => '0',
2015-09-15 16:51:54 +03:00
], 'Invalid page'],
[[
'page' => -1,
2015-09-15 16:51:54 +03:00
], 'Invalid page'],
// Test invalid perPage
[[
'perPage' => 0,
2015-09-15 16:51:54 +03:00
], 'Invalid perPage argument'],
[[
'perPage' => '0',
2015-09-15 16:51:54 +03:00
], 'Invalid perPage argument'],
[[
'perPage' => -1,
2015-09-15 16:51:54 +03:00
], 'Invalid perPage argument'],
];
}
/**
* @dataProvider dataSearchInvalid
*
* @param array $getData
* @param string $message
*/
2015-09-15 16:51:54 +03:00
public function testSearchInvalid($getData, $message) {
$page = isset($getData['page']) ? $getData['page'] : 1;
$perPage = isset($getData['perPage']) ? $getData['perPage'] : 200;
/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject $config */
$config = $this->createMock(IConfig::class);
$config->expects($this->never())
->method('getAppValue');
/** @var string */
$uid = 'test123';
/** @var IRequest|\PHPUnit_Framework_MockObject_MockObject $request */
$request = $this->createMock(IRequest::class);
/** @var IURLGenerator|\PHPUnit_Framework_MockObject_MockObject $urlGenerator */
$urlGenerator = $this->createMock(IURLGenerator::class);
/** @var \PHPUnit_Framework_MockObject_MockObject|\OCA\Files_Sharing\Controller\ShareesAPIController $sharees */
$sharees = $this->getMockBuilder('\OCA\Files_Sharing\Controller\ShareesAPIController')
->setConstructorArgs([
$uid,
'files_sharing',
$request,
$config,
$urlGenerator,
$this->shareManager,
$this->collaboratorSearch
])
->setMethods(['isRemoteSharingAllowed'])
->getMock();
$sharees->expects($this->never())
->method('isRemoteSharingAllowed');
$this->collaboratorSearch->expects($this->never())
->method('search');
try {
$sharees->search('', null, $page, $perPage, null);
$this->fail();
} catch (OCSBadRequestException $e) {
$this->assertEquals($message, $e->getMessage());
}
}
2015-08-12 18:05:20 +03:00
public function dataIsRemoteSharingAllowed() {
return [
['file', true],
['folder', true],
['', false],
['contacts', false],
];
}
/**
* @dataProvider dataIsRemoteSharingAllowed
*
* @param string $itemType
* @param bool $expected
*/
public function testIsRemoteSharingAllowed($itemType, $expected) {
$this->assertSame($expected, $this->invokePrivate($this->sharees, 'isRemoteSharingAllowed', [$itemType]));
}
/**
* @expectedException \OCP\AppFramework\OCS\OCSBadRequestException
* @expectedExceptionMessage Missing itemType
*/
public function testSearchNoItemType() {
$this->sharees->search('', null, 1, 10, [], false);
}
2015-08-26 11:51:26 +03:00
public function dataGetPaginationLink() {
return [
2015-09-15 13:14:14 +03:00
[1, '/ocs/v1.php', ['perPage' => 2], '<?perPage=2&page=2>; rel="next"'],
[10, '/ocs/v2.php', ['perPage' => 2], '<?perPage=2&page=11>; rel="next"'],
];
}
/**
2015-08-26 11:51:26 +03:00
* @dataProvider dataGetPaginationLink
*
2015-08-26 11:51:26 +03:00
* @param int $page
* @param string $scriptName
* @param array $params
* @param array $expected
*/
2015-08-26 11:51:26 +03:00
public function testGetPaginationLink($page, $scriptName, $params, $expected) {
$this->request->expects($this->once())
->method('getScriptName')
->willReturn($scriptName);
2015-08-26 11:51:26 +03:00
$this->assertEquals($expected, $this->invokePrivate($this->sharees, 'getPaginationLink', [$page, $params]));
}
2015-08-26 11:51:26 +03:00
public function dataIsV2() {
return [
2015-08-26 11:51:26 +03:00
['/ocs/v1.php', false],
['/ocs/v2.php', true],
];
}
/**
2015-08-26 11:51:26 +03:00
* @dataProvider dataIsV2
*
2015-08-26 11:51:26 +03:00
* @param string $scriptName
* @param bool $expected
*/
2015-08-26 11:51:26 +03:00
public function testIsV2($scriptName, $expected) {
$this->request->expects($this->once())
->method('getScriptName')
->willReturn($scriptName);
$this->assertEquals($expected, $this->invokePrivate($this->sharees, 'isV2'));
}
2015-08-09 22:19:35 +03:00
}