nextcloud/tests/lib/appframework/http/DispatcherTest.php

439 lines
12 KiB
PHP
Raw Normal View History

2013-08-17 13:16:48 +04:00
<?php
/**
* ownCloud - App Framework
*
* @author Bernhard Posselt
* @copyright 2012 Bernhard Posselt <dev@bernhard-posselt.com>
2013-08-17 13:16:48 +04:00
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
* License as published by the Free Software Foundation; either
* version 3 of the License, or any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU AFFERO GENERAL PUBLIC LICENSE for more details.
*
* You should have received a copy of the GNU Affero General Public
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OC\AppFramework\Http;
use OC\AppFramework\Middleware\MiddlewareDispatcher;
use OC\AppFramework\Utility\ControllerMethodReflector;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\JSONResponse;
use OCP\AppFramework\Http\DataResponse;
use OCP\AppFramework\Controller;
class TestController extends Controller {
public function __construct($appName, $request) {
parent::__construct($appName, $request);
}
/**
* @param int $int
* @param bool $bool
*/
public function exec($int, $bool, $test=4, $test2=1) {
$this->registerResponder('text', function($in) {
return new JSONResponse(array('text' => $in));
});
return array($int, $bool, $test, $test2);
}
/**
* @param int $int
* @param bool $bool
*/
public function execDataResponse($int, $bool, $test=4, $test2=1) {
return new DataResponse(array(
'text' => array($int, $bool, $test, $test2)
));
}
}
2013-08-17 13:16:48 +04:00
class DispatcherTest extends \Test\TestCase {
2013-08-17 13:16:48 +04:00
private $middlewareDispatcher;
private $dispatcher;
private $controllerMethod;
private $response;
private $lastModified;
private $etag;
private $http;
private $reflector;
2013-08-17 13:16:48 +04:00
protected function setUp() {
parent::setUp();
2013-08-17 13:16:48 +04:00
$this->controllerMethod = 'test';
2013-10-07 13:25:50 +04:00
$app = $this->getMockBuilder(
'OC\AppFramework\DependencyInjection\DIContainer')
2013-08-17 13:16:48 +04:00
->disableOriginalConstructor()
->getMock();
$request = $this->getMockBuilder(
'\OC\AppFramework\Http\Request')
->disableOriginalConstructor()
->getMock();
$this->http = $this->getMockBuilder(
'\OC\AppFramework\Http')
2013-08-17 13:16:48 +04:00
->disableOriginalConstructor()
->getMock();
$this->middlewareDispatcher = $this->getMockBuilder(
'\OC\AppFramework\Middleware\MiddlewareDispatcher')
->disableOriginalConstructor()
->getMock();
$this->controller = $this->getMock(
'\OCP\AppFramework\Controller',
2013-10-07 13:25:50 +04:00
array($this->controllerMethod), array($app, $request));
$this->request = $this->getMockBuilder(
'\OC\AppFramework\Http\Request')
->disableOriginalConstructor()
->getMock();
$this->reflector = new ControllerMethodReflector();
2013-08-17 13:16:48 +04:00
$this->dispatcher = new Dispatcher(
$this->http, $this->middlewareDispatcher, $this->reflector,
$this->request
);
2013-08-17 13:16:48 +04:00
$this->response = $this->getMockBuilder(
'\OCP\AppFramework\Http\Response')
2013-08-17 13:16:48 +04:00
->disableOriginalConstructor()
->getMock();
$this->lastModified = new \DateTime(null, new \DateTimeZone('GMT'));
$this->etag = 'hi';
}
/**
* @param string $out
* @param string $httpHeaders
*/
private function setMiddlewareExpectations($out=null,
2013-08-17 13:16:48 +04:00
$httpHeaders=null, $responseHeaders=array(),
$ex=false, $catchEx=true) {
if($ex) {
$exception = new \Exception();
$this->middlewareDispatcher->expects($this->once())
->method('beforeController')
->with($this->equalTo($this->controller),
2013-08-17 13:16:48 +04:00
$this->equalTo($this->controllerMethod))
->will($this->throwException($exception));
if($catchEx) {
$this->middlewareDispatcher->expects($this->once())
->method('afterException')
->with($this->equalTo($this->controller),
2013-08-17 13:16:48 +04:00
$this->equalTo($this->controllerMethod),
$this->equalTo($exception))
->will($this->returnValue($this->response));
} else {
$this->middlewareDispatcher->expects($this->once())
->method('afterException')
->with($this->equalTo($this->controller),
2013-08-17 13:16:48 +04:00
$this->equalTo($this->controllerMethod),
$this->equalTo($exception))
->will($this->returnValue(null));
return;
}
} else {
$this->middlewareDispatcher->expects($this->once())
->method('beforeController')
->with($this->equalTo($this->controller),
2013-08-17 13:16:48 +04:00
$this->equalTo($this->controllerMethod));
$this->controller->expects($this->once())
->method($this->controllerMethod)
->will($this->returnValue($this->response));
}
$this->response->expects($this->once())
->method('render')
->will($this->returnValue($out));
$this->response->expects($this->once())
->method('getStatus')
->will($this->returnValue(Http::STATUS_OK));
$this->response->expects($this->once())
->method('getLastModified')
->will($this->returnValue($this->lastModified));
$this->response->expects($this->once())
->method('getETag')
->will($this->returnValue($this->etag));
$this->response->expects($this->once())
->method('getHeaders')
->will($this->returnValue($responseHeaders));
$this->http->expects($this->once())
->method('getStatusHeader')
->with($this->equalTo(Http::STATUS_OK),
2013-08-17 13:16:48 +04:00
$this->equalTo($this->lastModified),
$this->equalTo($this->etag))
->will($this->returnValue($httpHeaders));
2013-08-17 13:16:48 +04:00
$this->middlewareDispatcher->expects($this->once())
->method('afterController')
->with($this->equalTo($this->controller),
2013-08-17 13:16:48 +04:00
$this->equalTo($this->controllerMethod),
$this->equalTo($this->response))
->will($this->returnValue($this->response));
$this->middlewareDispatcher->expects($this->once())
->method('afterController')
->with($this->equalTo($this->controller),
2013-08-17 13:16:48 +04:00
$this->equalTo($this->controllerMethod),
$this->equalTo($this->response))
->will($this->returnValue($this->response));
$this->middlewareDispatcher->expects($this->once())
->method('beforeOutput')
->with($this->equalTo($this->controller),
2013-08-17 13:16:48 +04:00
$this->equalTo($this->controllerMethod),
$this->equalTo($out))
->will($this->returnValue($out));
2013-08-17 13:16:48 +04:00
}
public function testDispatcherReturnsArrayWith2Entries() {
$this->setMiddlewareExpectations();
2013-08-17 13:16:48 +04:00
$response = $this->dispatcher->dispatch($this->controller,
2013-08-17 13:16:48 +04:00
$this->controllerMethod);
$this->assertNull($response[0]);
$this->assertEquals(array(), $response[1]);
$this->assertNull($response[2]);
}
public function testHeadersAndOutputAreReturned(){
$out = 'yo';
$httpHeaders = 'Http';
$responseHeaders = array('hell' => 'yeah');
$this->setMiddlewareExpectations($out, $httpHeaders, $responseHeaders);
2013-08-17 13:16:48 +04:00
$response = $this->dispatcher->dispatch($this->controller,
2013-08-17 13:16:48 +04:00
$this->controllerMethod);
$this->assertEquals($httpHeaders, $response[0]);
$this->assertEquals($responseHeaders, $response[1]);
$this->assertEquals($out, $response[2]);
}
public function testExceptionCallsAfterException() {
// TODO fails on PHP 5.3
if (version_compare(PHP_VERSION, '5.4.0', '<')) {
$this->markTestSkipped('Fails on PHP 5.3');
}
2013-08-17 13:16:48 +04:00
$out = 'yo';
$httpHeaders = 'Http';
$responseHeaders = array('hell' => 'yeah');
$this->setMiddlewareExpectations($out, $httpHeaders, $responseHeaders, true);
2013-08-17 13:16:48 +04:00
$response = $this->dispatcher->dispatch($this->controller,
2013-08-17 13:16:48 +04:00
$this->controllerMethod);
$this->assertEquals($httpHeaders, $response[0]);
$this->assertEquals($responseHeaders, $response[1]);
$this->assertEquals($out, $response[2]);
}
public function testExceptionThrowsIfCanNotBeHandledByAfterException() {
// TODO fails on PHP 5.3 and crashed travis (10 minute timeout)
if (version_compare(PHP_VERSION, '5.4.0', '<')) {
$this->markTestSkipped('Fails on PHP 5.3 and causes infinite loop - travis fails after 10 minute timeout');
}
2013-08-17 13:16:48 +04:00
$out = 'yo';
$httpHeaders = 'Http';
$responseHeaders = array('hell' => 'yeah');
$this->setMiddlewareExpectations($out, $httpHeaders, $responseHeaders, true, false);
2013-08-17 13:16:48 +04:00
$this->setExpectedException('\Exception');
$response = $this->dispatcher->dispatch($this->controller,
2013-08-17 13:16:48 +04:00
$this->controllerMethod);
}
private function dispatcherPassthrough() {
$this->middlewareDispatcher->expects($this->once())
->method('beforeController');
$this->middlewareDispatcher->expects($this->once())
->method('afterController')
->will($this->returnCallback(function($a, $b, $in) {
return $in;
}));
$this->middlewareDispatcher->expects($this->once())
->method('beforeOutput')
->will($this->returnCallback(function($a, $b, $in) {
return $in;
}));
}
public function testControllerParametersInjected() {
$this->request = new Request(array(
'post' => array(
'int' => '3',
'bool' => 'false'
),
'method' => 'POST'
));
$this->dispatcher = new Dispatcher(
$this->http, $this->middlewareDispatcher, $this->reflector,
$this->request
);
$controller = new TestController('app', $this->request);
// reflector is supposed to be called once
$this->dispatcherPassthrough();
$response = $this->dispatcher->dispatch($controller, 'exec');
$this->assertEquals('[3,true,4,1]', $response[2]);
}
public function testControllerParametersInjectedDefaultOverwritten() {
$this->request = new Request(array(
'post' => array(
'int' => '3',
'bool' => 'false',
'test2' => 7
),
'method' => 'POST'
));
$this->dispatcher = new Dispatcher(
$this->http, $this->middlewareDispatcher, $this->reflector,
$this->request
);
$controller = new TestController('app', $this->request);
// reflector is supposed to be called once
$this->dispatcherPassthrough();
$response = $this->dispatcher->dispatch($controller, 'exec');
$this->assertEquals('[3,true,4,7]', $response[2]);
}
public function testResponseTransformedByUrlFormat() {
$this->request = new Request(array(
'post' => array(
'int' => '3',
'bool' => 'false'
),
'urlParams' => array(
'format' => 'text'
),
'method' => 'GET'
));
$this->dispatcher = new Dispatcher(
$this->http, $this->middlewareDispatcher, $this->reflector,
$this->request
);
$controller = new TestController('app', $this->request);
// reflector is supposed to be called once
$this->dispatcherPassthrough();
$response = $this->dispatcher->dispatch($controller, 'exec');
$this->assertEquals('{"text":[3,false,4,1]}', $response[2]);
}
public function testResponseTransformsDataResponse() {
$this->request = new Request(array(
'post' => array(
'int' => '3',
'bool' => 'false'
),
'urlParams' => array(
'format' => 'json'
),
'method' => 'GET'
));
$this->dispatcher = new Dispatcher(
$this->http, $this->middlewareDispatcher, $this->reflector,
$this->request
);
$controller = new TestController('app', $this->request);
// reflector is supposed to be called once
$this->dispatcherPassthrough();
$response = $this->dispatcher->dispatch($controller, 'execDataResponse');
$this->assertEquals('{"text":[3,false,4,1]}', $response[2]);
}
public function testResponseTransformedByAcceptHeader() {
$this->request = new Request(array(
'post' => array(
'int' => '3',
'bool' => 'false'
),
'server' => array(
'HTTP_ACCEPT' => 'application/text, test',
'HTTP_CONTENT_TYPE' => 'application/x-www-form-urlencoded'
),
'method' => 'PUT'
));
$this->dispatcher = new Dispatcher(
$this->http, $this->middlewareDispatcher, $this->reflector,
$this->request
);
$controller = new TestController('app', $this->request);
// reflector is supposed to be called once
$this->dispatcherPassthrough();
$response = $this->dispatcher->dispatch($controller, 'exec');
$this->assertEquals('{"text":[3,false,4,1]}', $response[2]);
}
public function testResponsePrimarilyTransformedByParameterFormat() {
$this->request = new Request(array(
'post' => array(
'int' => '3',
'bool' => 'false'
),
'get' => array(
'format' => 'text'
),
'server' => array(
'HTTP_ACCEPT' => 'application/json, test'
),
'method' => 'POST'
));
$this->dispatcher = new Dispatcher(
$this->http, $this->middlewareDispatcher, $this->reflector,
$this->request
);
$controller = new TestController('app', $this->request);
// reflector is supposed to be called once
$this->dispatcherPassthrough();
$response = $this->dispatcher->dispatch($controller, 'exec');
$this->assertEquals('{"text":[3,true,4,1]}', $response[2]);
}
2013-08-17 13:16:48 +04:00
}