mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

URLEncode logout attribute 

Otherwise logout can fail if the requesttoken contains a +
This commit is contained in:
Lukas Reschke 2015-02-13 11:35:12 +01:00
parent dfcd4acd5a
commit 025110821f
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/private/security/securerandom.php
View File

@ -64,8 +64,7 @@ class SecureRandom implements ISecureRandom {
* Generate a random string of specified length. * Generate a random string of specified length.
* @param string $length The length of the generated string * @param string $length The length of the generated string
* @param string $characters An optional list of characters to use if no characterlist is * @param string $characters An optional list of characters to use if no characterlist is
* specified 0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ./ * specified all valid base64 characters are used.
* is used.
* @return string * @return string
* @throws \Exception If the generator is not initialized. * @throws \Exception If the generator is not initialized.
*/ */

2
lib/private/user.php
View File

@ -366,7 +366,7 @@ class OC_User {
return $backend->getLogoutAttribute(); return $backend->getLogoutAttribute();
} }
return 'href="' . link_to('', 'index.php') . '?logout=true&requesttoken=' . OC_Util::callRegister() . '"'; return 'href="' . link_to('', 'index.php') . '?logout=true&requesttoken=' . urlencode(OC_Util::callRegister()) . '"';
} }
/** /**

5
lib/public/security/isecurerandom.php
View File

@ -53,9 +53,10 @@ interface ISecureRandom {
/** /**
* Generate a random string of specified length. * Generate a random string of specified length.
* @param string $length The length of the generated string * @param string $length The length of the generated string
* @param string $characters An optional list of characters to use * @param string $characters An optional list of characters to use if no characterlist is
* specified all valid base64 characters are used.
* @return string * @return string
* @throws \Exception * @throws \Exception If the generator is not initialized.
*/ */
public function generate($length, $characters = ''); public function generate($length, $characters = '');
} }