mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Return correct error message on share download without read permission 

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This commit is contained in:
Morris Jobke 2020-10-26 16:22:27 +01:00
parent ca1dc0009d
commit 0390a90d70
No known key found for this signature in database
GPG Key ID: FE03C3A163FEDE68
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/files_sharing/lib/Controller/ShareController.php
View File

@ -556,7 +556,7 @@ class ShareController extends AuthPublicShareController {
$share = $this->shareManager->getShareByToken($token);
if (!($share->getPermissions() & \OCP\Constants::PERMISSION_READ)) {
return new \OCP\AppFramework\Http\DataResponse('Share is read-only');
return new \OCP\AppFramework\Http\DataResponse('Share has no read permission');
}
$files_list = null;

2
apps/files_sharing/tests/Controller/ShareControllerTest.php
View File

@ -840,7 +840,7 @@ class ShareControllerTest extends \Test\TestCase {
// Test with a password protected share and no authentication
$response = $this->shareController->downloadShare('validtoken');
$expectedResponse = new DataResponse('Share is read-only');
$expectedResponse = new DataResponse('Share has no read permission');
$this->assertEquals($expectedResponse, $response);
}