mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix duplicate tag info view registration 

Only register the tag info view once as it's stored in a singleton.
This fixes an issue where the tag info view did not get rendered after
swiching between different file views.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
This commit is contained in:
Vincent Petry 2021-02-02 16:32:24 +01:00 committed by backportbot[bot]
parent ee8c35614a
commit 04473c0f0e
3 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/systemtags/js/systemtags.js
View File

File diff suppressed because one or more lines are too long

2
apps/systemtags/js/systemtags.js.map
View File

File diff suppressed because one or more lines are too long

11
apps/systemtags/src/filesplugin.js
View File

@ -31,9 +31,14 @@
return
}
const systemTagsInfoView = new OCA.SystemTags.SystemTagsInfoView()
fileList.registerDetailView(systemTagsInfoView)
OCA.SystemTags.View = systemTagsInfoView
// only create and attach once
// FIXME: this should likely be done on a different code path now
// for the sidebar to only have it registered once
if (!OCA.SystemTags.View) {
const systemTagsInfoView = new OCA.SystemTags.SystemTagsInfoView()
fileList.registerDetailView(systemTagsInfoView)
OCA.SystemTags.View = systemTagsInfoView
}
},
}