Merge pull request #6981 from nextcloud/unit-tests-for-6977
Unit tests for #6977
This commit is contained in:
commit
062aadba06
|
@ -138,6 +138,32 @@ class LoggerTest extends TestCase {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @dataProvider userAndPasswordData
|
||||||
|
*/
|
||||||
|
public function testDetectclosure($user, $password) {
|
||||||
|
$a = function($user, $password) {
|
||||||
|
throw new \Exception('test');
|
||||||
|
};
|
||||||
|
|
||||||
|
try {
|
||||||
|
$a($user, $password);
|
||||||
|
} catch (\Exception $e) {
|
||||||
|
$this->logger->logException($e);
|
||||||
|
}
|
||||||
|
$logLines = $this->getLogs();
|
||||||
|
|
||||||
|
foreach($logLines as $logLine) {
|
||||||
|
$log = explode('\n', $logLine);
|
||||||
|
unset($log[1]); // Remove `testDetectclosure(` because we are not testing this here, but the closure on stack trace 0
|
||||||
|
$logLine = implode('\n', $log);
|
||||||
|
|
||||||
|
$this->assertNotContains($user, $logLine);
|
||||||
|
$this->assertNotContains($password, $logLine);
|
||||||
|
$this->assertContains('{closure}(*** sensitive parameters replaced ***)', $logLine);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
public function dataGetLogClass() {
|
public function dataGetLogClass() {
|
||||||
return [
|
return [
|
||||||
['file', \OC\Log\File::class],
|
['file', \OC\Log\File::class],
|
||||||
|
|
Loading…
Reference in New Issue