From 6576c782a4b6b0acb51945da73d7fc8ed78a9a71 Mon Sep 17 00:00:00 2001 From: Christoph Wurst Date: Tue, 28 Jan 2020 14:29:41 +0100 Subject: [PATCH] Do not encode contacts menu mailto links Signed-off-by: Christoph Wurst --- lib/private/Contacts/ContactsMenu/ActionFactory.php | 2 +- tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/private/Contacts/ContactsMenu/ActionFactory.php b/lib/private/Contacts/ContactsMenu/ActionFactory.php index 6bc724bd43..2841c5ad20 100644 --- a/lib/private/Contacts/ContactsMenu/ActionFactory.php +++ b/lib/private/Contacts/ContactsMenu/ActionFactory.php @@ -50,7 +50,7 @@ class ActionFactory implements IActionFactory { * @return ILinkAction */ public function newEMailAction($icon, $name, $email) { - return $this->newLinkAction($icon, $name, 'mailto:' . urlencode($email)); + return $this->newLinkAction($icon, $name, 'mailto:' . $email); } } diff --git a/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php b/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php index d1273c2b9a..299946ed21 100644 --- a/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php +++ b/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php @@ -61,7 +61,7 @@ class ActionFactoryTest extends TestCase { $this->assertInstanceOf(IAction::class, $action); $this->assertEquals($name, $action->getName()); $this->assertEquals(10, $action->getPriority()); - $this->assertEquals('mailto:user%40example.com', $action->getHref()); + $this->assertEquals('mailto:user@example.com', $action->getHref()); } }