mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #27316 from nextcloud/bugfix/noid/getNumberOfUnreadCommentsForObjects 

Fix populating the array and closing the cursors
This commit is contained in:
Lukas Reschke 2021-06-01 21:01:01 +02:00 committed by GitHub
parent 84584959b0 c0c5340f4e
commit 09503b0269
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/private/Comments/Manager.php
View File

@ -655,16 +655,16 @@ class Manager implements ICommentsManager {
$query->andWhere($query->expr()->eq('c.verb', $query->createNamedParameter($verb))); $query->andWhere($query->expr()->eq('c.verb', $query->createNamedParameter($verb)));
} }
$unreadComments = array_fill_keys($objectIds, 0);
foreach (array_chunk($objectIds, 1000) as $chunk) { foreach (array_chunk($objectIds, 1000) as $chunk) {
$query->setParameter('ids', $chunk, IQueryBuilder::PARAM_INT_ARRAY); $query->setParameter('ids', $chunk, IQueryBuilder::PARAM_INT_ARRAY);
$result = $query->execute();
$unreadComments += array_fill_keys($objectIds, 0); $result = $query->executeQuery();
while ($row = $result->fetch()) { while ($row = $result->fetch()) {
$unreadComments[$row['object_id']] = (int) $row['num_comments']; $unreadComments[$row['object_id']] = (int) $row['num_comments'];
} }
$result->closeCursor();
} }
$result->closeCursor();
return $unreadComments; return $unreadComments;
} }