Return value immediately instead of assigning to a one-time variable

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

apps/dav/lib/CardDAV/Converter.php

@@ -143,8 +143,7 @@ class Converter {
 	 */
 	private function getAvatarImage(IUser $user) {
 		try {
-			$image = $user->getAvatarImage(-1);
+			return $user->getAvatarImage(-1);
-			return $image;
 		} catch (\Exception $ex) {
 			return null;
 		}

apps/dav/lib/Connector/Sabre/FilesPlugin.php

@@ -340,8 +340,7 @@ class FilesPlugin extends ServerPlugin {
 			});
 
 			$propFind->handle(self::IS_ENCRYPTED_PROPERTYNAME, function() use ($node) {
-				$result = $node->getFileInfo()->isEncrypted() ? '1' : '0';
+				return $node->getFileInfo()->isEncrypted() ? '1' : '0';
-				return $result;
 			});
 
 			$propFind->handle(self::HAS_PREVIEW_PROPERTYNAME, function () use ($node) {

apps/encryption/lib/Util.php

@@ -196,8 +196,7 @@ class Util {
 	 * @return \OC\Files\Storage\Storage
 	 */
 	public function getStorage($path) {
-		$storage = $this->files->getMount($path)->getStorage();
+		return $this->files->getMount($path)->getStorage();
-		return $storage;
 	}
 
 }

apps/federatedfilesharing/lib/AddressHandler.php

@@ -84,8 +84,7 @@ class AddressHandler {
 	 * @return string url of the current server
 	 */
 	public function generateRemoteURL() {
-		$url = $this->urlGenerator->getAbsoluteURL('/');
+		return $this->urlGenerator->getAbsoluteURL('/');
-		return $url;
 	}
 
 	/**

apps/files_external/3rdparty/icewind/smb/src/Share.php

@@ -370,8 +370,7 @@ class Share extends AbstractShare {
 	protected function execute($command) {
 		$this->connect();
 		$this->connection->write($command . PHP_EOL);
-		$output = $this->connection->read();
+		return $this->connection->read();
-		return $output;
 	}
 
 	/**

apps/files_external/lib/Service/UserStoragesService.php

@@ -112,8 +112,7 @@ class UserStoragesService extends StoragesService {
 	 */
 	public function addStorage(StorageConfig $newStorage) {
 		$newStorage->setApplicableUsers([$this->getUser()->getUID()]);
-		$config = parent::addStorage($newStorage);
+		return parent::addStorage($newStorage);
-		return $config;
 	}
 
 	/**

apps/files_sharing/lib/Controller/ShareesAPIController.php

@@ -230,9 +230,7 @@ class ShareesAPIController extends OCSController {
 			$url = $this->urlGenerator->getAbsoluteURL('/ocs/v1.php/apps/files_sharing/api/v1/sharees') . '?';
 		}
 		$params['page'] = $page + 1;
-		$link = '<' . $url . http_build_query($params) . '>; rel="next"';
+		return '<' . $url . http_build_query($params) . '>; rel="next"';
-
-		return $link;
 	}
 
 	/**

apps/files_sharing/lib/ShareBackend/Folder.php

@@ -73,9 +73,7 @@ class Folder extends File implements \OCP\Share_Backend_Collection {
 		$query = \OCP\DB::prepare('SELECT `parent` FROM `*PREFIX*filecache` WHERE `fileid` = ?');
 		$result = $query->execute(array($child));
 		$row = $result->fetchRow();
-		$parent = $row ? $row['parent'] : null;
+		return $row ? $row['parent'] : null;
-
-		return $parent;
 	}
 
 	public function getChildren($itemSource) {

apps/files_trashbin/lib/Storage.php

@@ -254,8 +254,7 @@ class Storage extends Wrapper {
 	 * @return MoveToTrashEvent
 	 */
 	protected function createMoveToTrashEvent(Node $node) {
-		$event = new MoveToTrashEvent($node);
+		return new MoveToTrashEvent($node);
-		return $event;
 	}
 
 	/**

apps/twofactor_backupcodes/lib/Provider/BackupCodesProvider.php

@@ -90,8 +90,7 @@ class BackupCodesProvider implements IProvider {
 	 * @return Template
 	 */
 	public function getTemplate(IUser $user) {
-		$tmpl = new Template('twofactor_backupcodes', 'challenge');
+		return new Template('twofactor_backupcodes', 'challenge');
-		return $tmpl;
 	}
 
 	/**

apps/user_ldap/lib/Helper.php

@@ -123,8 +123,7 @@ class Helper {
 		sort($serverConnections);
 		$lastKey = array_pop($serverConnections);
 		$lastNumber = intval(str_replace('s', '', $lastKey));
-		$nextPrefix = 's' . str_pad($lastNumber + 1, 2, '0', STR_PAD_LEFT);
+		return 's' . str_pad($lastNumber + 1, 2, '0', STR_PAD_LEFT);
-		return $nextPrefix;
 	}
 
 	private function getServersConfig($value) {

core/Command/Config/Import.php

@@ -113,8 +113,7 @@ class Import extends Command implements CompletionAwareInterface  {
 	 * @return string
 	 */
 	protected function getArrayFromFile($importFile) {
-		$content = file_get_contents($importFile);
+		return file_get_contents($importFile);
-		return $content;
 	}
 
 	/**

lib/private/App/Platform.php

@@ -94,7 +94,6 @@ class Platform {
 
 	public function getLibraryVersion($name) {
 		$repo = new PlatformRepository();
-		$lib = $repo->findLibrary($name);
+		return $repo->findLibrary($name);
-		return $lib;
 	}
 }

lib/private/Files/View.php

@@ -426,8 +426,7 @@ class View {
 				flush();
 			}
 			fclose($handle);
-			$size = $this->filesize($path);
+			return $this->filesize($path);
-			return $size;
 		}
 		return false;
 	}
@@ -476,8 +475,7 @@ class View {
 					echo fread($handle, $len);
 					flush();
 				}
-				$size = ftell($handle) - $from;
+				return ftell($handle) - $from;
-				return $size;
 			}
 
 			throw new \OCP\Files\UnseekableException('fseek error');
@@ -1083,8 +1081,7 @@ class View {
 			}
 			list($storage, $internalPath) = Filesystem::resolvePath($absolutePath . $postFix);
 			if ($storage) {
-				$result = $storage->hash($type, $internalPath, $raw);
+				return $storage->hash($type, $internalPath, $raw);
-				return $result;
 			}
 		}
 		return null;

lib/private/Security/CertificateManager.php

@@ -249,9 +249,7 @@ class CertificateManager implements ICertificateManager {
 		if ($uid === '') {
 			$uid = $this->uid;
 		}
-		$path = is_null($uid) ? '/files_external/' : '/' . $uid . '/files_external/';
+		return is_null($uid) ? '/files_external/' : '/' . $uid . '/files_external/';
-
-		return $path;
 	}
 
 	/**

lib/private/Server.php

@@ -243,9 +243,7 @@ class Server extends ServerContainer implements IServerContainer {
 		$this->registerService('SystemTagManagerFactory', function (Server $c) {
 			$config = $c->getConfig();
 			$factoryClass = $config->getSystemValue('systemtags.managerFactory', '\OC\SystemTag\ManagerFactory');
-			/** @var \OC\SystemTag\ManagerFactory $factory */
+			return new $factoryClass($this);
-			$factory = new $factoryClass($this);
-			return $factory;
 		});
 		$this->registerService(\OCP\SystemTag\ISystemTagManager::class, function (Server $c) {
 			return $c->query('SystemTagManagerFactory')->getManager();

lib/private/legacy/db.php

@@ -170,8 +170,7 @@ class OC_DB {
 	 */
 	public static function createDbFromStructure( $file ) {
 		$schemaManager = self::getMDB2SchemaManager();
-		$result = $schemaManager->createDbFromStructure($file);
+		return $schemaManager->createDbFromStructure($file);
-		return $result;
 	}
 
 	/**

lib/private/legacy/db/statementwrapper.php

@@ -77,8 +77,7 @@ class OC_DB_StatementWrapper {
 			return false;
 		}
 		if ($this->isManipulation) {
-			$count = $this->statement->rowCount();
+			return $this->statement->rowCount();
-			return $count;
 		} else {
 			return $this;
 		}

settings/Controller/UsersController.php

@@ -723,9 +723,7 @@ class UsersController extends Controller {
 	protected function signMessage(IUser $user, $message) {
 		$privateKey = $this->keyManager->getKey($user)->getPrivate();
 		openssl_sign(json_encode($message), $signature, $privateKey, OPENSSL_ALGO_SHA512);
-		$signatureBase64 = base64_encode($signature);
+		return base64_encode($signature);
-
-		return $signatureBase64;
 	}
 
 	/**