From 0f454ff5aa0ca7b89b7deb3a9f888d1551a870ca Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Mon, 11 Jan 2016 15:58:32 +0100 Subject: [PATCH] Use namedparameter --- lib/private/share20/defaultshareprovider.php | 9 +++------ tests/lib/share20/defaultshareprovidertest.php | 3 --- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/lib/private/share20/defaultshareprovider.php b/lib/private/share20/defaultshareprovider.php index 7a08ecb121..1d9a207296 100644 --- a/lib/private/share20/defaultshareprovider.php +++ b/lib/private/share20/defaultshareprovider.php @@ -185,8 +185,7 @@ class DefaultShareProvider implements IShareProvider { $qb = $this->dbConn->getQueryBuilder(); $qb->select('*') ->from('share') - ->where($qb->expr()->eq('parent', $qb->createParameter('parent'))) - ->setParameter(':parent', $parent->getId()) + ->where($qb->expr()->eq('parent', $qb->createNamedParameter($parent->getId()))) ->orderBy('id'); $cursor = $qb->execute(); @@ -210,8 +209,7 @@ class DefaultShareProvider implements IShareProvider { $qb = $this->dbConn->getQueryBuilder(); $qb->delete('share') - ->where($qb->expr()->eq('id', $qb->createParameter('id'))) - ->setParameter(':id', $share->getId()); + ->where($qb->expr()->eq('id', $qb->createNamedParameter($share->getId()))); try { $qb->execute(); @@ -244,8 +242,7 @@ class DefaultShareProvider implements IShareProvider { $qb->select('*') ->from('share') - ->where($qb->expr()->eq('id', $qb->createParameter('id'))) - ->setParameter(':id', $id); + ->where($qb->expr()->eq('id', $qb->createNamedParameter($id))); $cursor = $qb->execute(); $data = $cursor->fetch(); diff --git a/tests/lib/share20/defaultshareprovidertest.php b/tests/lib/share20/defaultshareprovidertest.php index 166fbd25f1..4db6b2b14e 100644 --- a/tests/lib/share20/defaultshareprovidertest.php +++ b/tests/lib/share20/defaultshareprovidertest.php @@ -374,9 +374,6 @@ class DefaultShareProviderTest extends \Test\TestCase { $qb->expects($this->once()) ->method('where') ->will($this->returnSelf()); - $qb->expects($this->once()) - ->method('setParameter') - ->will($this->returnSelf()); $qb->expects($this->once()) ->method('execute') ->will($this->throwException(new \Exception));