mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #18108 from nextcloud/refactor/strict-credential-store 

Add return type hint to credential store and make it strict
This commit is contained in:
Roeland Jago Douma 2019-11-26 08:08:10 +01:00 committed by GitHub
parent 123c4aa4e0 128a460d7b
commit 0fab27f459
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/private/Authentication/LoginCredentials/Store.php
View File

@ -1,4 +1,5 @@
<?php <?php declare(strict_types=1);
/** /**
* @copyright 2016 Christoph Wurst <christoph@winzerhof-wurst.at> * @copyright 2016 Christoph Wurst <christoph@winzerhof-wurst.at>
* *
@ -82,8 +83,8 @@ class Store implements IStore {
* @return ICredentials the login credentials of the current user * @return ICredentials the login credentials of the current user
* @throws CredentialsUnavailableException * @throws CredentialsUnavailableException
*/ */
public function getLoginCredentials() { public function getLoginCredentials(): ICredentials {
if (is_null($this->tokenProvider)) { if ($this->tokenProvider === null) {
throw new CredentialsUnavailableException(); throw new CredentialsUnavailableException();
} }

9
lib/public/Authentication/LoginCredentials/IStore.php
View File

@ -1,4 +1,5 @@
<?php <?php declare(strict_types=1);
/** /**
* @copyright 2016 Christoph Wurst <christoph@winzerhof-wurst.at> * @copyright 2016 Christoph Wurst <christoph@winzerhof-wurst.at>
* *
@ -29,7 +30,7 @@ use OCP\Authentication\Exceptions\CredentialsUnavailableException;
* @since 12 * @since 12
*/ */
interface IStore { interface IStore {
/** /**
* Get login credentials of the currently logged in user * Get login credentials of the currently logged in user
* *
@ -38,6 +39,6 @@ interface IStore {
* @throws CredentialsUnavailableException * @throws CredentialsUnavailableException
* @return ICredentials the login credentials of the current user * @return ICredentials the login credentials of the current user
*/ */
public function getLoginCredentials(); public function getLoginCredentials(): ICredentials;
} }