Prefetching blows up if there are a lot of files.

I saw instances where people had a lot of files (each with custom
properties) and all this prefetching blew up and started to consume an
insane amount of RAM resulting in the process getting killed.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This commit is contained in:
Roeland Jago Douma 2019-04-17 21:37:16 +02:00 committed by Backportbot
parent 7d5ab15ac0
commit 10aeef9786
2 changed files with 0 additions and 11 deletions

View File

@ -129,13 +129,6 @@ class CustomPropertiesBackend implements BackendInterface {
return;
}
if ($node instanceof Directory
&& $propFind->getDepth() !== 0
) {
// note: pre-fetching only supported for depth <= 1
$this->loadChildrenProperties($node, $requestedProps);
}
$props = $this->getProperties($node, $requestedProps);
foreach ($props as $propName => $propValue) {
$propFind->set($propName, $propValue);

View File

@ -226,10 +226,6 @@ class CustomPropertiesBackendTest extends \Test\TestCase {
->method('getPath')
->will($this->returnValue('/dummypath/test.txt'));
$rootNode->expects($this->once())
->method('getChildren')
->will($this->returnValue(array($nodeSub)));
$this->tree->expects($this->at(0))
->method('getNodeForPath')
->with('/dummypath')