From db4fccce51c3aa3a2b7721b3266d5fe82e48640d Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Fri, 12 Aug 2011 01:53:24 +0200 Subject: [PATCH 01/19] styled hovering file list more subtle --- files/css/files.css | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/files/css/files.css b/files/css/files.css index 319cbf0c87..c856d3a6bd 100644 --- a/files/css/files.css +++ b/files/css/files.css @@ -26,7 +26,8 @@ /* FILE TABLE */ span#emptyfolder { position:absolute; margin:10em 0 0 10em; font-size:1.5em; font-weight:bold; color:#888; text-shadow:#fff 0 1px 0; } table { position:relative; top:37px; width:100%; } -tbody tr:hover, tbody tr:active, tbody tr.selected { background-color:#eee; height:1em; } +tbody tr:hover, tbody tr:active, tbody tr.selected { background-color:#f8f8f8; height:1em; } +tbody tr.selected { background-color:#eee; } tbody a { color:#000; } span.extention, td.date { color:#999; } div.crumb { float:left; display:block; background:no-repeat right 0; padding:.75em 1.5em 0 1em; height:2.9em; } @@ -43,17 +44,17 @@ table th#headerDate, table td.date { width:11em; padding:0 .1em 0 1em; text-alig table td.selection, table th.selection, table td.fileaction { width:2em; text-align:center; } table td.filename a.name { display:block; height:1.5em; vertical-align:middle; margin-left:3em; } table tr[data-type="dir"] td.filename a.name {font-weight:bold; } -table td.filename a.name input, table td.filename a.name form { width:100%; cursor:text } +table td.filename a.name input, table td.filename a.name form { width:100%; cursor:text; } table td.filename a, table td.login, table td.logout, table td.download, table td.upload, table td.create, table td.delete { padding:.2em .5em .5em 0; } table td.filename .nametext, .modified { float:left; padding:.3em 0; } table td.filename .nametext { width:60%; } table td.filename form { float:left; font-size:.85em; } -table thead.fixed tr{position:fixed; top:6.3em; z-index:49; -moz-box-shadow:0 -3px 7px #000; -webkit-box-shadow:0 -3px 7px #000; box-shadow:0 -3px 7px #000;} -table thead.fixed {height:2em} +table thead.fixed tr{ position:fixed; top:6.3em; z-index:49; -moz-box-shadow:0 -3px 7px #000; -webkit-box-shadow:0 -3px 7px #000; box-shadow:0 -3px 7px #000; } +table thead.fixed { height:2em; } #fileList tr input[type=checkbox] { display:none; float:left; margin:.7em 0 0 1em; /* bigger clickable area doesn’t work in FF width:2.8em; height:2.4em;*/ } #fileList tr input[type=checkbox]:checked, #fileList tr:hover input[type=checkbox] { display:inline; } #fileList tr.selected td.filename , #fileList tr:hover td.filename { background-image:none !important } -#select_all { float:left; margin:0.2em; margin-left:0.6em; } +#select_all { float:left; margin:.2em; margin-left:.6em; } #uploadsize-message,#delete-confirm { display:none; } .selectedActions a, a.file_action { float:right; display:inline; margin:0 .5em; padding:.3em .3em 0 .3em !important; } .selectedActions { display:none; } From 3747ba928ff573a8c50943ac8748ec2c24cbba09 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Fri, 12 Aug 2011 09:46:35 +0200 Subject: [PATCH 02/19] Set max upload size to something sane we cant use a very high value since some apache configurations dont seem to handle it properly --- .htaccess | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.htaccess b/.htaccess index 23c90b26d8..92825ea92d 100644 --- a/.htaccess +++ b/.htaccess @@ -1,5 +1,5 @@ ErrorDocument 404 //owncloud/core/templates/404.php -php_value upload_max_filesize 2048G -php_value post_max_size 2048G +php_value upload_max_filesize 512M +php_value post_max_size 512M SetEnv htaccessWorking true Options -Indexes From 6c4d075bd656497e793c230818c53fa085cbbbf9 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Fri, 12 Aug 2011 11:26:13 +0200 Subject: [PATCH 03/19] added jquery-tipsy for nice title tooltips --- core/css/jquery-tipsy.css | 7 ++ core/img/jquery-tipsy.gif | Bin 0 -> 867 bytes core/js/jquery-showpassword.js | 113 ++++++++++++++++++++++++++++++ core/js/jquery-tipsy.js | 108 +++++++++++++++++++++++++++++ core/js/js.js | 121 ++------------------------------- files/css/files.css | 2 +- files/js/files.js | 4 ++ files/templates/index.php | 9 ++- lib/base.php | 5 +- 9 files changed, 246 insertions(+), 123 deletions(-) create mode 100644 core/css/jquery-tipsy.css create mode 100644 core/img/jquery-tipsy.gif create mode 100644 core/js/jquery-showpassword.js create mode 100644 core/js/jquery-tipsy.js diff --git a/core/css/jquery-tipsy.css b/core/css/jquery-tipsy.css new file mode 100644 index 0000000000..5075f41c9f --- /dev/null +++ b/core/css/jquery-tipsy.css @@ -0,0 +1,7 @@ +.tipsy { padding: 5px; font-size: 10px; opacity: 0.8; filter: alpha(opacity=80); background-repeat: no-repeat; background-image: url(../img/jquery-tipsy.gif); } + .tipsy-inner { padding: 5px 8px 4px 8px; background-color: black; color: white; max-width: 200px; text-align: center; } + .tipsy-inner { -moz-border-radius:3px; -webkit-border-radius:3px; } + .tipsy-north { background-position: top center; } + .tipsy-south { background-position: bottom center; } + .tipsy-east { background-position: right center; } + .tipsy-west { background-position: left center; } diff --git a/core/img/jquery-tipsy.gif b/core/img/jquery-tipsy.gif new file mode 100644 index 0000000000000000000000000000000000000000..eb7718dfc168c3c63382c36c55e0fc3ab53974c1 GIT binary patch literal 867 zcmV-p1DyOvNk%w1Vf6v^0e}Gj00030|NkNR1OWg50RSuj0002>0rdd@0{@JUsmtvT zqnxzbi}MA#`wxcVNS5Y_rs^63E(^!!{tpZahs2_Vhcqge%%<}R4Irn{ zs`ZM^YPa03_X`e-$K-YS={|^`_I7nD%c!-#&xX9S( z_y`#(IZ0V*d5M{+xyjk-`3V{-I!an`U)E>J4;(@dyAW^yUW|_`wJW_ zJWO0{e2ko|yv*F}{0to}JxyJ0eT|*1z0KY2{S6*2K2Bb4evY25zRuq6{th26KTlt8 ze~+K9zt7+A{|_*rz<~q{8a#+Fp~8g>8#;UlF`~qY6f0W1h%uwajsF}wdi)47q{xvZ zOPV~1GNsCuEL*yK2{We5nKWzKyoocX&Ye7a`uqtrsL-KAiyA$OG^x_1Oq)7=3N@kh3pcLZxpeE=y^A-m-o1SL`uz(y zu;9Uj3mZO+II-fzj2kC~%Rzm7e-_U+ue zd;bnTy!i3t%bP!sKE3+&?AyD44?n*A`Sk1CzmGq^{{8&>`~UwBV1SBoz#oALyilNl z2K11ifk`yT0TmEN$l!htN`at-87`<`ej6UpA$}nWNMea5o`_m9*b"); + + // Name added for JQuery Validation compatibility + // Element name is required to avoid script warning. + $clone.attr({ + 'type' : 'text', + 'class' : $element.attr('class'), + 'style' : $element.attr('style'), + 'size' : $element.attr('size'), + 'name' : $element.attr('name')+'-clone', + 'tabindex' : $element.attr('tabindex') + }); + + return $clone; + + }; + + // Transfers values between two elements + var update = function(a,b){ + b.val(a.val()); + }; + + // Shows a or b depending on checkbox + var setState = function( checkbox, a, b ){ + + if(checkbox.is(':checked')){ + update(a,b); + b.show(); + a.hide(); + } else { + update(b,a); + b.hide(); + a.show(); + } + + }; + + return this.each(function() { + + var $input = $(this), + $checkbox = $($input.data('typetoggle')); + + // Create clone + var $clone = cloneElement($input); + $clone.insertAfter($input); + + // Set callback arguments + if(callback.fn){ + callback.args.input = $input; + callback.args.checkbox = $checkbox; + callback.args.clone = $clone; + } + + + + $checkbox.bind('click', function() { + setState( $checkbox, $input, $clone ); + }); + + $input.bind('keyup', function() { + update( $input, $clone ) + }); + + $clone.bind('keyup', function(){ + update( $clone, $input ); + + // Added for JQuery Validation compatibility + // This will trigger validation if it's ON for keyup event + $input.trigger('keyup'); + + }); + + // Added for JQuery Validation compatibility + // This will trigger validation if it's ON for blur event + $clone.bind('blur', function() { $input.trigger('focusout'); }); + + setState( $checkbox, $input, $clone ); + + if( callback.fn ){ + callback.fn( callback.args ); + } + + }); + } + }); +})(jQuery); diff --git a/core/js/jquery-tipsy.js b/core/js/jquery-tipsy.js new file mode 100644 index 0000000000..58d834771f --- /dev/null +++ b/core/js/jquery-tipsy.js @@ -0,0 +1,108 @@ +// tipsy - Facebook-style tooltip plugin for jQuery +// (c) 2008-2009 Jason Frame (jason@onehackoranother.com) +// Released under The MIT License. + +(function($) { + $.fn.tipsy = function(options) { + + options = $.extend({}, $.fn.tipsy.defaults, options); + + return this.each(function() { + + var opts = $.fn.tipsy.elementOptions(this, options); + + $(this).hover(function() { + + $.data(this, 'cancel.tipsy', true); + + var tip = $.data(this, 'active.tipsy'); + if (!tip) { + tip = $('
'); + tip.css({position: 'absolute', zIndex: 100000}); + $.data(this, 'active.tipsy', tip); + } + + if ($(this).attr('title') || typeof($(this).attr('original-title')) != 'string') { + $(this).attr('original-title', $(this).attr('title') || '').removeAttr('title'); + } + + var title; + if (typeof opts.title == 'string') { + title = $(this).attr(opts.title == 'title' ? 'original-title' : opts.title); + } else if (typeof opts.title == 'function') { + title = opts.title.call(this); + } + + tip.find('.tipsy-inner')[opts.html ? 'html' : 'text'](title || opts.fallback); + + var pos = $.extend({}, $(this).offset(), {width: this.offsetWidth, height: this.offsetHeight}); + tip.get(0).className = 'tipsy'; // reset classname in case of dynamic gravity + tip.remove().css({top: 0, left: 0, visibility: 'hidden', display: 'block'}).appendTo(document.body); + var actualWidth = tip[0].offsetWidth, actualHeight = tip[0].offsetHeight; + var gravity = (typeof opts.gravity == 'function') ? opts.gravity.call(this) : opts.gravity; + + switch (gravity.charAt(0)) { + case 'n': + tip.css({top: pos.top + pos.height, left: pos.left + pos.width / 2 - actualWidth / 2}).addClass('tipsy-north'); + break; + case 's': + tip.css({top: pos.top - actualHeight, left: pos.left + pos.width / 2 - actualWidth / 2}).addClass('tipsy-south'); + break; + case 'e': + tip.css({top: pos.top + pos.height / 2 - actualHeight / 2, left: pos.left - actualWidth}).addClass('tipsy-east'); + break; + case 'w': + tip.css({top: pos.top + pos.height / 2 - actualHeight / 2, left: pos.left + pos.width}).addClass('tipsy-west'); + break; + } + + if (opts.fade) { + tip.css({opacity: 0, display: 'block', visibility: 'visible'}).animate({opacity: 0.8}); + } else { + tip.css({visibility: 'visible'}); + } + + }, function() { + $.data(this, 'cancel.tipsy', false); + var self = this; + setTimeout(function() { + if ($.data(this, 'cancel.tipsy')) return; + var tip = $.data(self, 'active.tipsy'); + if (opts.fade) { + tip.stop().fadeOut(function() { $(this).remove(); }); + } else { + tip.remove(); + } + }, 100); + + }); + + }); + + }; + + // Overwrite this method to provide options on a per-element basis. + // For example, you could store the gravity in a 'tipsy-gravity' attribute: + // return $.extend({}, options, {gravity: $(ele).attr('tipsy-gravity') || 'n' }); + // (remember - do not modify 'options' in place!) + $.fn.tipsy.elementOptions = function(ele, options) { + return $.metadata ? $.extend({}, options, $(ele).metadata()) : options; + }; + + $.fn.tipsy.defaults = { + fade: false, + fallback: '', + gravity: 'n', + html: false, + title: 'title' + }; + + $.fn.tipsy.autoNS = function() { + return $(this).offset().top > ($(document).scrollTop() + $(window).height() / 2) ? 's' : 'n'; + }; + + $.fn.tipsy.autoWE = function() { + return $(this).offset().left > ($(document).scrollLeft() + $(window).width() / 2) ? 'e' : 'w'; + }; + +})(jQuery); diff --git a/core/js/js.js b/core/js/js.js index 30cf01d0b2..b66f0a559d 100644 --- a/core/js/js.js +++ b/core/js/js.js @@ -288,7 +288,11 @@ $(document).ready(function(){ }); $('#settings #expand').hover(function(){ $('#settings #expand+span').fadeToggle(); - }) + }); + + $('a.file_action').tipsy({gravity:'s', live:true}); + $('.selectedActions a').tipsy({gravity:'n', live:true}); + $('.selectedActions a.delete').tipsy({gravity: 'ne', live:true}); }); if (!Array.prototype.map){ @@ -314,118 +318,3 @@ if (!Array.prototype.map){ return res; }; } - - -/* -* @name Show Password -* @descripton -* @version 1.3 -* @requires Jquery 1.5 -* -* @author Jan Jarfalk -* @author-email jan.jarfalk@unwrongest.com -* @author-website http://www.unwrongest.com -* -* @special-thanks Michel Gratton -* -* @licens MIT License - http://www.opensource.org/licenses/mit-license.php -*/ -(function($){ - $.fn.extend({ - showPassword: function(c) { - - // Setup callback object - var callback = {'fn':null,'args':{}} - callback.fn = c; - - // Clones passwords and turn the clones into text inputs - var cloneElement = function( element ) { - - var $element = $(element); - - $clone = $(""); - - // Name added for JQuery Validation compatibility - // Element name is required to avoid script warning. - $clone.attr({ - 'type' : 'text', - 'class' : $element.attr('class'), - 'style' : $element.attr('style'), - 'size' : $element.attr('size'), - 'name' : $element.attr('name')+'-clone', - 'tabindex' : $element.attr('tabindex') - }); - - return $clone; - - }; - - // Transfers values between two elements - var update = function(a,b){ - b.val(a.val()); - }; - - // Shows a or b depending on checkbox - var setState = function( checkbox, a, b ){ - - if(checkbox.is(':checked')){ - update(a,b); - b.show(); - a.hide(); - } else { - update(b,a); - b.hide(); - a.show(); - } - - }; - - return this.each(function() { - - var $input = $(this), - $checkbox = $($input.data('typetoggle')); - - // Create clone - var $clone = cloneElement($input); - $clone.insertAfter($input); - - // Set callback arguments - if(callback.fn){ - callback.args.input = $input; - callback.args.checkbox = $checkbox; - callback.args.clone = $clone; - } - - - - $checkbox.bind('click', function() { - setState( $checkbox, $input, $clone ); - }); - - $input.bind('keyup', function() { - update( $input, $clone ) - }); - - $clone.bind('keyup', function(){ - update( $clone, $input ); - - // Added for JQuery Validation compatibility - // This will trigger validation if it's ON for keyup event - $input.trigger('keyup'); - - }); - - // Added for JQuery Validation compatibility - // This will trigger validation if it's ON for blur event - $clone.bind('blur', function() { $input.trigger('focusout'); }); - - setState( $checkbox, $input, $clone ); - - if( callback.fn ){ - callback.fn( callback.args ); - } - - }); - } - }); -})(jQuery); diff --git a/files/css/files.css b/files/css/files.css index c856d3a6bd..2ff985cfc3 100644 --- a/files/css/files.css +++ b/files/css/files.css @@ -39,7 +39,7 @@ table th .name { float:left; margin-left:.5em; } table th.multiselect { background:#ddd; color:#000; font-weight:bold; } table th, table td { border-bottom:1px solid #ddd; text-align:left; font-weight:normal; } table td { border-bottom:1px solid #eee; font-style:normal; background-position:1em .5em; background-repeat:no-repeat; } -table th#headerSize, table td.filesize { width:5em; padding:0 1em; text-align:right; } +table th#headerSize, table td.filesize { width:3em; padding:0 1em; text-align:right; } table th#headerDate, table td.date { width:11em; padding:0 .1em 0 1em; text-align:left; } table td.selection, table th.selection, table td.fileaction { width:2em; text-align:center; } table td.filename a.name { display:block; height:1.5em; vertical-align:middle; margin-left:3em; } diff --git a/files/js/files.js b/files/js/files.js index 6af021c35b..8fd4b95ec7 100644 --- a/files/js/files.js +++ b/files/js/files.js @@ -17,6 +17,10 @@ $(document).ready(function() { $('#file_upload_start').trigger('click'); return false; }); + + $('#file_upload_button_wrapper').tipsy({gravity:'e'}); + $('td.filesize').tipsy({gravity:'se', live:true}); + $('td .modified').tipsy({gravity:'s', live:true}); // Sets the file-action buttons behaviour : $('tr').live('mouseenter',function(event) { diff --git a/files/templates/index.php b/files/templates/index.php index a2cf037c75..7ebb6e4694 100644 --- a/files/templates/index.php +++ b/files/templates/index.php @@ -6,10 +6,9 @@
- + - +
@@ -33,8 +32,8 @@ - t( 'Size MB' ); ?> - t( 'Modified' ); ?><?php echo $l->t('Delete')?> + t( 'Size' ); ?> + t( 'Modified' ); ?><?php echo $l->t('Delete')?> diff --git a/lib/base.php b/lib/base.php index 2e73551434..dc3ed4129c 100644 --- a/lib/base.php +++ b/lib/base.php @@ -148,12 +148,15 @@ OC_Group::setBackend( OC_Config::getValue( "groupbackend", "database" )); // Add the stuff we need always OC_Util::addScript( "jquery-1.6.2.min" ); OC_Util::addScript( "jquery-ui-1.8.14.custom.min" ); +OC_Util::addScript( "jquery-showpassword" ); +OC_Util::addScript( "jquery-tipsy" ); OC_Util::addScript( "js" ); OC_Util::addScript( "multiselect" ); OC_Util::addScript('search','result'); -OC_Util::addStyle( "jquery-ui-1.8.14.custom" ); OC_Util::addStyle( "styles" ); OC_Util::addStyle( "multiselect" ); +OC_Util::addStyle( "jquery-ui-1.8.14.custom" ); +OC_Util::addStyle( "jquery-tipsy" ); // Load Apps // This includes plugins for users and filesystems as well From 9ba303a95f22e881a2f2cc8657645560ca646d05 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Fri, 12 Aug 2011 11:42:41 +0200 Subject: [PATCH 04/19] fix uploading multiple files --- files/css/files.css | 2 +- files/js/files.js | 4 ++-- files/templates/index.php | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/files/css/files.css b/files/css/files.css index 2ff985cfc3..7901c3c6a0 100644 --- a/files/css/files.css +++ b/files/css/files.css @@ -11,7 +11,7 @@ #fileSelector, #file_upload_submit, #file_newfolder_submit { display:none; } .file_upload_wrapper, #file_newfolder_name { background-repeat:no-repeat; background-position:.5em .3em; padding-left:2em; } .file_upload_wrapper { font-weight:bold; display:-moz-inline-box; /* fallback for older firefox versions*/ display:inline-block; padding-left:0; overflow:hidden; position:relative; margin-right:1.5em;} -.file_upload_wrapper #file_upload_button_wrapper { position:absolute; top:0; left:0; width:100%; height:100%; cursor:pointer; z-index:1000; } +.file_upload_wrapper .file_upload_button_wrapper { position:absolute; top:0; left:0; width:100%; height:100%; cursor:pointer; z-index:1000; } #file_newfolder_name { background-image:url('../../core/img/places/folder.svg'); font-weight:bold; width:8em; } .file_upload_start, .file_upload_filename { font-size:1em; } diff --git a/files/js/files.js b/files/js/files.js index 8fd4b95ec7..e8d2b5d9f5 100644 --- a/files/js/files.js +++ b/files/js/files.js @@ -13,8 +13,8 @@ $(document).ready(function() { $('#plugins>ul>li:first-child').droppable(crumbDropOptions); // Triggers invisible file input - $('#file_upload_button_wrapper').bind('click', function() { - $('#file_upload_start').trigger('click'); + $('.file_upload_button_wrapper').live('click', function() { + $(this).parent().children('.file_upload_start').trigger('click'); return false; }); diff --git a/files/templates/index.php b/files/templates/index.php index 7ebb6e4694..cd061596a0 100644 --- a/files/templates/index.php +++ b/files/templates/index.php @@ -7,8 +7,8 @@
- - + +
From f62b31515937f2687f7543c5c6286252c5812e6d Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Fri, 12 Aug 2011 11:51:44 +0200 Subject: [PATCH 05/19] file hovering now very fancy, CSS fade for row and extension --- core/js/js.js | 2 +- files/css/files.css | 10 ++++++++++ files/js/filelist.js | 4 ++-- files/js/files.js | 2 +- 4 files changed, 14 insertions(+), 4 deletions(-) diff --git a/core/js/js.js b/core/js/js.js index b66f0a559d..8ac999a104 100644 --- a/core/js/js.js +++ b/core/js/js.js @@ -290,7 +290,7 @@ $(document).ready(function(){ $('#settings #expand+span').fadeToggle(); }); - $('a.file_action').tipsy({gravity:'s', live:true}); + $('.file_action').tipsy({gravity:'s', live:true}); $('.selectedActions a').tipsy({gravity:'n', live:true}); $('.selectedActions a.delete').tipsy({gravity: 'ne', live:true}); }); diff --git a/files/css/files.css b/files/css/files.css index 7901c3c6a0..262feb3c7f 100644 --- a/files/css/files.css +++ b/files/css/files.css @@ -26,10 +26,20 @@ /* FILE TABLE */ span#emptyfolder { position:absolute; margin:10em 0 0 10em; font-size:1.5em; font-weight:bold; color:#888; text-shadow:#fff 0 1px 0; } table { position:relative; top:37px; width:100%; } +table tr { -webkit-transition:background-color 100ms ease-in 100ms; +-moz-transition:background-color 100ms ease-in 100ms; +-o-transition:background-color 100ms ease-in 100ms; +transition:background-color 100ms ease-in 100ms; } tbody tr:hover, tbody tr:active, tbody tr.selected { background-color:#f8f8f8; height:1em; } tbody tr.selected { background-color:#eee; } tbody a { color:#000; } span.extention, td.date { color:#999; } +span.extention { opacity:0; +-webkit-transition:opacity 100ms ease-in 100ms; +-moz-transition:opacity 100ms ease-in 100ms; +-o-transition:opacity 100ms ease-in 100ms; +transition:opacity 100ms ease-in 100ms; } +tr:hover span.extention { opacity:1; } div.crumb { float:left; display:block; background:no-repeat right 0; padding:.75em 1.5em 0 1em; height:2.9em; } div.crumb:first-child { padding-left:1.5em; } div.crumb:last-child { font-weight:bold; } diff --git a/files/js/filelist.js b/files/js/filelist.js index 50a995bf25..b89bc9b57b 100644 --- a/files/js/filelist.js +++ b/files/js/filelist.js @@ -3,7 +3,7 @@ FileList={ $('#fileList').empty().html(fileListHtml); }, addFile:function(name,size,lastModified,loading){ - var img=(loading)?OC.imagePath('core', 'loading.gif'):OC.imagePath('core', 'filetypes/file.png'); + var img=(loading)?OC.imagePath('core', 'loading.gif'):OC.imagePath('core', 'filetypes/file'); var html=''; if(name.indexOf('.')!=-1){ var basename=name.substr(0,name.indexOf('.')); @@ -38,7 +38,7 @@ FileList={ }, addDir:function(name,size,lastModified){ var html=''; - html+=''+name+''; + html+=''+name+''; if(size!='Pending'){ simpleSize=simpleFileSize(size); }else{ diff --git a/files/js/files.js b/files/js/files.js index e8d2b5d9f5..8b41781cbf 100644 --- a/files/js/files.js +++ b/files/js/files.js @@ -423,5 +423,5 @@ function getMimeIcon(mime){ if(knownMimes.indexOf(mime)==-1){ mime='file'; } - return OC.imagePath('core','mimetypes/'+mime+'.png'); + return OC.imagePath('core','filetypes/'+mime); } From 02824cabfed9ff13501858e1bb674f027526858f Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Fri, 12 Aug 2011 11:55:11 +0200 Subject: [PATCH 06/19] removed downloading as fallback action when file type can not be opened --- files/js/fileactions.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/files/js/fileactions.js b/files/js/fileactions.js index 744ffd8cfe..1ba265142b 100644 --- a/files/js/fileactions.js +++ b/files/js/fileactions.js @@ -128,7 +128,7 @@ FileActions.register('all','Rename',OC.imagePath('core','actions/rename'),functi FileList.rename(filename); }); -FileActions.setDefault('all','Download'); +//FileActions.setDefault('all','Download'); FileActions.register('dir','Open','',function(filename){ window.location='index.php?dir='+$('#dir').val()+'/'+filename; From 0b4ed2577676ee090812b9be76e00483217a062b Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Fri, 12 Aug 2011 12:03:59 +0200 Subject: [PATCH 07/19] fixed downloading of files with spaces in name for Firefox --- lib/files.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/files.php b/lib/files.php index eec1007de1..bdcae41918 100644 --- a/lib/files.php +++ b/lib/files.php @@ -121,7 +121,7 @@ class OC_Files { $filename=$dir.'/'.$files; } if($zip or OC_Filesystem::is_readable($filename)){ - header('Content-Disposition: attachment; filename='.basename($filename)); + header('Content-Disposition: attachment; filename="'.basename($filename).'"'); header('Content-Transfer-Encoding: binary'); header('Expires: 0'); header('Cache-Control: must-revalidate, post-check=0, pre-check=0'); From 5a26640f638a1b259e6b9e1b580b1810e1efd015 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Fri, 12 Aug 2011 12:34:02 +0200 Subject: [PATCH 08/19] partly fix media player --- apps/media/js/collection.js | 12 +++++----- apps/media/js/player.js | 48 ++++++++++++++++++++++++------------- 2 files changed, 37 insertions(+), 23 deletions(-) diff --git a/apps/media/js/collection.js b/apps/media/js/collection.js index e49024973f..95398f8397 100644 --- a/apps/media/js/collection.js +++ b/apps/media/js/collection.js @@ -60,14 +60,14 @@ Collection={ tr.find('td.title a').text(song.song_name); tr.find('td.title a').click(function(event){ event.preventDefault(); - PlayList.add(song); - PlayList.render(); + PlayList.add(song,true); + PlayList.play(0); }); if(artist.artist_name!=lastArtist){ tr.find('td.artist a').click(function(event){ event.preventDefault(); - PlayList.add(artist); - PlayList.render(); + PlayList.add(artist,true); + PlayList.play(0); }); tr.find('td.artist a').text(artist.artist_name); if(artist.albums.length>1){ @@ -87,8 +87,8 @@ Collection={ if(album.album_name!=lastAlbum){ tr.find('td.album a').click(function(event){ event.preventDefault(); - PlayList.add(album); - PlayList.render(); + PlayList.add(album,true); + PlayList.play(0); }); tr.find('td.album a').text(album.album_name); if(album.songs.length>1){ diff --git a/apps/media/js/player.js b/apps/media/js/player.js index 8298db56e6..d37196a89f 100644 --- a/apps/media/js/player.js +++ b/apps/media/js/player.js @@ -5,48 +5,53 @@ var PlayList={ player:null, volume:0.8, active:false, + tempPlaylist:[], + isTemp:true, next:function(){ + var items=(PlayList.isTemp)?PlayList.tempPlaylist:PlayList.items; var next=PlayList.current+1; - if(next>=PlayList.items.length){ + if(next>=items.length){ next=0; } PlayList.play(next); PlayList.render(); }, previous:function(){ + var items=(PlayList.isTemp)?PlayList.tempPlaylist:PlayList.items; var next=PlayList.current-1; if(next<0){ - next=PlayList.items.length-1; + next=items.length-1; } PlayList.play(next); PlayList.render(); }, play:function(index,time,ready){ + var items=(PlayList.isTemp)?PlayList.tempPlaylist:PlayList.items; if(index==null){ index=PlayList.current; } - if(index>-1 && index-1 && index0){ var previous=index-1; }else{ - var previous=PlayList.items.length-1; + var previous=items.length-1; } - if(index+1 Date: Fri, 12 Aug 2011 14:09:43 +0200 Subject: [PATCH 09/19] fix changing passwords --- settings/ajax/changepassword.php | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/settings/ajax/changepassword.php b/settings/ajax/changepassword.php index 750edf1769..b9b2417ad9 100644 --- a/settings/ajax/changepassword.php +++ b/settings/ajax/changepassword.php @@ -6,33 +6,32 @@ require_once('../../lib/base.php'); $l=new OC_L10N('settings'); // We send json data -header( "Content-Type: application/jsonrequest" ); +header("Content-Type: application/jsonrequest"); // Check if we are a user -if( !OC_User::isLoggedIn()){ - echo json_encode( array( "status" => "error", "data" => array( "message" => $l->t( "Authentication error" ) ))); +if(!OC_User::isLoggedIn()){ + echo json_encode(array("status" => "error", "data" => array("message" => $l->t("Authentication error")))); exit(); } // Get data -if( !isset( $_POST["password"] ) && !isset( $_POST["oldpassword"] )){ - echo json_encode( array( "status" => "error", "data" => array( "message" => $l->t( "You have to enter the old and the new password!" ) ))); +if(!isset($_POST["password"]) && !isset($_POST["oldpassword"])){ + echo json_encode(array("status" => "error", "data" => array("message" => $l->t("You have to enter the old and the new password!")))); exit(); } // Check if the old password is correct -if( !OC_User::checkPassword( $_SESSION["user_id"], $_POST["oldpassword"] )){ - echo json_encode( array( "status" => "error", "data" => array( "message" => $l->t("Your old password is wrong!") ))); +if(!OC_User::checkPassword($_SESSION["user_id"], $_POST["oldpassword"])){ + echo json_encode(array("status" => "error", "data" => array("message" => $l->t("Your old password is wrong!")))); exit(); } // Change password -if( OC_User::setPassword( $_SESSION["user_id"], $_POST["password"] )){ - echo json_encode( array( "status" => "success", "data" => array( "message" => $l->t("Password changed") ))); - OC_Crypt::changekeypasscode( $_POST["password"]) { -} -else{ - echo json_encode( array( "status" => "error", "data" => array( "message" => $l->t("Unable to change password") ))); +if(OC_User::setPassword($_SESSION["user_id"], $_POST["password"])){ + echo json_encode(array("status" => "success", "data" => array("message" => $l->t("Password changed")))); + OC_Crypt::changekeypasscode($_POST["password"]); +}else{ + echo json_encode(array("status" => "error", "data" => array("message" => $l->t("Unable to change password")))); } ?> From 23c3c561ac8f6bcf6ae8ae63acd8a02013377875 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Fri, 12 Aug 2011 14:41:50 +0200 Subject: [PATCH 10/19] sacrificed alignment for scrolling --- admin/templates/users.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/admin/templates/users.php b/admin/templates/users.php index 8d6b1efe6e..77a4f0c0d5 100644 --- a/admin/templates/users.php +++ b/admin/templates/users.php @@ -6,8 +6,8 @@ foreach($_["groups"] as $group) { ?> - - + +
'; + html+=''; + $.each(collumns,function(index,collumn){ + html+=''; + }); + html+=''; + html+=''; + html+=''; + html+'' + $.each(collumns,function(index,collumn){ + html+='' + html+=''; + html='
'+collumn+'
'; + }); + html+'
'; + return $(html); +} + +ListView.prototype={ + rows:{}, + hoverElements:{}, + addRow:function(id,data,extraData){ + var tr=this.element.find('tr.template').clone(); + tr.removeClass('template'); + $.each(data,function(name,value){ + tr.children('td.'+name).text(value); + tr.attr('data-'+name,value); + }); + $.each(extraData,function(name,value){ + tr.attr('data-'+name,value); + }); + this.rows[id]=data; + tr.data('id',id); + this.element.children('tbody').append(tr); + }, + removeRow:function(id){ + this.rows[id].remove(); + delete this.rows[id]; + }, + hoverHandeler:function(tr){ + $.each(this.hoverElement,function(index,collumn){ + $.each(collumn,function(index,element){ + var html=''; + var element=$(html); + element.append($('')); + element.click(element.callback); + tr.children('td.'+collumn).append(element) + }); + }); + if(this.deleteCallback){ + + } + }, + hoverHandelerOut:function(tr){ + tr.find('*.hoverElement').remove(); + }, + addHoverElement:function(collumn,icon,title,callback){ + if(!this.hoverElements[collumn]){ + this.hoverElements[collumn]=[]; + } + this.hoverElements[row].push({icon:icon,callback:callback,title:title}); + }, + empty:function(){ + this.element.children('tr:not(.template)').remove(); + } +} \ No newline at end of file From 382834ec2b395ceba21d1eb5a753a73df9141104 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Fri, 12 Aug 2011 22:28:35 +0200 Subject: [PATCH 15/19] highlight playing songs in collection --- apps/media/css/music.css | 3 ++- apps/media/js/collection.js | 15 +++++++++++---- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/apps/media/css/music.css b/apps/media/css/music.css index c78ab20071..f9c3b955d6 100644 --- a/apps/media/css/music.css +++ b/apps/media/css/music.css @@ -12,4 +12,5 @@ li button.right.prettybutton{font-size:1em;} #collection li{padding-right:10px;} #searchresults input.play, #searchresults input.add{float:right; height:16px; width:16px;} #collection tr.collapsed td.album, #collection tr.collapsed td.title{color:#ddd} -a.expander{float:right;display:block} +a.expander{ float:right; display:block; } +tr.active { background-color:#ccc; } diff --git a/apps/media/js/collection.js b/apps/media/js/collection.js index 95398f8397..8ef10951b6 100644 --- a/apps/media/js/collection.js +++ b/apps/media/js/collection.js @@ -62,12 +62,16 @@ Collection={ event.preventDefault(); PlayList.add(song,true); PlayList.play(0); + Collection.parent.find('tr').removeClass('active'); + tr.addClass('active'); }); if(artist.artist_name!=lastArtist){ tr.find('td.artist a').click(function(event){ event.preventDefault(); PlayList.add(artist,true); PlayList.play(0); + Collection.parent.find('tr').removeClass('active'); + $('tr[data-artist="'+artist.artist_name+'"]').addClass('active'); }); tr.find('td.artist a').text(artist.artist_name); if(artist.albums.length>1){ @@ -89,6 +93,8 @@ Collection={ event.preventDefault(); PlayList.add(album,true); PlayList.play(0); + Collection.parent.find('tr').removeClass('active'); + $('tr[data-album="'+album.album_name+'"]').addClass('active'); }); tr.find('td.album a').text(album.album_name); if(album.songs.length>1){ @@ -149,10 +155,11 @@ Collection={ Collection.parent.hide(); } }, - registerPlay:function(){ - var item=PlayList.items[PlayList.current]; - var song=Collection.findSong(item.artist,item.album,item.name); - song.song_playcount++; + registerPlay:function(item){ + if(item){ + var song=Collection.findSong(item.artist,item.album,item.name); + song.song_playcount++; + } }, addButtons:function(parent){ parent.children('button.add').click(function(){ From b0b5a465434d89d3cac40a1c8e43f8ecbde27082 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Fri, 12 Aug 2011 22:41:41 +0200 Subject: [PATCH 16/19] style media player controls using em instead of px --- apps/media/css/player.css | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/apps/media/css/player.css b/apps/media/css/player.css index 6cf424a8ea..42ef219994 100644 --- a/apps/media/css/player.css +++ b/apps/media/css/player.css @@ -1,25 +1,25 @@ #controls ul.jp-controls{list-style-type:none;padding:0;} #controls ul.jp-controls li{display:inline;} #controls ul.jp-controls a{position:absolute;overflow:hidden;text-indent:-9999px;} -a.jp-play,a.jp-pause{width:40px;height:40px;z-index:1;top:0;left:48px;} +a.jp-play,a.jp-pause{width:3.1em;height:3.1em;z-index:1;top:0;left:3.8em;} a.jp-play{background:url("../img/jplayer.blue.monday.png") 0 0 no-repeat;} a.jp-play:hover{background:url("../img/jplayer.blue.monday.png") -41px 0 no-repeat;} a.jp-pause{background:url("../img/jplayer.blue.monday.png") 0 -42px no-repeat;display:none;} a.jp-pause:hover{background:url("../img/jplayer.blue.monday.png") -41px -42px no-repeat;} -a.jp-previous{left:20px;top:.5em;background:url("../img/jplayer.blue.monday.png") 0 -112px no-repeat;width:28px;height:28px;} +a.jp-previous{left:20px;top:.5em;background:url("../img/jplayer.blue.monday.png") 0 -112px no-repeat;width:2.3em;height:2.3em;} a.jp-previous:hover{background:url("../img/jplayer.blue.monday.png") -29px -112px no-repeat;} -a.jp-next{left:88px;top:.5em;background:url("../img/jplayer.blue.monday.png") 0 -141px no-repeat;width:28px;height:28px;} +a.jp-next{left:88px;top:.5em;background:url("../img/jplayer.blue.monday.png") 0 -141px no-repeat;width:2.3em;height:2.3em;} a.jp-next:hover{background:url("../img/jplayer.blue.monday.png") -29px -141px no-repeat;} -div.jp-progress{position:absolute;overflow:hidden;background-color:#293b51;top:1em;left:164px;width:122px;height:15px;} +div.jp-progress{position:absolute;overflow:hidden;background-color:#293b51;top:1em;left:10em;width:15em;height:1.2em;} div.jp-seek-bar{background:url("../img/jplayer.blue.monday.png") 0 -202px repeat-x;width:0;height:100%;cursor:pointer;} div.jp-play-bar{background:url("../img/jplayer.blue.monday.png") 0 -218px repeat-x;width:0;height:100%;} div.jp-seeking-bg{background:url("../img/pbar-ani.gif");} -a.jp-mute,a.jp-unmute{height:15px;width:18px;top:1em;left:296px;} +a.jp-mute,a.jp-unmute{height:1.2em;width:1.5em;top:1em;left:26em;} a.jp-mute{background:url("../img/jplayer.blue.monday.png") 0 -186px no-repeat;} a.jp-mute:hover{background:url("../img/jplayer.blue.monday.png") -19px -170px no-repeat;} a.jp-unmute{background:url("../img/jplayer.blue.monday.png") 0 -170px no-repeat;display:none;} a.jp-unmute:hover{background:url("../img/jplayer.blue.monday.png") -19px -186px no-repeat;} -div.jp-volume-bar{position:absolute;overflow:hidden;background:url("../img/jplayer.blue.monday.png") 0 -250px repeat-x;width:46px;height:5px;cursor:pointer;top:1.3em;left:324px;} -div.jp-volume-bar-value{background:url("../img/jplayer.blue.monday.png") 0 -256px repeat-x;width:0;height:5px;} -div.jp-current-time,div.jp-duration{position:absolute;font-size:.64em;font-style:oblique;top:1em;left:164px;width:122px;} +div.jp-volume-bar{position:absolute;overflow:hidden;background:url("../img/jplayer.blue.monday.png") 0 -250px repeat-x;width:4em;height:0.4em;cursor:pointer;top:1.3em;left:28em;} +div.jp-volume-bar-value{background:url("../img/jplayer.blue.monday.png") 0 -256px repeat-x;width:0;height:0.4em;} +div.jp-current-time,div.jp-duration{position:absolute;font-size:.64em;font-style:oblique;top:1em;left:16.8em;width:22em;} div.jp-duration{text-align:right;} From 21690a3702067ab9f4a4fef914bf7415b8647704 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Sat, 13 Aug 2011 01:18:02 +0200 Subject: [PATCH 17/19] tweaked CSS fade transitions --- files/css/files.css | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/files/css/files.css b/files/css/files.css index b54ea36e6a..ef86664cf2 100644 --- a/files/css/files.css +++ b/files/css/files.css @@ -26,19 +26,12 @@ /* FILE TABLE */ span#emptyfolder { position:absolute; margin:10em 0 0 10em; font-size:1.5em; font-weight:bold; color:#888; text-shadow:#fff 0 1px 0; } table { position:relative; top:37px; width:100%; } -table tr { -webkit-transition:background-color ease-in 200ms; --moz-transition:background-color ease-in 200ms; --o-transition:background-color ease-in 200ms; -transition:background-color ease-in 200ms; } +table tr { -webkit-transition:background-color 500ms; -moz-transition:background-color 500ms; -o-transition:background-color 500ms; transition:background-color 500ms; } tbody tr:hover, tbody tr:active, tbody tr.selected { background-color:#f8f8f8; height:1em; } tbody tr.selected { background-color:#eee; } tbody a { color:#000; } span.extention, td.date { color:#999; } -span.extention { opacity:0; --webkit-transition:opacity ease-in 200ms; --moz-transition:opacity ease-in 200ms; --o-transition:opacity ease-in 200ms; -transition:opacity ease-in 200ms; } +span.extention { opacity:0; -webkit-transition:opacity 500ms; -moz-transition:opacity 500ms; -o-transition:opacity 500ms; transition:opacity 500ms; } tr:hover span.extention { opacity:1; } div.crumb { float:left; display:block; background:no-repeat right 0; padding:.75em 1.5em 0 1em; height:2.9em; } div.crumb:first-child { padding-left:1.5em; } @@ -61,9 +54,10 @@ table td.filename .nametext { width:60%; } table td.filename form { float:left; font-size:.85em; } table thead.fixed tr{ position:fixed; top:6.3em; z-index:49; -moz-box-shadow:0 -3px 7px #000; -webkit-box-shadow:0 -3px 7px #000; box-shadow:0 -3px 7px #000; } table thead.fixed { height:2em; } -#fileList tr input[type=checkbox] { display:none; float:left; margin:.7em 0 0 1em; /* bigger clickable area doesn’t work in FF width:2.8em; height:2.4em;*/ } -#fileList tr input[type=checkbox]:checked, #fileList tr:hover input[type=checkbox] { display:inline; } -#fileList tr.selected td.filename , #fileList tr:hover td.filename { background-image:none !important } +#fileList tr input[type=checkbox] { opacity:0; float:left; margin:.7em 0 0 1em; /* bigger clickable area doesn’t work in FF width:2.8em; height:2.4em;*/ -webkit-transition:opacity 500ms; -moz-transition:opacity 500ms; -o-transition:opacity 500ms; transition:opacity 500ms; } +#fileList tr input[type="checkbox"]:checked, #fileList tr:hover input[type="checkbox"] { opacity:1; } +#fileList tr td.filename { -webkit-transition:background-image 500ms; -moz-transition:background-image 500ms; -o-transition:background-image 500ms; transition:background-image 500ms; } +#fileList tr.selected td.filename, #fileList tr:hover td.filename { background-image:url('') !important; } #select_all { float:left; margin:.2em; margin-left:.6em; } #uploadsize-message,#delete-confirm { display:none; } .selectedActions a, a.file_action { float:right; display:inline; margin:0 .5em; padding:.3em .3em 0 .3em !important; } From 98a5e063ac6ac0916050fc22b71dbb81057f5b2f Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Sat, 13 Aug 2011 02:21:48 +0200 Subject: [PATCH 18/19] more icons for the music player --- core/img/actions/pause-big.png | Bin 0 -> 183 bytes core/img/actions/pause-big.svg | 73 ++++++++++++++++++++++++++++++ core/img/actions/pause.png | Bin 0 -> 182 bytes core/img/actions/pause.svg | 72 ++++++++++++++++++++++++++++++ core/img/actions/sound-off.png | Bin 0 -> 217 bytes core/img/actions/sound-off.svg | 73 ++++++++++++++++++++++++++++++ core/img/actions/sound.png | Bin 0 -> 292 bytes core/img/actions/sound.svg | 78 +++++++++++++++++++++++++++++++++ 8 files changed, 296 insertions(+) create mode 100644 core/img/actions/pause-big.png create mode 100644 core/img/actions/pause-big.svg create mode 100644 core/img/actions/pause.png create mode 100644 core/img/actions/pause.svg create mode 100644 core/img/actions/sound-off.png create mode 100644 core/img/actions/sound-off.svg create mode 100644 core/img/actions/sound.png create mode 100644 core/img/actions/sound.svg diff --git a/core/img/actions/pause-big.png b/core/img/actions/pause-big.png new file mode 100644 index 0000000000000000000000000000000000000000..9bcfd0406d8165e2adc4d3cc0909d038e94faa93 GIT binary patch literal 183 zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`EX7WqAsj$Z!;#Vf2?p zUk71ECym(^Ktah8*NBqf{Irtt#G+J&^73-M%)IR4 + + + + + + + + + + + image/svg+xml + + + + + + + + + diff --git a/core/img/actions/pause.png b/core/img/actions/pause.png new file mode 100644 index 0000000000000000000000000000000000000000..ced8c43ab3441af94470f9a97440759f175b9764 GIT binary patch literal 182 zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`EX7WqAsj$Z!;#Vf2?p zUk71ECym(^Ktah8*NBqf{Irtt#G+J&^73-M%)IR4&(L^PINq)|NsAg<43~FySUwWB}^L{fuQh3x*Ed+W + + + + + + + + + + + image/svg+xml + + + + + + + + + diff --git a/core/img/actions/sound-off.png b/core/img/actions/sound-off.png new file mode 100644 index 0000000000000000000000000000000000000000..7900e500c90f1650c2299aad837114e88c9ee71d GIT binary patch literal 217 zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`EX7WqAsj$Z!;#Vf2?p zUk71ECym(^Ktah8*NBqf{Irtt#G+J&^73-M%)IR4 + + + + + + + + + + + image/svg+xml + + + + + + + + + diff --git a/core/img/actions/sound.png b/core/img/actions/sound.png new file mode 100644 index 0000000000000000000000000000000000000000..838c9cee1719b158efdc40d2688f33ac0f28da19 GIT binary patch literal 292 zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`EX7WqAsj$Z!;#Vf2?p zUk71ECym(^Ktah8*NBqf{Irtt#G+J&^73-M%)IR4C$At~R|tJba9f&N=z> z`Mv5QW#hfUz1#1^v%0tl3U2-FdPGC1%j?9MsKpL(*QZ`P!V^2^!s#FVdQ&MBb@09++)Y5)KL literal 0 HcmV?d00001 diff --git a/core/img/actions/sound.svg b/core/img/actions/sound.svg new file mode 100644 index 0000000000..6feea076a4 --- /dev/null +++ b/core/img/actions/sound.svg @@ -0,0 +1,78 @@ + + + + + + + + + + + + image/svg+xml + + + + + + + + + + From 67156f87e3757fbd5e692e7d6b2209cfafc6c3cf Mon Sep 17 00:00:00 2001 From: Michael Gapczynski Date: Fri, 12 Aug 2011 20:51:01 -0400 Subject: [PATCH 19/19] Add missing parameter to usersInGroup() --- lib/group.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/group.php b/lib/group.php index 65a23989a2..fbff41e30e 100644 --- a/lib/group.php +++ b/lib/group.php @@ -249,6 +249,6 @@ class OC_Group { * @returns array with user ids */ public static function usersInGroup($gid){ - return self::$_backend->usersInGroup(); + return self::$_backend->usersInGroup($gid); } }