From 135ceb4a9de2238c1678577b5f3d34c6a9f66a8b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Tue, 18 Aug 2020 11:57:01 +0200 Subject: [PATCH] Fix late night errors MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- apps/dashboard/lib/Service/BackgroundService.php | 2 +- apps/dashboard/src/components/BackgroundSettings.vue | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/apps/dashboard/lib/Service/BackgroundService.php b/apps/dashboard/lib/Service/BackgroundService.php index 2b59bef65d..30e9d9fe3c 100644 --- a/apps/dashboard/lib/Service/BackgroundService.php +++ b/apps/dashboard/lib/Service/BackgroundService.php @@ -107,7 +107,7 @@ class BackgroundService { } public function setShippedBackground($fileName) { - if (!in_array($fileName, self::SHIPPED_BACKGROUNDS)) { + if (!array_key_exists($fileName, self::SHIPPED_BACKGROUNDS)) { throw new \InvalidArgumentException('The given file name is invalid'); } $this->config->setUserValue($this->userId, 'dashboard', 'background', $fileName); diff --git a/apps/dashboard/src/components/BackgroundSettings.vue b/apps/dashboard/src/components/BackgroundSettings.vue index accc094f52..65f70614d7 100644 --- a/apps/dashboard/src/components/BackgroundSettings.vue +++ b/apps/dashboard/src/components/BackgroundSettings.vue @@ -95,6 +95,11 @@ export default { async update(data) { const background = data.type === 'custom' || data.type === 'default' ? data.type : data.value this.backgroundImage = getBackgroundUrl(background, data.version) + if (data.type === 'color') { + this.$emit('updateBackground', data) + this.loading = false + return + } const image = new Image() image.onload = () => { this.$emit('updateBackground', data)