mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #25087 from nextcloud/techdebt/noid/update-psalm-baseline-as-recommended.xml 

Update psalm baseline to remove obsolete stuff
This commit is contained in:
Morris Jobke 2021-01-12 10:14:11 +01:00 committed by GitHub
parent c8cbb73c05 eeac11a687
commit 15924b8832
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/settings/lib/SetupChecks/SupportedDatabase.php
View File

@ -29,7 +29,7 @@ namespace OCA\Settings\SetupChecks;
use Doctrine\DBAL\Platforms\MariaDb1027Platform; use Doctrine\DBAL\Platforms\MariaDb1027Platform;
use Doctrine\DBAL\Platforms\MySQL57Platform; use Doctrine\DBAL\Platforms\MySQL57Platform;
use Doctrine\DBAL\Platforms\MySQL80Platform; use Doctrine\DBAL\Platforms\MySQL80Platform;
use Doctrine\DBAL\Platforms\MySqlPlatform; use Doctrine\DBAL\Platforms\MySQLPlatform;
use Doctrine\DBAL\Platforms\OraclePlatform; use Doctrine\DBAL\Platforms\OraclePlatform;
use Doctrine\DBAL\Platforms\PostgreSQL100Platform; use Doctrine\DBAL\Platforms\PostgreSQL100Platform;
use Doctrine\DBAL\Platforms\PostgreSQL94Platform; use Doctrine\DBAL\Platforms\PostgreSQL94Platform;
@ -61,7 +61,7 @@ class SupportedDatabase {
case MySQL80Platform::class: # extends MySQL57Platform case MySQL80Platform::class: # extends MySQL57Platform
case MySQL57Platform::class: # extends MySQLPlatform case MySQL57Platform::class: # extends MySQLPlatform
case MariaDb1027Platform::class: # extends MySQLPlatform case MariaDb1027Platform::class: # extends MySQLPlatform
case MySqlPlatform::class: case MySQLPlatform::class:
$result = $this->connection->prepare('SHOW VARIABLES LIKE "version";'); $result = $this->connection->prepare('SHOW VARIABLES LIKE "version";');
$result->execute(); $result->execute();
$row = $result->fetch(); $row = $result->fetch();

8
build/psalm-baseline.xml
View File

@ -3038,9 +3038,6 @@
<InvalidArrayOffset occurrences="1"> <InvalidArrayOffset occurrences="1">
<code>$action['url-postfix']</code> <code>$action['url-postfix']</code>
</InvalidArrayOffset> </InvalidArrayOffset>
<RedundantCondition occurrences="1">
<code>strtolower</code>
</RedundantCondition>
</file> </file>
<file src="lib/private/AppFramework/Services/AppConfig.php"> <file src="lib/private/AppFramework/Services/AppConfig.php">
<MoreSpecificImplementedParamType occurrences="1"> <MoreSpecificImplementedParamType occurrences="1">
@ -5035,11 +5032,6 @@
<code>$this-&gt;appendIfExist($this-&gt;serverroot, 'core/'.$script.'.js')</code> <code>$this-&gt;appendIfExist($this-&gt;serverroot, 'core/'.$script.'.js')</code>
</InvalidOperand> </InvalidOperand>
</file> </file>
<file src="lib/private/Template/SCSSCacher.php">
<InvalidScalarArgument occurrences="1">
<code>Compiler::LINE_COMMENTS</code>
</InvalidScalarArgument>
</file>
<file src="lib/private/TemplateLayout.php"> <file src="lib/private/TemplateLayout.php">
<InvalidParamDefault occurrences="2"> <InvalidParamDefault occurrences="2">
<code>string</code> <code>string</code>