mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Speed up the tests by reseting the configs and app only when needed

This commit is contained in:
Joas Schilling 2015-12-11 15:23:22 +01:00 committed by Thomas Müller
parent 17fcd84ee3
commit 1959171d5d
2 changed files with 47 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
build/integration/capabilities_features/capabilities.feature
View File

@ -215,8 +215,3 @@ Feature: capabilities
| files | bigfilechunking | 1 | | files | bigfilechunking | 1 |
| files | undelete | 1 | | files | undelete | 1 |
| files | versioning | 1 | | files | versioning | 1 |

69
build/integration/features/bootstrap/CapabilitiesContext.php
View File

@ -2,6 +2,10 @@
use Behat\Behat\Context\Context; use Behat\Behat\Context\Context;
use Behat\Behat\Context\SnippetAcceptingContext; use Behat\Behat\Context\SnippetAcceptingContext;
use Behat\Behat\Hook\Scope\AfterScenarioScope;
use Behat\Behat\Hook\Scope\BeforeScenarioScope;
use GuzzleHttp\Client;
use GuzzleHttp\Message\ResponseInterface;
require __DIR__ . '/../../vendor/autoload.php'; require __DIR__ . '/../../vendor/autoload.php';
@ -18,7 +22,12 @@ class CapabilitiesContext implements Context, SnippetAcceptingContext {
* @Given /^parameter "([^"]*)" of app "([^"]*)" is set to "([^"]*)"$/ * @Given /^parameter "([^"]*)" of app "([^"]*)" is set to "([^"]*)"$/
*/ */
public function serverParameterIsSetTo($parameter, $app, $value){ public function serverParameterIsSetTo($parameter, $app, $value){
$user = $this->currentUser;
$this->currentUser = 'admin';
$this->modifyServerConfig($app, $parameter, $value); $this->modifyServerConfig($app, $parameter, $value);
$this->currentUser = $user;
} }
/** /**
@ -46,8 +55,20 @@ class CapabilitiesContext implements Context, SnippetAcceptingContext {
/** /**
* @BeforeScenario * @BeforeScenario
*
* Enable the testing app before the first scenario of the feature and
* reset the configs before each scenario
* @param BeforeScenarioScope $event
*/ */
public function prepareParameters(){ public function prepareParameters(BeforeScenarioScope $event){
$user = $this->currentUser;
$this->currentUser = 'admin';
$scenarios = $event->getFeature()->getScenarios();
if ($event->getScenario() === reset($scenarios)) {
$this->setStatusTestingApp(true);
}
$this->modifyServerConfig('core', 'shareapi_enabled', 'yes'); $this->modifyServerConfig('core', 'shareapi_enabled', 'yes');
$this->modifyServerConfig('core', 'shareapi_allow_links', 'yes'); $this->modifyServerConfig('core', 'shareapi_allow_links', 'yes');
$this->modifyServerConfig('core', 'shareapi_allow_public_upload', 'yes'); $this->modifyServerConfig('core', 'shareapi_allow_public_upload', 'yes');
@ -58,22 +79,36 @@ class CapabilitiesContext implements Context, SnippetAcceptingContext {
$this->modifyServerConfig('core', 'shareapi_allow_public_notification', 'no'); $this->modifyServerConfig('core', 'shareapi_allow_public_notification', 'no');
$this->modifyServerConfig('core', 'shareapi_default_expire_date', 'no'); $this->modifyServerConfig('core', 'shareapi_default_expire_date', 'no');
$this->modifyServerConfig('core', 'shareapi_enforce_expire_date', 'no'); $this->modifyServerConfig('core', 'shareapi_enforce_expire_date', 'no');
$this->currentUser = $user;
} }
/** /**
* @AfterScenario * @AfterScenario
*
* Reset the values after the last scenario of the feature and disable the testing app
* @param AfterScenarioScope $event
*/ */
public function undoChangingParameters(){ public function undoChangingParameters(AfterScenarioScope $event) {
$this->modifyServerConfig('core', 'shareapi_enabled', 'yes'); $scenarios = $event->getFeature()->getScenarios();
$this->modifyServerConfig('core', 'shareapi_allow_links', 'yes'); if ($event->getScenario() === end($scenarios)) {
$this->modifyServerConfig('core', 'shareapi_allow_public_upload', 'yes'); $user = $this->currentUser;
$this->modifyServerConfig('core', 'shareapi_allow_resharing', 'yes'); $this->currentUser = 'admin';
$this->modifyServerConfig('files_sharing', 'outgoing_server2server_share_enabled', 'yes');
$this->modifyServerConfig('files_sharing', 'incoming_server2server_share_enabled', 'yes'); $this->modifyServerConfig('core', 'shareapi_enabled', 'yes');
$this->modifyServerConfig('core', 'shareapi_enforce_links_password', 'no'); $this->modifyServerConfig('core', 'shareapi_allow_links', 'yes');
$this->modifyServerConfig('core', 'shareapi_allow_public_notification', 'no'); $this->modifyServerConfig('core', 'shareapi_allow_public_upload', 'yes');
$this->modifyServerConfig('core', 'shareapi_default_expire_date', 'no'); $this->modifyServerConfig('core', 'shareapi_allow_resharing', 'yes');
$this->modifyServerConfig('core', 'shareapi_enforce_expire_date', 'no'); $this->modifyServerConfig('files_sharing', 'outgoing_server2server_share_enabled', 'yes');
$this->modifyServerConfig('files_sharing', 'incoming_server2server_share_enabled', 'yes');
$this->modifyServerConfig('core', 'shareapi_enforce_links_password', 'no');
$this->modifyServerConfig('core', 'shareapi_allow_public_notification', 'no');
$this->modifyServerConfig('core', 'shareapi_default_expire_date', 'no');
$this->modifyServerConfig('core', 'shareapi_enforce_expire_date', 'no');
$this->setStatusTestingApp(false);
$this->currentUser = $user;
}
} }
/** /**
@ -82,20 +117,10 @@ class CapabilitiesContext implements Context, SnippetAcceptingContext {
* @param string $value * @param string $value
*/ */
protected function modifyServerConfig($app, $parameter, $value) { protected function modifyServerConfig($app, $parameter, $value) {
$user = $this->currentUser;
$this->currentUser = 'admin';
$this->setStatusTestingApp(true);
$body = new \Behat\Gherkin\Node\TableNode([['value', $value]]); $body = new \Behat\Gherkin\Node\TableNode([['value', $value]]);
$this->sendingToWith('post', "/apps/testing/api/v1/app/{$app}/{$parameter}", $body); $this->sendingToWith('post', "/apps/testing/api/v1/app/{$app}/{$parameter}", $body);
$this->theHTTPStatusCodeShouldBe('200'); $this->theHTTPStatusCodeShouldBe('200');
$this->theOCSStatusCodeShouldBe('100'); $this->theOCSStatusCodeShouldBe('100');
$this->setStatusTestingApp(false);
$this->currentUser = $user;
} }
protected function setStatusTestingApp($enabled) { protected function setStatusTestingApp($enabled) {