From 19b7ae673a8553621b3544aa57f153cf2b7c8ad4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sergio=20Bertol=C3=ADn?= <sbertolin@solidgear.es>
Date: Wed, 15 Jun 2016 10:16:27 +0000
Subject: [PATCH] Added unfavoriting tests and some rewording

---
 .../integration/features/bootstrap/WebDav.php | 17 ++++++++----
 build/integration/features/favorites.feature  | 27 ++++++++++++++++---
 2 files changed, 36 insertions(+), 8 deletions(-)

diff --git a/build/integration/features/bootstrap/WebDav.php b/build/integration/features/bootstrap/WebDav.php
index 10bd05cbbb..0abb866773 100644
--- a/build/integration/features/bootstrap/WebDav.php
+++ b/build/integration/features/bootstrap/WebDav.php
@@ -214,7 +214,7 @@ trait WebDav {
 		}
 
 		$value = $keys[$key];
-		if ($value !== $expectedValue) {
+		if ($value != $expectedValue) {
 			throw new \Exception("Property \"$key\" found with value \"$value\", expected \"$expectedValue\"");
 		}
 	}
@@ -438,12 +438,19 @@ trait WebDav {
 	/**
 	 * @When user :user favorites element :path
 	 */
-	public function userFavoritesFolder($user, $path){
-		$this->response = $this->favFolder($user, $path, 0, null);
+	public function userFavoritesElement($user, $path){
+		$this->response = $this->changeFavStateOfAnElement($user, $path, 1, 0, null);
+	}
+
+	/**
+	 * @When user :user unfavorites element :path
+	 */
+	public function userUnfavoritesElement($user, $path){
+		$this->response = $this->changeFavStateOfAnElement($user, $path, 0, 0, null);
 	}
 
 	/*Set the elements of a proppatch, $folderDepth requires 1 to see elements without children*/
-	public function favFolder($user, $path, $folderDepth, $properties = null){
+	public function changeFavStateOfAnElement($user, $path, $favOrUnfav, $folderDepth, $properties = null){
 		$fullUrl = substr($this->baseUrl, 0, -4);
 		$settings = array(
 			'baseUri' => $fullUrl,
@@ -457,7 +464,7 @@ trait WebDav {
 		$client = new SClient($settings);
 		if (!$properties) {
 			$properties = [
-				'{http://owncloud.org/ns}favorite' => 1
+				'{http://owncloud.org/ns}favorite' => $favOrUnfav
 			];
 		}
 
diff --git a/build/integration/features/favorites.feature b/build/integration/features/favorites.feature
index 8025f0834f..86643fdd1e 100644
--- a/build/integration/features/favorites.feature
+++ b/build/integration/features/favorites.feature
@@ -2,7 +2,7 @@ Feature: favorite
     Background:
         Given using api version "1"
 
-    Scenario: Retrieving favorite info of a folder
+    Scenario: Favorite a folder
         Given using dav path "remote.php/webdav"
         And As an "admin"
         And user "user0" exists
@@ -11,11 +11,32 @@ Feature: favorite
             |{http://owncloud.org/ns}favorite|
         And the single response should contain a property "{http://owncloud.org/ns}favorite" with value "1"
 
-    Scenario: Retrieving favorite info of a file
+    Scenario: Favorite and unfavorite a folder
+        Given using dav path "remote.php/webdav"
+        And As an "admin"
+        And user "user0" exists
+        When user "user0" favorites element "/FOLDER"
+        And user "user0" unfavorites element "/FOLDER"
+        Then as "user0" gets properties of folder "/FOLDER" with
+            |{http://owncloud.org/ns}favorite|
+        And the single response should contain a property "{http://owncloud.org/ns}favorite" with value ""
+
+    Scenario: Favorite a file
         Given using dav path "remote.php/webdav"
         And As an "admin"
         And user "user0" exists
         When user "user0" favorites element "/textfile0.txt"
         Then as "user0" gets properties of file "/textfile0.txt" with
             |{http://owncloud.org/ns}favorite|
-        And the single response should contain a property "{http://owncloud.org/ns}favorite" with value "1"
\ No newline at end of file
+        And the single response should contain a property "{http://owncloud.org/ns}favorite" with value "1"
+
+    Scenario: Favorite and unfavorite a file
+        Given using dav path "remote.php/webdav"
+        And As an "admin"
+        And user "user0" exists
+        When user "user0" favorites element "/textfile0.txt"
+        And user "user0" unfavorites element "/textfile0.txt"
+        Then as "user0" gets properties of file "/textfile0.txt" with
+            |{http://owncloud.org/ns}favorite|
+        And the single response should contain a property "{http://owncloud.org/ns}favorite" with value ""
+