mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #12006 from iPaat/Backport13/Fix11847 

[stable13] Remove cookies from Clear-Site-Data Header
This commit is contained in:
Morris Jobke 2018-10-24 14:35:54 +02:00 committed by GitHub
parent ae17e55f42 06e43bb46a
commit 1a28789db1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/Controller/LoginController.php
View File

@ -120,7 +120,7 @@ class LoginController extends Controller {
$this->userSession->logout(); $this->userSession->logout();
$response = new RedirectResponse($this->urlGenerator->linkToRouteAbsolute('core.login.showLoginForm')); $response = new RedirectResponse($this->urlGenerator->linkToRouteAbsolute('core.login.showLoginForm'));
$response->addHeader('Clear-Site-Data', '"cache", "cookies", "storage", "executionContexts"'); $response->addHeader('Clear-Site-Data', '"cache", "storage", "executionContexts"');
return $response; return $response;
} }

4
tests/Core/Controller/LoginControllerTest.php
View File

@ -100,7 +100,7 @@ class LoginControllerTest extends TestCase {
->willReturn('/login'); ->willReturn('/login');
$expected = new RedirectResponse('/login'); $expected = new RedirectResponse('/login');
$expected->addHeader('Clear-Site-Data', '"cache", "cookies", "storage", "executionContexts"'); $expected->addHeader('Clear-Site-Data', '"cache", "storage", "executionContexts"');
$this->assertEquals($expected, $this->loginController->logout()); $this->assertEquals($expected, $this->loginController->logout());
} }
@ -130,7 +130,7 @@ class LoginControllerTest extends TestCase {
->willReturn('/login'); ->willReturn('/login');
$expected = new RedirectResponse('/login'); $expected = new RedirectResponse('/login');
$expected->addHeader('Clear-Site-Data', '"cache", "cookies", "storage", "executionContexts"'); $expected->addHeader('Clear-Site-Data', '"cache", "storage", "executionContexts"');
$this->assertEquals($expected, $this->loginController->logout()); $this->assertEquals($expected, $this->loginController->logout());
} }