Merge pull request #19820 from nextcloud/fix/mismatching-docblock-return-type

Fix mismatching docblock return types

apps/files_versions/lib/Versions/IVersionBackend.php

@@ -91,7 +91,9 @@ interface IVersionBackend {
 	 * @param IUser $user
 	 * @param FileInfo $sourceFile
 	 * @param int|string $revision
-	 * @return ISimpleFile
+	 *
+	 * @return File
+	 *
 	 * @since 15.0.0
 	 */
 	public function getVersionFile(IUser $user, FileInfo $sourceFile, $revision): File;

core/Migrations/Version16000Date20190212081545.php

@@ -38,7 +38,8 @@ class Version16000Date20190212081545 extends SimpleMigrationStep {
 	 * @param IOutput $output
 	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
 	 * @param array $options
-	 * @return null|ISchemaWrapper
+	 *
+	 * @return ISchemaWrapper
 	 */
 	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ISchemaWrapper {
 		/** @var ISchemaWrapper $schema */

lib/private/AllConfig.php

@@ -129,7 +129,9 @@ class AllConfig implements \OCP\IConfig {
 	 *
 	 * @param string $key the key of the value, under which it was saved
 	 * @param mixed $default the default value to be returned if the value isn't set
-	 * @return mixed the value or $default
+	 *
+	 * @return bool
+	 *
 	 * @since 16.0.0
 	 */
 	public function getSystemValueBool(string $key, bool $default = false): bool {
@@ -141,7 +143,9 @@ class AllConfig implements \OCP\IConfig {
 	 *
 	 * @param string $key the key of the value, under which it was saved
 	 * @param mixed $default the default value to be returned if the value isn't set
-	 * @return mixed the value or $default
+	 *
+	 * @return int
+	 *
 	 * @since 16.0.0
 	 */
 	public function getSystemValueInt(string $key, int $default = 0): int {
@@ -153,7 +157,9 @@ class AllConfig implements \OCP\IConfig {
 	 *
 	 * @param string $key the key of the value, under which it was saved
 	 * @param mixed $default the default value to be returned if the value isn't set
-	 * @return mixed the value or $default
+	 *
+	 * @return string
+	 *
 	 * @since 16.0.0
 	 */
 	public function getSystemValueString(string $key, string $default = ''): string {

lib/private/Authentication/TwoFactorAuth/EnforcementState.php

@@ -55,7 +55,7 @@ class EnforcementState implements JsonSerializable {
 	}
 
 	/**
-	 * @return string[]
+	 * @return bool
 	 */
 	public function isEnforced(): bool {
 		return $this->enforced;

lib/private/Group/Database.php

@@ -400,7 +400,8 @@ class Database extends ABackend
 	 * get the number of disabled users in a group
 	 *
 	 * @param string $search
-	 * @return int|bool
+	 *
+	 * @return int
 	 */
 	public function countDisabledInGroup(string $gid): int {
 		$this->fixDI();

lib/private/User/Session.php

@@ -317,7 +317,7 @@ class Session implements IUserSession, Emitter {
 	}
 
 	/**
-	 * @return mixed
+	 * @return null|string
 	 */
 	public function getImpersonatingUserID(): ?string {