Compare objects directly. Also use $expected and $actual.

This commit is contained in:
Andreas Fischer 2013-09-12 22:52:14 +02:00
parent bd1163b7d5
commit 20b799b2b4
1 changed files with 6 additions and 6 deletions

View File

@ -155,10 +155,10 @@ class Test_DB extends PHPUnit_Framework_TestCase {
$column = 'timestamptest';
$expectedFormat = 'Y-m-d H:i:s';
$now = new \DateTime;
$expected = new \DateTime;
$query = OC_DB::prepare("INSERT INTO `$table` (`$column`) VALUES (?)");
$result = $query->execute(array($now->format($expectedFormat)));
$result = $query->execute(array($expected->format($expectedFormat)));
$this->assertEquals(
1,
$result,
@ -170,16 +170,16 @@ class Test_DB extends PHPUnit_Framework_TestCase {
$result = $query->execute(array($id));
$row = $result->fetchRow();
$dateFromDb = \DateTime::createFromFormat($expectedFormat, $row[$column]);
$actual = \DateTime::createFromFormat($expectedFormat, $row[$column]);
$this->assertInstanceOf(
'\DateTime',
$dateFromDb,
$actual,
"Database failed to return dates in the format '$expectedFormat'."
);
$this->assertEquals(
$now->format('c u'),
$dateFromDb->format('c u'),
$expected,
$actual,
'Failed asserting that the returned date is the same as the inserted.'
);
}