From 22c083b58a8524567e717a16db86e9690b247275 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20Molakvo=C3=A6=20=28skjnldsv=29?=
 <skjnldsv@protonmail.com>
Date: Wed, 31 Jan 2018 14:51:27 +0100
Subject: [PATCH] Fixed app navigation flex margins
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
---
 core/css/apps.scss | 35 +++++++++--------------------------
 1 file changed, 9 insertions(+), 26 deletions(-)

diff --git a/core/css/apps.scss b/core/css/apps.scss
index 41eea3bb52..a92db4ed4a 100644
--- a/core/css/apps.scss
+++ b/core/css/apps.scss
@@ -118,7 +118,6 @@ kbd {
 				}
 			}
 
-			> a,
 			> .app-navigation-entry-deleted {
 				/* Ugly hack for overriding the main entry link */
 				padding-left: 44px !important;
@@ -161,13 +160,14 @@ kbd {
 
 			/* Second level nesting for lists */
 			> ul {
-				flex: 1 0 100%;
-				padding-left: 62px;
-				width: inherit;
+				flex: 0 1 auto;
+				padding-left: 44px;
+				width: 100%;
 				transition: max-height 2000ms ease-in-out,
 							opacity 250ms ease-in-out;
 				max-height: 9999px;
 				opacity: 1;
+				position: relative;
 				> li {
 					display: inline-flex;
 					flex-wrap: wrap;
@@ -183,19 +183,7 @@ kbd {
 
 					/* align loader */
 					&.icon-loading-small:after {
-						left: -10px;
-					}
-
-					/* Submenu fix for icon */
-					> a[class*='icon-'],
-					> a[style*='background-image'],
-					.app-navigation-entry-bullet {
-						margin-left: -32px; /* 44px padding - 12px padding */
-					}
-
-					/* Submenu fix for bullet */
-					> .app-navigation-entry-bullet {
-						left: -32px;/* 44px padding - 12px padding */
+						left: 22px; /* 44px / 2 */
 					}
 				}
 			}
@@ -210,6 +198,7 @@ kbd {
 			&.icon-loading-small {
 				> a,
 				> .app-navigation-entry-bullet {
+					/* hide icon or bullet if loading state*/
 					background: none !important;
 				}
 			}
@@ -222,7 +211,7 @@ kbd {
 				justify-content: space-between;
 				line-height: 44px;
 				min-height: 44px;
-				padding: 0 12px;
+				padding: 0 12px 0 44px;
 				overflow: hidden;
 				box-sizing: border-box;
 				white-space: nowrap;
@@ -230,7 +219,7 @@ kbd {
 				color: $color-main-text;
 				opacity: .57;
 				flex: 1 1 0;
-				z-index: 100; /* above the bullet */
+				z-index: 100; /* above the bullet to allow click*/
 				/* TODO: forbid using img as icon in menu? */
 				&:first-child img {
 				    margin-right: 11px;
@@ -260,12 +249,6 @@ kbd {
 				cursor: pointer;
 			}
 
-			/* padding in case of icon or bullet */
-			> a[class*='icon-'],
-			> a[style*='background-image'] {
-				padding-left: 44px;
-			}
-
 			/* popover fix the flex positionning of the li parent */
 			> .app-navigation-entry-menu {
 				top: 44px;
@@ -467,7 +450,7 @@ kbd {
 	 */
 	.app-navigation-entry-deleted {
 		display: inline-flex;
-		padding-left: 12px;
+		padding-left: 44px;
 		transform: translateX(250px);
 		.app-navigation-entry-deleted-description {
 			position: relative;