don't update identical values

The UPDATE oc_filecache statement blindly overwrites identical data.
Databases like Postgres that create a new row on an update
and mark the old one as dead will suffer from the previous
behaviour, as millions of "new" rows are created in the database.

This patch changes the WHERE clause to test for identical
values and not updating if the values in the DB are identical
to the ones being passed.
This commit is contained in:
Jens-Christian Fischer 2015-04-11 18:06:21 +02:00
parent 7ce4d2dec9
commit 22c6216f5c
1 changed files with 7 additions and 1 deletions

View File

@ -306,10 +306,16 @@ class Cache {
}
list($queryParts, $params) = $this->buildParts($data);
$params = array_merge($params, $params);
$params[] = $id;
$sql = 'UPDATE `*PREFIX*filecache` SET ' . implode(' = ?, ', $queryParts) . '=? WHERE `fileid` = ?';
// don't update if the data we try to set is the same as the one in the record
// some databases (Postgres) don't like superfluous updates
$sql = 'UPDATE `*PREFIX*filecache` SET ' . implode(' = ?, ', $queryParts) . '=? ' .
'WHERE (' . implode(' <> ? OR ', $queryParts) . ' <> ? ) AND `fileid` = ? ';
\OC_DB::executeAudited($sql, $params);
}
/**