From 22ed863dd7769b220a0fee12f28925995cb564bb Mon Sep 17 00:00:00 2001
From: Morris Jobke <hey@morrisjobke.de>
Date: Sun, 29 Nov 2020 21:45:06 +0100
Subject: [PATCH] Use DI for files_sharing Cache

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
---
 apps/files_sharing/lib/Cache.php         | 20 +++++++-------------
 apps/files_sharing/lib/SharedStorage.php |  7 ++++++-
 2 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/apps/files_sharing/lib/Cache.php b/apps/files_sharing/lib/Cache.php
index 74a870515c..16a7b12340 100644
--- a/apps/files_sharing/lib/Cache.php
+++ b/apps/files_sharing/lib/Cache.php
@@ -42,15 +42,12 @@ use OCP\IUserManager;
  * don't use this class directly if you need to get metadata, use \OC\Files\Filesystem::getFileInfo instead
  */
 class Cache extends CacheJail {
-	/**
-	 * @var \OCA\Files_Sharing\SharedStorage
-	 */
+	/** @var \OCA\Files_Sharing\SharedStorage */
 	private $storage;
-
-	/**
-	 * @var ICacheEntry
-	 */
+	/** @var ICacheEntry */
 	private $sourceRootInfo;
+	/** @var IUserManager */
+	private $userManager;
 
 	private $rootUnchanged = true;
 
@@ -58,13 +55,10 @@ class Cache extends CacheJail {
 
 	private $numericId;
 
-	/**
-	 * @param \OCA\Files_Sharing\SharedStorage $storage
-	 * @param ICacheEntry $sourceRootInfo
-	 */
-	public function __construct($storage, ICacheEntry $sourceRootInfo) {
+	public function __construct(SharedStorage $storage, ICacheEntry $sourceRootInfo, IUserManager $userManager) {
 		$this->storage = $storage;
 		$this->sourceRootInfo = $sourceRootInfo;
+		$this->userManager = $userManager;
 		$this->numericId = $sourceRootInfo->getStorageId();
 
 		parent::__construct(
@@ -172,7 +166,7 @@ class Cache extends CacheJail {
 	private function getOwnerDisplayName() {
 		if (!$this->ownerDisplayName) {
 			$uid = $this->storage->getOwner('');
-			$user = \OC::$server->get(IUserManager::class)->get($uid);
+			$user = $this->userManager->get($uid);
 			if ($user) {
 				$this->ownerDisplayName = $user->getDisplayName();
 			} else {
diff --git a/apps/files_sharing/lib/SharedStorage.php b/apps/files_sharing/lib/SharedStorage.php
index eb0af41998..1a0f852786 100644
--- a/apps/files_sharing/lib/SharedStorage.php
+++ b/apps/files_sharing/lib/SharedStorage.php
@@ -44,6 +44,7 @@ use OCP\Files\Cache\ICacheEntry;
 use OCP\Files\NotFoundException;
 use OCP\Files\Storage\IDisableEncryptionStorage;
 use OCP\Files\Storage\IStorage;
+use OCP\IUserManager;
 use OCP\Lock\ILockingProvider;
 use OCP\Share\IShare;
 
@@ -386,7 +387,11 @@ class SharedStorage extends \OC\Files\Storage\Wrapper\Jail implements ISharedSto
 			return new FailedCache();
 		}
 
-		$this->cache = new \OCA\Files_Sharing\Cache($storage, $sourceRoot, $this->superShare);
+		$this->cache = new \OCA\Files_Sharing\Cache(
+			$storage,
+			$sourceRoot,
+			\OC::$server->get(IUserManager::class)
+		);
 		return $this->cache;
 	}