mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove check for outdated caches 

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
This commit is contained in:
Daniel Kesselberg 2019-01-01 17:01:46 +01:00
parent d2bc85728d
commit 248e824f48
No known key found for this signature in database
GPG Key ID: 36E3664E099D0614
4 changed files with 0 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
core/js/setupchecks.js
View File

@ -159,18 +159,6 @@
type: OC.SetupChecks.MESSAGE_TYPE_INFO
});
}
if (data.outdatedCaches.length > 0) {
data.outdatedCaches.forEach(function(element){
messages.push({
msg: t(
'core',
'{name} below version {version} is installed, for stability and performance reasons it is recommended to update to a newer {name} version.',
element
),
type: OC.SetupChecks.MESSAGE_TYPE_WARNING
})
});
}
if(!data.hasWorkingFileLocking) {
messages.push({
msg: t('core', 'Transactional file locking is disabled, this might lead to issues with race conditions. Enable "filelocking.enabled" in config.php to avoid these problems. See the <a target="_blank" rel="noreferrer noopener" href="{docLink}">documentation ↗</a> for more information.', {docLink: oc_defaults.docPlaceholderUrl.replace('PLACEHOLDER', 'admin-transactional-locking')}),

13
core/js/tests/specs/setupchecksSpec.js
View File

@ -204,7 +204,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: true,
hasFreeTypeSupport: true,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0
@ -255,7 +254,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: true,
hasFreeTypeSupport: true,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0
@ -307,7 +305,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: true,
hasFreeTypeSupport: true,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0
@ -357,7 +354,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: true,
hasFreeTypeSupport: true,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0
@ -405,7 +401,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: true,
hasFreeTypeSupport: true,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0
@ -453,7 +448,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: true,
hasFreeTypeSupport: true,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0
@ -503,7 +497,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: true,
hasFreeTypeSupport: true,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0
@ -551,7 +544,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: false,
hasFreeTypeSupport: true,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0
@ -599,7 +591,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: true,
hasFreeTypeSupport: true,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0
@ -668,7 +659,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: true,
hasFreeTypeSupport: true,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0
@ -717,7 +707,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: true,
hasFreeTypeSupport: true,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0
@ -766,7 +755,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: true,
hasFreeTypeSupport: true,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0
@ -815,7 +803,6 @@ describe('OC.SetupChecks tests', function() {
isSettimelimitAvailable: true,
hasFreeTypeSupport: false,
missingIndexes: [],
outdatedCaches: [],
cronErrors: [],
cronInfo: {
diffInSeconds: 0

20
settings/Controller/CheckSetupController.php
View File

@ -448,25 +448,6 @@ Raw output
return $indexInfo->getListOfMissingIndexes();
}
/**
* warn if outdated version of a memcache module is used
*/
protected function getOutdatedCaches(): array {
$caches = [
'apcu' => ['name' => 'APCu', 'version' => '4.0.6'],
'redis' => ['name' => 'Redis', 'version' => '2.2.5'],
];
$outdatedCaches = [];
foreach ($caches as $php_module => $data) {
$isOutdated = extension_loaded($php_module) && version_compare(phpversion($php_module), $data['version'], '<');
if ($isOutdated) {
$outdatedCaches[] = $data;
}
}
return $outdatedCaches;
}
protected function isSqliteUsed() {
return strpos($this->config->getSystemValue('dbtype'), 'sqlite') !== false;
}
@ -647,7 +628,6 @@ Raw output
'isGetenvServerWorking' => !empty(getenv('PATH')),
'isReadOnlyConfig' => $this->isReadOnlyConfig(),
'hasValidTransactionIsolationLevel' => $this->hasValidTransactionIsolationLevel(),
'outdatedCaches' => $this->getOutdatedCaches(),
'hasFileinfoInstalled' => $this->hasFileinfoInstalled(),
'hasWorkingFileLocking' => $this->hasWorkingFileLocking(),
'suggestedOverwriteCliURL' => $this->getSuggestedOverwriteCliURL(),

5
tests/Settings/Controller/CheckSetupControllerTest.php
View File

@ -148,7 +148,6 @@ class CheckSetupControllerTest extends TestCase {
'hasWorkingFileLocking',
'getLastCronInfo',
'getSuggestedOverwriteCliURL',
'getOutdatedCaches',
'getCurlVersion',
'isPhpOutdated',
'isOpcacheProperlySetup',
@ -434,9 +433,6 @@ class CheckSetupControllerTest extends TestCase {
$this->checkSetupController
->method('hasMissingIndexes')
->willReturn([]);
$this->checkSetupController
->method('getOutdatedCaches')
->willReturn([]);
$this->checkSetupController
->method('isSqliteUsed')
->willReturn(false);
@ -504,7 +500,6 @@ class CheckSetupControllerTest extends TestCase {
'isGetenvServerWorking' => true,
'isReadOnlyConfig' => false,
'hasValidTransactionIsolationLevel' => true,
'outdatedCaches' => [],
'hasFileinfoInstalled' => true,
'hasWorkingFileLocking' => true,
'suggestedOverwriteCliURL' => '',