Merge pull request #2032 from nextcloud/noodlesegg-refactor
refactoring code to reduce cyclomatic complexit
This commit is contained in:
commit
25a8d9f543
|
@ -92,9 +92,8 @@ abstract class Controller {
|
|||
}
|
||||
$response->setHeaders(array_merge($dataHeaders, $headers));
|
||||
return $response;
|
||||
} else {
|
||||
return new JSONResponse($data);
|
||||
}
|
||||
return new JSONResponse($data);
|
||||
}
|
||||
);
|
||||
}
|
||||
|
@ -153,10 +152,9 @@ abstract class Controller {
|
|||
|
||||
return $responder($response);
|
||||
|
||||
} else {
|
||||
throw new \DomainException('No responder registered for format ' .
|
||||
$format . '!');
|
||||
}
|
||||
throw new \DomainException('No responder registered for format '.
|
||||
$format . '!');
|
||||
}
|
||||
|
||||
|
||||
|
|
|
@ -106,12 +106,9 @@ abstract class OCSController extends ApiController {
|
|||
*/
|
||||
private function buildOCSResponse($format, DataResponse $data) {
|
||||
if ($this->ocsVersion === 1) {
|
||||
$response = new \OC\AppFramework\OCS\V1Response($data, $format);
|
||||
} else {
|
||||
$response = new \OC\AppFramework\OCS\V2Response($data, $format);
|
||||
return new \OC\AppFramework\OCS\V1Response($data, $format);
|
||||
}
|
||||
|
||||
return $response;
|
||||
return new \OC\AppFramework\OCS\V2Response($data, $format);
|
||||
}
|
||||
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue