mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Do not only catch Exceptions but any Throwable during rmt share delete 

When a remote share is deleted, we notify the remove instance. This may
trigger various error conditions, which we want to catch in order to
avoid undeletable shares. The try-catch, however, did only capture
exceptions, so things like TypeErrors were not caught and caused the
process to fail hard.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
This commit is contained in:
Christoph Wurst 2020-06-02 09:21:09 +02:00 committed by backportbot[bot]
parent f431c145bc
commit 25dd585251
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/files_sharing/lib/External/Manager.php vendored
View File

@ -520,7 +520,7 @@ class Manager {
if ($result && $share !== false && (int)$share['share_type'] === Share::SHARE_TYPE_USER) { if ($result && $share !== false && (int)$share['share_type'] === Share::SHARE_TYPE_USER) {
try { try {
$this->sendFeedbackToRemote($share['remote'], $share['share_token'], $share['remote_id'], 'decline'); $this->sendFeedbackToRemote($share['remote'], $share['share_token'], $share['remote_id'], 'decline');
} catch (\Exception $e) { } catch (\Throwable $e) {
// if we fail to notify the remote (probably cause the remote is down) // if we fail to notify the remote (probably cause the remote is down)
// we still want the share to be gone to prevent undeletable remotes // we still want the share to be gone to prevent undeletable remotes
} }
@ -630,7 +630,7 @@ class Manager {
} }
$query = 'SELECT `id`, `remote`, `remote_id`, `share_token`, `name`, `owner`, `user`, `mountpoint`, `accepted` $query = 'SELECT `id`, `remote`, `remote_id`, `share_token`, `name`, `owner`, `user`, `mountpoint`, `accepted`
FROM `*PREFIX*share_external` FROM `*PREFIX*share_external`
WHERE (`user` = ? OR `user` IN (?))'; WHERE (`user` = ? OR `user` IN (?))';
$parameters = [$this->uid, implode(',',$userGroups)]; $parameters = [$this->uid, implode(',',$userGroups)];
if (!is_null($accepted)) { if (!is_null($accepted)) {