From 5369a132b6ceef5b8bf34f310a886d42af4444a7 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Fri, 14 Jun 2019 14:16:25 +0200 Subject: [PATCH] Sharing in list: Use .hidden-visually instead of display:none for accessibility, fix #11661 Signed-off-by: Jan-Christoph Borchardt --- apps/files/css/files.scss | 13 ++++++++++--- apps/files/css/mobile.scss | 10 ++++++++-- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/apps/files/css/files.scss b/apps/files/css/files.scss index 8b37b65b94..1ffe8af432 100644 --- a/apps/files/css/files.scss +++ b/apps/files/css/files.scss @@ -541,8 +541,15 @@ a.action > img { opacity: .3; &.action-share { padding: 17px 14px; - > span:not(.icon) { - display: none; + &.permanent:not(.shared-style) .icon-shared + span { + /* hide text of the share action */ + /* .hidden-visually for accessbility */ + position: absolute; + left:-10000px; + top: auto; + width: 1px; + height: 1px; + overflow: hidden; } .avatar { display: inline-block; @@ -752,7 +759,7 @@ table.dragshadow td.size { border-radius: 0; background-color: transparent; z-index:1; - + > a[href='#'] { // if no link is set, no mouse feedback box-shadow: none !important; diff --git a/apps/files/css/mobile.scss b/apps/files/css/mobile.scss index b661fc61d4..5437451d53 100644 --- a/apps/files/css/mobile.scss +++ b/apps/files/css/mobile.scss @@ -36,8 +36,14 @@ table.multiselect thead { margin-right: 6px; } /* hide text of the share action on mobile */ -#fileList a.action-share span:not(.icon) { - display: none !important; +/* .hidden-visually for accessbility */ +#fileList a.action-share span:not(.icon):not(.avatar) { + position: absolute; + left:-10000px; + top: auto; + width: 1px; + height: 1px; + overflow: hidden; }