From 6283b573105d9d286dd12ecd5514a4aa91bed725 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Mon, 24 Jun 2019 14:13:27 +0200 Subject: [PATCH 1/3] Fix size of header menus MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- core/css/header.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/core/css/header.scss b/core/css/header.scss index 2b63dc978a..5f2f285cf7 100644 --- a/core/css/header.scss +++ b/core/css/header.scss @@ -113,6 +113,9 @@ /* Use by the apps menu and the settings right menu */ #apps > ul, &.settings-menu > ul { + max-height: calc(100vh - #{$header-height}); + overflow: scroll; + li { a { display: inline-flex; From d889019f00daca79dada476bba701d0128948541 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Mon, 24 Jun 2019 17:24:40 +0200 Subject: [PATCH 2/3] Fix horizontal scrollbar in user menu Signed-off-by: Jan-Christoph Borchardt --- core/css/header.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/css/header.scss b/core/css/header.scss index 5f2f285cf7..c7017e16e8 100644 --- a/core/css/header.scss +++ b/core/css/header.scss @@ -114,7 +114,7 @@ #apps > ul, &.settings-menu > ul { max-height: calc(100vh - #{$header-height}); - overflow: scroll; + overflow-y: scroll; li { a { From bef426e3f4592a727a863fbba98a948562c80a85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Fri, 4 Oct 2019 20:56:10 +0200 Subject: [PATCH 3/3] Move to proper scroll container and add more space to height MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- core/css/header.scss | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/core/css/header.scss b/core/css/header.scss index c7017e16e8..9f6ef76503 100644 --- a/core/css/header.scss +++ b/core/css/header.scss @@ -87,10 +87,12 @@ z-index: 2000; position: absolute; max-width: 350px; - max-height: $header-menu-entry-height * 7.5; // half entry + min-height: calc(44px * 1.5); // show at least 1.5 entries + max-height: calc(100vh - #{$header-height} * 2); right: 5px; // relative to parent top: $header-height; margin: 0; + overflow-y: scroll; -webkit-overflow-scrolling: touch; &:not(.popovermenu) { @@ -112,10 +114,7 @@ /* Use by the apps menu and the settings right menu */ #apps > ul, - &.settings-menu > ul { - max-height: calc(100vh - #{$header-height}); - overflow-y: scroll; - + &.settings-menu { li { a { display: inline-flex; @@ -321,13 +320,6 @@ nav[role='navigation'] { } } -#apps { - max-height: inherit; - overflow-x: hidden; - overflow-y: auto; - -webkit-overflow-scrolling: touch; -} - /* USER MENU -----------------------------------------------------------------*/ #settings { display: inline-block;