From 2b5d933b63ad7b1e5401c146724d7694ed28f858 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Wed, 18 Apr 2018 17:03:45 +0200 Subject: [PATCH] Remove no longer needed escaping of special characters MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The escaping of special characters was needed when the ids of the permission checkboxes for shares were based on the "shareWith" field. Since they are based on the "shareId" field the escaping is no longer needed, as the "sharedId" is expected to always contain compatible characters. Signed-off-by: Daniel Calviño Sánchez --- core/js/sharedialogshareelistview.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/core/js/sharedialogshareelistview.js b/core/js/sharedialogshareelistview.js index a88c38fb4e..6e5248e83e 100644 --- a/core/js/sharedialogshareelistview.js +++ b/core/js/sharedialogshareelistview.js @@ -380,9 +380,7 @@ var $li = this.$('li[data-share-id=' + permissionChangeShareId + ']'); $li.find('.sharingOptionsGroup .popovermenu').replaceWith(this.popoverMenuTemplate(sharee)); - var checkBoxId = 'canEdit-' + this.cid + '-' + sharee.shareId; - checkBoxId = '#' + checkBoxId.replace( /(:|\.|\[|\]|,|=|@)/g, "\\$1"); - var $edit = $li.parent().find(checkBoxId); + var $edit = $li.parent().find('#canEdit-' + this.cid + '-' + sharee.shareId); if($edit.length === 1) { $edit.prop('checked', sharee.hasEditPermission); }