mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't encode url unecessary twice 

The URL was previously encoded twice which leads to getting redirected to a 404 page when the password has been entered incorrect at least once.

Testplan:

- [ ] Opening `http://localhost/core/index.php?redirect_url=%2Fcore%2Findex.php%2Fsettings%2Fadmin` redirects to the admin page when providing the correct credentials
- [ ] Opening `http://localhost/core/index.php?redirect_url=%2Fcore%2Findex.php%2Fsettings%2Fadmin` redirects to the admin page when providing the invalid credentials and then providing valid ones.
- [ ] Logging in as admin then going to the admin page and clearing the cookies and refreshing will show the login and when repeating the above test steps you're redirected correctly.

Fixes https://github.com/owncloud/core/issues/9804
This commit is contained in:
Lukas Reschke 2015-02-02 15:09:59 +01:00
parent 92bc1b44d5
commit 2bd1c17345
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/private/util.php
View File

@ -818,8 +818,7 @@ class OC_Util {
$parameters['user_autofocus'] = true; $parameters['user_autofocus'] = true;
} }
if (isset($_REQUEST['redirect_url'])) { if (isset($_REQUEST['redirect_url'])) {
$redirectUrl = $_REQUEST['redirect_url']; $parameters['redirect_url'] = $_REQUEST['redirect_url'];
$parameters['redirect_url'] = urlencode($redirectUrl);
} }
$parameters['alt_login'] = OC_App::getAlternativeLogIns(); $parameters['alt_login'] = OC_App::getAlternativeLogIns();