From 2bd81a2557f5b279f0f579fa334e2d5d670012dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Sun, 28 Oct 2018 19:48:27 +0100 Subject: [PATCH] Extract acceptance tests for tags to their own feature file MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Daniel Calviño Sánchez --- .drone.yml | 9 ++ .../features/app-files-tags.feature | 89 +++++++++++++++++++ tests/acceptance/features/app-files.feature | 88 ------------------ 3 files changed, 98 insertions(+), 88 deletions(-) create mode 100644 tests/acceptance/features/app-files-tags.feature diff --git a/.drone.yml b/.drone.yml index 5768f9bbf3..5eb61a2878 100644 --- a/.drone.yml +++ b/.drone.yml @@ -678,6 +678,13 @@ pipeline: when: matrix: TESTS-ACCEPTANCE: app-files + acceptance-app-files-tags: + image: nextcloudci/acceptance-php7.1:acceptance-php7.1-2 + commands: + - tests/acceptance/run-local.sh --timeout-multiplier 10 --nextcloud-server-domain acceptance-app-files-tags --selenium-server selenium:4444 allow-git-repository-modifications features/app-files-tags.feature + when: + matrix: + TESTS-ACCEPTANCE: app-files-tags acceptance-app-theming: image: nextcloudci/acceptance-php7.1:acceptance-php7.1-2 commands: @@ -921,6 +928,8 @@ matrix: TESTS-ACCEPTANCE: app-comments - TESTS: acceptance TESTS-ACCEPTANCE: app-files + - TESTS: acceptance + TESTS-ACCEPTANCE: app-files-tags - TESTS: acceptance TESTS-ACCEPTANCE: app-theming - TESTS: acceptance diff --git a/tests/acceptance/features/app-files-tags.feature b/tests/acceptance/features/app-files-tags.feature new file mode 100644 index 0000000000..993c505b73 --- /dev/null +++ b/tests/acceptance/features/app-files-tags.feature @@ -0,0 +1,89 @@ +Feature: app-files-tags + + Scenario: show the input field for tags in the details view + Given I am logged in + And I open the details view for "welcome.txt" + And I see that the details view is open + When I open the input field for tags in the details view + Then I see that the input field for tags in the details view is shown + + Scenario: show the input field for tags in the details view after the sharing tab has loaded + Given I am logged in + And I open the details view for "welcome.txt" + And I see that the details view is open + And I open the "Sharing" tab in the details view + And I see that the "Sharing" tab in the details view is eventually loaded + When I open the input field for tags in the details view + Then I see that the input field for tags in the details view is shown + + Scenario: create tags using the Administration settings + Given I am logged in as the admin + And I visit the settings page + And I open the "Workflow" section + # The "create" button does nothing before JavaScript was initialized, and + # the only way to detect that is waiting for the button to select tags to be + # shown. + And I see that the button to select tags is shown + When I create the tag "tag1" in the settings + Then I see that the dropdown for tags in the settings eventually contains the tag "tag1" + + Scenario: add tags using the dropdown in the details view + Given I am logged in as the admin + And I visit the settings page + And I open the "Workflow" section + # The "create" button does nothing before JavaScript was initialized, and + # the only way to detect that is waiting for the button to select tags to be + # shown. + And I see that the button to select tags is shown + And I create the tag "tag1" in the settings + And I create the tag "tag2" in the settings + And I create the tag "tag3" in the settings + And I create the tag "tag4" in the settings + And I see that the dropdown for tags in the settings eventually contains the tag "tag1" + And I see that the dropdown for tags in the settings eventually contains the tag "tag2" + And I see that the dropdown for tags in the settings eventually contains the tag "tag3" + And I see that the dropdown for tags in the settings eventually contains the tag "tag4" + And I log out + And I am logged in + And I open the details view for "welcome.txt" + And I open the input field for tags in the details view + # When the input field is opened the dropdown is also opened automatically. + When I check the tag "tag2" in the dropdown for tags in the details view + And I check the tag "tag4" in the dropdown for tags in the details view + Then I see that the tag "tag2" in the dropdown for tags in the details view is checked + And I see that the tag "tag4" in the dropdown for tags in the details view is checked + And I see that the input field for tags in the details view contains the tag "tag2" + And I see that the input field for tags in the details view contains the tag "tag4" + + Scenario: remove tags using the dropdown in the details view + Given I am logged in as the admin + And I visit the settings page + And I open the "Workflow" section + # The "create" button does nothing before JavaScript was initialized, and + # the only way to detect that is waiting for the button to select tags to be + # shown. + And I see that the button to select tags is shown + And I create the tag "tag1" in the settings + And I create the tag "tag2" in the settings + And I create the tag "tag3" in the settings + And I create the tag "tag4" in the settings + And I see that the dropdown for tags in the settings eventually contains the tag "tag1" + And I see that the dropdown for tags in the settings eventually contains the tag "tag2" + And I see that the dropdown for tags in the settings eventually contains the tag "tag3" + And I see that the dropdown for tags in the settings eventually contains the tag "tag4" + And I log out + And I am logged in + And I open the details view for "welcome.txt" + And I open the input field for tags in the details view + # When the input field is opened the dropdown is also opened automatically. + And I check the tag "tag2" in the dropdown for tags in the details view + And I check the tag "tag4" in the dropdown for tags in the details view + And I check the tag "tag3" in the dropdown for tags in the details view + When I uncheck the tag "tag2" in the dropdown for tags in the details view + And I uncheck the tag "tag4" in the dropdown for tags in the details view + Then I see that the tag "tag2" in the dropdown for tags in the details view is not checked + And I see that the tag "tag4" in the dropdown for tags in the details view is not checked + And I see that the tag "tag3" in the dropdown for tags in the details view is checked + And I see that the input field for tags in the details view does not contain the tag "tag2" + And I see that the input field for tags in the details view does not contain the tag "tag4" + And I see that the input field for tags in the details view contains the tag "tag3" diff --git a/tests/acceptance/features/app-files.feature b/tests/acceptance/features/app-files.feature index 3bded3fef1..74490180ad 100644 --- a/tests/acceptance/features/app-files.feature +++ b/tests/acceptance/features/app-files.feature @@ -228,94 +228,6 @@ Feature: app-files # download starts no page redirection And I see that the current page is the Authenticate page for the direct download shared link I wrote down - Scenario: show the input field for tags in the details view - Given I am logged in - And I open the details view for "welcome.txt" - And I see that the details view is open - When I open the input field for tags in the details view - Then I see that the input field for tags in the details view is shown - - Scenario: show the input field for tags in the details view after the sharing tab has loaded - Given I am logged in - And I open the details view for "welcome.txt" - And I see that the details view is open - And I open the "Sharing" tab in the details view - And I see that the "Sharing" tab in the details view is eventually loaded - When I open the input field for tags in the details view - Then I see that the input field for tags in the details view is shown - - Scenario: create tags using the Administration settings - Given I am logged in as the admin - And I visit the settings page - And I open the "Workflow" section - # The "create" button does nothing before JavaScript was initialized, and - # the only way to detect that is waiting for the button to select tags to be - # shown. - And I see that the button to select tags is shown - When I create the tag "tag1" in the settings - Then I see that the dropdown for tags in the settings eventually contains the tag "tag1" - - Scenario: add tags using the dropdown in the details view - Given I am logged in as the admin - And I visit the settings page - And I open the "Workflow" section - # The "create" button does nothing before JavaScript was initialized, and - # the only way to detect that is waiting for the button to select tags to be - # shown. - And I see that the button to select tags is shown - And I create the tag "tag1" in the settings - And I create the tag "tag2" in the settings - And I create the tag "tag3" in the settings - And I create the tag "tag4" in the settings - And I see that the dropdown for tags in the settings eventually contains the tag "tag1" - And I see that the dropdown for tags in the settings eventually contains the tag "tag2" - And I see that the dropdown for tags in the settings eventually contains the tag "tag3" - And I see that the dropdown for tags in the settings eventually contains the tag "tag4" - And I log out - And I am logged in - And I open the details view for "welcome.txt" - And I open the input field for tags in the details view - # When the input field is opened the dropdown is also opened automatically. - When I check the tag "tag2" in the dropdown for tags in the details view - And I check the tag "tag4" in the dropdown for tags in the details view - Then I see that the tag "tag2" in the dropdown for tags in the details view is checked - And I see that the tag "tag4" in the dropdown for tags in the details view is checked - And I see that the input field for tags in the details view contains the tag "tag2" - And I see that the input field for tags in the details view contains the tag "tag4" - - Scenario: remove tags using the dropdown in the details view - Given I am logged in as the admin - And I visit the settings page - And I open the "Workflow" section - # The "create" button does nothing before JavaScript was initialized, and - # the only way to detect that is waiting for the button to select tags to be - # shown. - And I see that the button to select tags is shown - And I create the tag "tag1" in the settings - And I create the tag "tag2" in the settings - And I create the tag "tag3" in the settings - And I create the tag "tag4" in the settings - And I see that the dropdown for tags in the settings eventually contains the tag "tag1" - And I see that the dropdown for tags in the settings eventually contains the tag "tag2" - And I see that the dropdown for tags in the settings eventually contains the tag "tag3" - And I see that the dropdown for tags in the settings eventually contains the tag "tag4" - And I log out - And I am logged in - And I open the details view for "welcome.txt" - And I open the input field for tags in the details view - # When the input field is opened the dropdown is also opened automatically. - And I check the tag "tag2" in the dropdown for tags in the details view - And I check the tag "tag4" in the dropdown for tags in the details view - And I check the tag "tag3" in the dropdown for tags in the details view - When I uncheck the tag "tag2" in the dropdown for tags in the details view - And I uncheck the tag "tag4" in the dropdown for tags in the details view - Then I see that the tag "tag2" in the dropdown for tags in the details view is not checked - And I see that the tag "tag4" in the dropdown for tags in the details view is not checked - And I see that the tag "tag3" in the dropdown for tags in the details view is checked - And I see that the input field for tags in the details view does not contain the tag "tag2" - And I see that the input field for tags in the details view does not contain the tag "tag4" - And I see that the input field for tags in the details view contains the tag "tag3" - Scenario: marking a file as favorite causes the file list to be sorted again Given I am logged in And I create a new folder named "A name alphabetically lower than welcome.txt"