From 2d0f0e898dfe36d1c2d4919b772a0c886317274b Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 14 Sep 2015 15:27:06 +0200 Subject: [PATCH] Only check the "was updated/inserted" when not on Oracle... --- tests/lib/appconfig.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/lib/appconfig.php b/tests/lib/appconfig.php index 5ea446aee5..98420abe7b 100644 --- a/tests/lib/appconfig.php +++ b/tests/lib/appconfig.php @@ -191,7 +191,10 @@ class AppConfig extends TestCase { $this->assertEquals('1.2.3', $config->getValue('testapp', 'installed_version')); $this->assertConfigKey('testapp', 'installed_version', '1.2.3'); - $this->assertFalse($config->setValue('testapp', 'installed_version', '1.2.3')); + $wasModified = $config->setValue('testapp', 'installed_version', '1.2.3'); + if (!(\OC::$server->getDatabaseConnection() instanceof \OC\DB\OracleConnection)) { + $this->assertFalse($wasModified); + } $this->assertEquals('1.2.3', $config->getValue('testapp', 'installed_version')); $this->assertConfigKey('testapp', 'installed_version', '1.2.3'); @@ -218,7 +221,10 @@ class AppConfig extends TestCase { $this->assertEquals('somevalue', $config->getValue('someapp', 'somekey')); $this->assertConfigKey('someapp', 'somekey', 'somevalue'); - $this->assertFalse($config->setValue('someapp', 'somekey', 'somevalue')); + $wasInserted = $config->setValue('someapp', 'somekey', 'somevalue'); + if (!(\OC::$server->getDatabaseConnection() instanceof \OC\DB\OracleConnection)) { + $this->assertFalse($wasInserted); + } } public function testDeleteKey() {