From 2e5adadad7b779f0794a6ecddb2b0f51b9214b4a Mon Sep 17 00:00:00 2001
From: Arthur Schiwon <blizzz@owncloud.com>
Date: Thu, 20 Mar 2014 11:38:05 +0100
Subject: [PATCH] Put inner loop into own method, let's see whether it makes
 scrutinizer happier

---
 apps/user_ldap/lib/access.php | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/apps/user_ldap/lib/access.php b/apps/user_ldap/lib/access.php
index d135ee5b73..ce97aaff14 100644
--- a/apps/user_ldap/lib/access.php
+++ b/apps/user_ldap/lib/access.php
@@ -794,15 +794,8 @@ class Access extends LDAPUtility {
 			}
 			list($sr, $pagedSearchOK) = $search;
 
-			foreach($sr as $key => $res) {
-				$count = $this->ldap->countEntries($cr, $res);
-				if($count !== false) {
-					$counter += $count;
-				}
-				if($count === $limit) {
-					$continue = true;
-				}
-			}
+			$count = $this->countEntriesInSearchResults($sr, $limit, $continue);
+			$counter += $count;
 
 			$this->processPagedSearchStatus($sr, $filter, $base, $count, $limit,
 										$offset, $pagedSearchOK, $skipHandling);
@@ -812,6 +805,22 @@ class Access extends LDAPUtility {
 		return $counter;
 	}
 
+	private function countEntriesInSearchResults($searchResults, $limit,
+																&$hasHitLimit) {
+		$cr = $this->connection->getConnectionResource();
+		$count = 0;
+
+		foreach($searchResults as $res) {
+			$count = intval($this->ldap->countEntries($cr, $res));
+			$counter += $count;
+			if($count === $limit) {
+				$hasHitLimit = true;
+			}
+		}
+
+		return $counter;
+	}
+
 	/**
 	 * @brief executes an LDAP search
 	 * @param $filter the LDAP filter for the search