mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add helper to check for `ini` values in `OC_Util::checkServer` 

This allows to check for specific values in the PHP.ini that ownCloud requires for full compatibility.

`mbstring.func_overload`: https://github.com/owncloud/core/issues/14372
`output_buffering`: http://doc.owncloud.org/server/8.0/admin_manual/configuration/big_file_upload_configuration.html#configuring-php

Fixes https://github.com/owncloud/core/issues/14372 and https://github.com/owncloud/core/issues/14412
This commit is contained in:
Lukas Reschke 2015-02-21 12:12:34 +01:00
parent 906c0e7798
commit 2f0f38761d
1 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
lib/private/util.php
View File

@ -570,6 +570,7 @@ class OC_Util {
// classes = class_exists
// functions = function_exists
// defined = defined
// ini = ini_get
// If the dependency is not found the missing module name is shown to the EndUser
$dependencies = array(
'classes' => array(
@ -590,9 +591,14 @@ class OC_Util {
),
'defined' => array(
'PDO::ATTR_DRIVER_NAME' => 'PDO'
)
),
'ini' => [
'mbstring.func_overload' => 0,
'output_buffering' => false,
],
);
$missingDependencies = array();
$invalidIniSettings = [];
$moduleHint = $l->t('Please ask your server administrator to install the module.');
foreach ($dependencies['classes'] as $class => $module) {
@ -610,6 +616,19 @@ class OC_Util {
$missingDependencies[] = $module;
}
}
foreach($dependencies['ini'] as $setting => $expected) {
$iniWrapper = \OC::$server->getIniWrapper();
if(is_bool($expected)) {
if($iniWrapper->getBool($setting) !== $expected) {
$invalidIniSettings[] = [$setting, $expected];
}
}
if(is_int($expected)) {
if($iniWrapper->getNumeric($setting) !== $expected) {
$invalidIniSettings[] = [$setting, $expected];
}
}
}
foreach($missingDependencies as $missingDependency) {
$errors[] = array(
@ -618,6 +637,13 @@ class OC_Util {
);
$webServerRestart = true;
}
foreach($invalidIniSettings as $setting) {
$errors[] = [
'error' => $l->t('PHP setting "%s" is not set to "%s".', [$setting[0], $setting[1]]),
'hint' => $l->t('Adjusting this setting in php.ini will make ownCloud run again')
];
$webServerRestart = true;
}
if (version_compare(phpversion(), '5.4.0', '<')) {
$errors[] = array(