diff --git a/apps/files_external/lib/streamwrapper.php b/apps/files_external/lib/streamwrapper.php index adccb2919e..b55bcf94af 100644 --- a/apps/files_external/lib/streamwrapper.php +++ b/apps/files_external/lib/streamwrapper.php @@ -21,7 +21,7 @@ abstract class StreamWrapper extends Common { } public function rmdir($path) { - if ($this->file_exists($path) and $this->isDeletable($path)) { + if ($this->file_exists($path) && $this->isDeletable($path)) { $dh = $this->opendir($path); while (($file = readdir($dh)) !== false) { if ($this->is_dir($path . '/' . $file)) { diff --git a/apps/files_external/lib/swift.php b/apps/files_external/lib/swift.php index 11186a9f39..6a1e12986f 100644 --- a/apps/files_external/lib/swift.php +++ b/apps/files_external/lib/swift.php @@ -187,7 +187,7 @@ class Swift extends \OC\Files\Storage\Common { public function rmdir($path) { $path = $this->normalizePath($path); - if (!$this->is_dir($path) or !$this->isDeletable($path)) { + if (!$this->is_dir($path) || !$this->isDeletable($path)) { return false; } diff --git a/lib/private/files/storage/common.php b/lib/private/files/storage/common.php index 4680971b27..483a9ac666 100644 --- a/lib/private/files/storage/common.php +++ b/lib/private/files/storage/common.php @@ -95,11 +95,11 @@ abstract class Common implements \OC\Files\Storage\Storage { } public function isDeletable($path) { - if ($path === '' or $path === '/') { + if ($path === '' || $path === '/') { return false; } $parent = dirname($path); - return $this->isUpdatable($parent); + return $this->isUpdatable($parent) and $this->isUpdatable($path); } public function isSharable($path) {