From 4a4cac611f7d7a188cb80364d9e7b5c49e5346bf Mon Sep 17 00:00:00 2001 From: Bjoern Schiessle Date: Fri, 1 Jul 2016 18:48:48 +0200 Subject: [PATCH] we don't need to check permissions twice --- apps/files_versions/lib/Storage.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/apps/files_versions/lib/Storage.php b/apps/files_versions/lib/Storage.php index 9a0fe0a7b3..f0cd9d6531 100644 --- a/apps/files_versions/lib/Storage.php +++ b/apps/files_versions/lib/Storage.php @@ -313,6 +313,7 @@ class Storage { * * @param string $file file name * @param int $revision revision timestamp + * @return bool */ public static function rollback($file, $revision) { @@ -323,13 +324,10 @@ class Storage { if ($uid === null || trim($filename, '/') === '') { return false; } + $users_view = new View('/'.$uid); $files_view = new View('/'. User::getUser().'/files'); - if (!$files_view->isUpdatable($filename)) { - return false; - } - $versionCreated = false; $fileInfo = $files_view->getFileInfo($file);