From ea548cdaaafb1c67fab7aec51c0253a5162203e2 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Thu, 18 Dec 2014 10:50:05 +0100 Subject: [PATCH 01/11] fix accessibility of logos --- apps/files_sharing/templates/public.php | 6 +++++- core/css/header.css | 3 --- core/templates/layout.guest.php | 4 +++- core/templates/layout.user.php | 6 +++++- 4 files changed, 13 insertions(+), 6 deletions(-) diff --git a/apps/files_sharing/templates/public.php b/apps/files_sharing/templates/public.php index 57c8707e96..0384d9a60a 100644 --- a/apps/files_sharing/templates/public.php +++ b/apps/files_sharing/templates/public.php @@ -45,7 +45,11 @@ $previewSupported = OC\Preview::isMimeSupported($_['mimetype']) ? 'true' : 'fals
- +
From 7e5fbde4cdb6e607296d4ed9b48db51f641472d1 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Thu, 18 Dec 2014 15:37:46 +0100 Subject: [PATCH 04/11] add missing input labels for Share dialog --- core/js/share.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/js/share.js b/core/js/share.js index bcb604feaa..f47c9fbb45 100644 --- a/core/js/share.js +++ b/core/js/share.js @@ -380,6 +380,7 @@ OC.Share={ } }); + html += ''; html += ''; html += ''; html += '
    '; @@ -396,9 +397,11 @@ OC.Share={ defaultExpireMessage = t('core', 'The public link will expire no later than {days} days after it is created', {'days': escapeHTML(oc_appconfig.core.defaultExpireDate)}) + '
    '; } + html += ''; html += ''; html += ''; html += '
    '; + html += ''; html += ''; html += ''; html += '
    '; @@ -422,6 +425,7 @@ OC.Share={ html += '
    '; html += ''; + html += ''; html += ''; html += ''+defaultExpireMessage+''; html += '
    '; From 137d19f6b123d6697464f740dc1ff02e90a229c6 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Thu, 18 Dec 2014 15:52:42 +0100 Subject: [PATCH 05/11] fix accessibility for 'New' file inputs --- apps/files/js/file-upload.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/apps/files/js/file-upload.js b/apps/files/js/file-upload.js index b5c8391e80..a67a359882 100644 --- a/apps/files/js/file-upload.js +++ b/apps/files/js/file-upload.js @@ -574,10 +574,15 @@ OC.Upload = { var form = $(''); var input = $(''); var newName = $(this).attr('data-newname') || ''; + var fileType = 'input-' + $(this).attr('data-type'); if (newName) { input.val(newName); + input.attr('id', fileType); } - form.append(input); + var label = $(''); + label.attr('for', fileType); + + form.append(label).append(input); $(this).append(form); var lastPos; var checkInput = function () { From bfee3eefbdf73fdaf82d6754b730aa603b78200d Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Thu, 18 Dec 2014 16:00:26 +0100 Subject: [PATCH 06/11] better color contrast for focused buttons --- core/css/styles.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/css/styles.css b/core/css/styles.css index 12408c2d76..3996aade6d 100644 --- a/core/css/styles.css +++ b/core/css/styles.css @@ -193,8 +193,8 @@ input[type="button"]:hover, input[type="button"]:focus, button:hover, button:focus, .button:hover, .button:focus, select:hover, select:focus, select:active { - background-color:rgba(250,250,250,.9); - color:#333; + background-color: rgba(255, 255, 255, .95); + color: #111; } input[type="submit"] img, input[type="button"] img, button img, .button img { cursor:pointer; } #header .button { From 9009f5f727783a3520fa3bc605e9a149f63c3da4 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Thu, 18 Dec 2014 16:00:55 +0100 Subject: [PATCH 07/11] add empty alt text to decorative preview of public share image --- apps/files_sharing/js/public.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/files_sharing/js/public.js b/apps/files_sharing/js/public.js index 2ddcd84d4c..861da2065e 100644 --- a/apps/files_sharing/js/public.js +++ b/apps/files_sharing/js/public.js @@ -96,7 +96,7 @@ OCA.Sharing.PublicApp = { scalingup: 0 }; - var img = $(''); + var img = $(''); if (previewSupported === 'true' || mimetype.substr(0, mimetype.indexOf('/')) === 'image' && mimetype !== 'image/svg+xml') { img.attr('src', OC.filePath('files_sharing', 'ajax', 'publicpreview.php') + '?' + OC.buildQueryString(params)); img.appendTo('#imgframe'); From 43b2af7333b3b040995c6c2909327fd9a693679f Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Thu, 18 Dec 2014 16:11:25 +0100 Subject: [PATCH 08/11] more alt text and label fixes in Personal settings --- settings/templates/personal.php | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/settings/templates/personal.php b/settings/templates/personal.php index cc04de5ec3..83cf9c72f7 100644 --- a/settings/templates/personal.php +++ b/settings/templates/personal.php @@ -24,13 +24,16 @@

    t('Get the apps to sync your files'));?>

    - + <?php p($l->t('Desktop client'));?> - + <?php p($l->t('Android app'));?> - + <?php p($l->t('iOS app'));?> @@ -88,7 +91,9 @@ if($_['passwordChangeSupported']) { if($_['displayNameChangeSupported']) { ?>
    -

    t('Full Name');?>

    +

    + +

    @@ -103,7 +108,9 @@ if($_['displayNameChangeSupported']) { if($_['passwordChangeSupported']) { ?> -

    t('Email'));?>

    +

    + +

    @@ -138,7 +145,9 @@ if($_['passwordChangeSupported']) { -

    t('Language'));?>

    +

    + +

    +

    + +

    + t('Use this address to access your Files via WebDAV', array(link_to_docs('user-webdav'))));?> diff --git a/apps/files_trashbin/js/app.js b/apps/files_trashbin/js/app.js index 72d9f4a677..c5de08d592 100644 --- a/apps/files_trashbin/js/app.js +++ b/apps/files_trashbin/js/app.js @@ -68,6 +68,7 @@ OCA.Trashbin.App = { render: function(actionSpec, isDefault, context) { var $actionLink = fileActions._makeActionLink(actionSpec, context); $actionLink.attr('original-title', t('files', 'Delete permanently')); + $actionLink.children('img').attr('alt', t('files', 'Delete permanently')); context.$file.find('td:last').append($actionLink); return $actionLink; }, diff --git a/apps/files_trashbin/templates/index.php b/apps/files_trashbin/templates/index.php index 82bc360a9f..fe1311340c 100644 --- a/apps/files_trashbin/templates/index.php +++ b/apps/files_trashbin/templates/index.php @@ -18,11 +18,13 @@
    - + t( 'Name' )); ?> - <?php p($l->t( 'Restore' )); ?>" /> t('Restore'))?> @@ -34,7 +36,7 @@ t('Delete'))?> - <?php p($l->t('Delete'))?>" /> From 96ae18db59084d0494d13ab63f7bc5e02080e8e3 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Thu, 18 Dec 2014 17:05:27 +0100 Subject: [PATCH 10/11] get rid of unnecessary alt and title attributes --- apps/files/templates/list.php | 4 ++-- core/js/share.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/files/templates/list.php b/apps/files/templates/list.php index 7d28016bd7..4224d9bc10 100644 --- a/apps/files/templates/list.php +++ b/apps/files/templates/list.php @@ -72,7 +72,7 @@ t( 'Name' )); ?> - Download" /> t('Download'))?> @@ -86,7 +86,7 @@ t( 'Modified' )); ?> t('Delete'))?> - <?php p($l->t('Delete'))?>" /> diff --git a/core/js/share.js b/core/js/share.js index f47c9fbb45..5e5b85fb5a 100644 --- a/core/js/share.js +++ b/core/js/share.js @@ -640,7 +640,7 @@ OC.Share={ if (possiblePermissions & OC.PERMISSION_CREATE || possiblePermissions & OC.PERMISSION_UPDATE || possiblePermissions & OC.PERMISSION_DELETE) { html += ''; } - showCrudsButton = ''+t('core', 'access control')+''; + showCrudsButton = ''+t('core', 'access control')+''; html += '