diff --git a/apps/files/css/files.scss b/apps/files/css/files.scss index 502f8ea1f7..62f4431dbb 100644 --- a/apps/files/css/files.scss +++ b/apps/files/css/files.scss @@ -120,6 +120,9 @@ .nav-icon-deletedshares { @include icon-color('unshare', 'files', $color-black); } +.nav-icon-favorites-starred { + @include icon-color('star-dark', 'actions', $color-yellow, 2, true); +} #app-navigation .nav-files a.nav-icon-files { width: auto; @@ -704,7 +707,7 @@ table.dragshadow td.size { background-image: none; } & .icon-starred { - @include icon-color('star-dark', 'actions', 'FC0', 1, true); + @include icon-color('star-dark', 'actions', $color-yellow, 1, true); } } @@ -727,7 +730,13 @@ table.dragshadow td.size { .breadcrumb .canDrop > a, #filestable tbody tr.canDrop { - background-color: rgb(179, 230, 255); + background-color: rgba( $color-primary, .3 ); +} +.dropzone-background { + background-color: rgba( $color-primary, .3 ); + :hover{ + box-shadow: none !important; + } } diff --git a/apps/files/js/filelist.js b/apps/files/js/filelist.js index a4402caa7c..232b47857b 100644 --- a/apps/files/js/filelist.js +++ b/apps/files/js/filelist.js @@ -360,12 +360,12 @@ this.$fileList.on('click','td.filename>a.name, td.filesize, td.date', _.bind(this._onClickFile, this)); - $.event.trigger({type: "droppedOnTrash"}); + this.$fileList.on("droppedOnFavorites", function (event, file) { + self.fileActions.triggerAction('Favorite', self.getModelForFile(file), self); + }); - var self=this; - this.$fileList.on("droppedOnTrash", function (event, filename, directory) { - //self.fileActions.triggerAction('Favorite', self.getModelForFile(file), self); - self.do_delete(filename, directory) + this.$fileList.on('droppedOnTrash', function (event, filename, directory) { + self.do_delete(filename, directory); }); this.$fileList.on('change', 'td.selection>.selectCheckBox', _.bind(this._onClickFileCheckbox, this)); diff --git a/apps/files/js/navigation.js b/apps/files/js/navigation.js index acfda3b6ce..f8f15394ef 100644 --- a/apps/files/js/navigation.js +++ b/apps/files/js/navigation.js @@ -62,40 +62,37 @@ * Setup UI events */ _setupEvents: function () { - this.$el.on('click', 'li a', _.bind(this._onClickItem, this)) + this.$el.on('click', 'li a', _.bind(this._onClickItem, this)); this.$el.on('click', 'li button', _.bind(this._onClickMenuButton, this)); - var trashElement=$(".nav-trashbin"); - - //this div is required to prefetch the icon, otherwise it takes a second to show up - trashElement.append("") - trashElement.droppable({ - over: function( event, ui ) { - trashElement.addClass('dropzone-background') + var trashBinElement = $('.nav-trashbin'); + trashBinElement.droppable({ + over: function (event, ui) { + trashBinElement.addClass('dropzone-background'); }, - out: function( event, ui ) { - trashElement.removeClass('dropzone-background'); + out: function (event, ui) { + trashBinElement.removeClass('dropzone-background'); }, - activate: function( event, ui ) { - var elem=trashElement.find("a").first(); - elem.addClass('nav-icon-trashbin-starred').removeClass('nav-icon-trashbin'); + activate: function (event, ui) { + var element = trashBinElement.find('a').first(); + element.addClass('nav-icon-trashbin-starred').removeClass('nav-icon-trashbin'); }, - deactivate: function( event, ui ) { - var elem=trashElement.find("a").first(); - elem.addClass('nav-icon-trashbin').removeClass('nav-icon-trashbin-starred'); + deactivate: function (event, ui) { + var element = trashBinElement.find('a').first(); + element.addClass('nav-icon-trashbin').removeClass('nav-icon-trashbin-starred'); }, - drop: function( event, ui ) { + drop: function (event, ui) { + trashBinElement.removeClass('dropzone-background'); var $selectedFiles = $(ui.draggable); - if (ui.helper.find("tr").size()===1) { - var $tr = $selectedFiles.closest('tr'); - $selectedFiles.trigger("droppedOnTrash", $tr.attr("data-file"), $tr.attr('data-dir')); - }else{ - var item = ui.helper.find("tr"); - for(var i=0; i