Add acceptance tests for sharing password protected links
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This commit is contained in:
parent
13c84f6629
commit
316710bcb1
|
@ -485,6 +485,13 @@ pipeline:
|
||||||
when:
|
when:
|
||||||
matrix:
|
matrix:
|
||||||
TESTS-ACCEPTANCE: access-levels
|
TESTS-ACCEPTANCE: access-levels
|
||||||
|
acceptance-app-files:
|
||||||
|
image: nextcloudci/php7.0:php7.0-7
|
||||||
|
commands:
|
||||||
|
- tests/acceptance/run-local.sh allow-git-repository-modifications features/app-files.feature
|
||||||
|
when:
|
||||||
|
matrix:
|
||||||
|
TESTS-ACCEPTANCE: app-files
|
||||||
acceptance-login:
|
acceptance-login:
|
||||||
image: nextcloudci/php7.0:php7.0-7
|
image: nextcloudci/php7.0:php7.0-7
|
||||||
commands:
|
commands:
|
||||||
|
@ -567,6 +574,8 @@ matrix:
|
||||||
- TESTS: integration-trashbin
|
- TESTS: integration-trashbin
|
||||||
- TESTS: acceptance
|
- TESTS: acceptance
|
||||||
TESTS-ACCEPTANCE: access-levels
|
TESTS-ACCEPTANCE: access-levels
|
||||||
|
- TESTS: acceptance
|
||||||
|
TESTS-ACCEPTANCE: app-files
|
||||||
- TESTS: acceptance
|
- TESTS: acceptance
|
||||||
TESTS-ACCEPTANCE: login
|
TESTS-ACCEPTANCE: login
|
||||||
- TESTS: jsunit
|
- TESTS: jsunit
|
||||||
|
|
|
@ -11,6 +11,7 @@ default:
|
||||||
|
|
||||||
- FeatureContext
|
- FeatureContext
|
||||||
- FilesAppContext
|
- FilesAppContext
|
||||||
|
- FilesSharingAppContext
|
||||||
- LoginPageContext
|
- LoginPageContext
|
||||||
- NotificationContext
|
- NotificationContext
|
||||||
- SettingsMenuContext
|
- SettingsMenuContext
|
||||||
|
|
|
@ -0,0 +1,31 @@
|
||||||
|
Feature: app-files
|
||||||
|
|
||||||
|
Scenario: set a password to a shared link
|
||||||
|
Given I am logged in
|
||||||
|
And I share the link for "welcome.txt"
|
||||||
|
When I protect the shared link with the password "abcdef"
|
||||||
|
Then I see that the working icon for password protect is shown
|
||||||
|
And I see that the working icon for password protect is eventually not shown
|
||||||
|
|
||||||
|
Scenario: access a shared link protected by password with a valid password
|
||||||
|
Given I act as John
|
||||||
|
And I am logged in
|
||||||
|
And I share the link for "welcome.txt" protected by the password "abcdef"
|
||||||
|
And I write down the shared link
|
||||||
|
When I act as Jane
|
||||||
|
And I visit the shared link I wrote down
|
||||||
|
And I see that the current page is the Authenticate page for the shared link I wrote down
|
||||||
|
And I authenticate with password "abcdef"
|
||||||
|
Then I see that the current page is the shared link I wrote down
|
||||||
|
And I see that the shared file preview shows the text "Welcome to your Nextcloud account!"
|
||||||
|
|
||||||
|
Scenario: access a shared link protected by password with an invalid password
|
||||||
|
Given I act as John
|
||||||
|
And I am logged in
|
||||||
|
And I share the link for "welcome.txt" protected by the password "abcdef"
|
||||||
|
And I write down the shared link
|
||||||
|
When I act as Jane
|
||||||
|
And I visit the shared link I wrote down
|
||||||
|
And I authenticate with password "fedcba"
|
||||||
|
Then I see that the current page is the Authenticate page for the shared link I wrote down
|
||||||
|
And I see that a wrong password for the shared file message is shown
|
|
@ -27,6 +27,105 @@ class FilesAppContext implements Context, ActorAwareInterface {
|
||||||
|
|
||||||
use ActorAware;
|
use ActorAware;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function currentSectionMainView() {
|
||||||
|
return Locator::forThe()->xpath("//*[starts-with(@id, 'app-content-') and not(contains(concat(' ', normalize-space(@class), ' '), ' hidden '))]")->
|
||||||
|
describedAs("Current section main view in Files app");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function currentSectionDetailsView() {
|
||||||
|
return Locator::forThe()->xpath("/preceding-sibling::*[position() = 1 and @id = 'app-sidebar']")->
|
||||||
|
descendantOf(self::currentSectionMainView())->
|
||||||
|
describedAs("Current section details view in Files app");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function shareLinkCheckbox() {
|
||||||
|
return Locator::forThe()->content("Share link")->descendantOf(self::currentSectionDetailsView())->
|
||||||
|
describedAs("Share link checkbox in the details view in Files app");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function shareLinkField() {
|
||||||
|
return Locator::forThe()->css(".linkText")->descendantOf(self::currentSectionDetailsView())->
|
||||||
|
describedAs("Share link field in the details view in Files app");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function passwordProtectCheckbox() {
|
||||||
|
return Locator::forThe()->content("Password protect")->descendantOf(self::currentSectionDetailsView())->
|
||||||
|
describedAs("Password protect checkbox in the details view in Files app");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function passwordProtectField() {
|
||||||
|
return Locator::forThe()->css(".linkPassText")->descendantOf(self::currentSectionDetailsView())->
|
||||||
|
describedAs("Password protect field in the details view in Files app");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function passwordProtectWorkingIcon() {
|
||||||
|
return Locator::forThe()->css(".linkPass .icon-loading-small")->descendantOf(self::currentSectionDetailsView())->
|
||||||
|
describedAs("Password protect working icon in the details view in Files app");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function rowForFile($fileName) {
|
||||||
|
return Locator::forThe()->xpath("//*[@id = 'fileList']//span[contains(concat(' ', normalize-space(@class), ' '), ' nametext ') and normalize-space() = '$fileName']/ancestor::tr")->
|
||||||
|
descendantOf(self::currentSectionMainView())->
|
||||||
|
describedAs("Row for file $fileName in Files app");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function shareActionForFile($fileName) {
|
||||||
|
return Locator::forThe()->css(".action-share")->descendantOf(self::rowForFile($fileName))->
|
||||||
|
describedAs("Share action for file $fileName in Files app");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @Given I share the link for :fileName
|
||||||
|
*/
|
||||||
|
public function iShareTheLinkFor($fileName) {
|
||||||
|
$this->actor->find(self::shareActionForFile($fileName), 10)->click();
|
||||||
|
|
||||||
|
$this->actor->find(self::shareLinkCheckbox(), 5)->click();
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @Given I write down the shared link
|
||||||
|
*/
|
||||||
|
public function iWriteDownTheSharedLink() {
|
||||||
|
$this->actor->getSharedNotebook()["shared link"] = $this->actor->find(self::shareLinkField(), 10)->getValue();
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @When I protect the shared link with the password :password
|
||||||
|
*/
|
||||||
|
public function iProtectTheSharedLinkWithThePassword($password) {
|
||||||
|
$this->actor->find(self::passwordProtectCheckbox(), 10)->click();
|
||||||
|
|
||||||
|
$this->actor->find(self::passwordProtectField(), 2)->setValue($password . "\r");
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @Then I see that the current page is the Files app
|
* @Then I see that the current page is the Files app
|
||||||
*/
|
*/
|
||||||
|
@ -36,4 +135,43 @@ class FilesAppContext implements Context, ActorAwareInterface {
|
||||||
$this->actor->getSession()->getCurrentUrl());
|
$this->actor->getSession()->getCurrentUrl());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @Then I see that the working icon for password protect is shown
|
||||||
|
*/
|
||||||
|
public function iSeeThatTheWorkingIconForPasswordProtectIsShown() {
|
||||||
|
PHPUnit_Framework_Assert::assertNotNull($this->actor->find(self::passwordProtectWorkingIcon(), 10));
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @Then I see that the working icon for password protect is eventually not shown
|
||||||
|
*/
|
||||||
|
public function iSeeThatTheWorkingIconForPasswordProtectIsEventuallyNotShown() {
|
||||||
|
$timeout = 10;
|
||||||
|
$timeoutStep = 1;
|
||||||
|
|
||||||
|
$actor = $this->actor;
|
||||||
|
$passwordProtectWorkingIcon = self::passwordProtectWorkingIcon();
|
||||||
|
|
||||||
|
$workingIconNotFoundCallback = function() use ($actor, $passwordProtectWorkingIcon) {
|
||||||
|
try {
|
||||||
|
return !$actor->find($passwordProtectWorkingIcon)->isVisible();
|
||||||
|
} catch (NoSuchElementException $exception) {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
if (!Utils::waitFor($workingIconNotFoundCallback, $timeout, $timeoutStep)) {
|
||||||
|
PHPUnit_Framework_Assert::fail("The working icon for password protect is still shown after $timeout seconds");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @Given I share the link for :fileName protected by the password :password
|
||||||
|
*/
|
||||||
|
public function iShareTheLinkForProtectedByThePassword($fileName, $password) {
|
||||||
|
$this->iShareTheLinkFor($fileName);
|
||||||
|
$this->iProtectTheSharedLinkWithThePassword($password);
|
||||||
|
$this->iSeeThatTheWorkingIconForPasswordProtectIsShown();
|
||||||
|
$this->iSeeThatTheWorkingIconForPasswordProtectIsEventuallyNotShown();
|
||||||
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
|
@ -0,0 +1,110 @@
|
||||||
|
<?php
|
||||||
|
|
||||||
|
/**
|
||||||
|
*
|
||||||
|
* @copyright Copyright (c) 2017, Daniel Calviño Sánchez (danxuliu@gmail.com)
|
||||||
|
*
|
||||||
|
* @license GNU AGPL version 3 or any later version
|
||||||
|
*
|
||||||
|
* This program is free software: you can redistribute it and/or modify
|
||||||
|
* it under the terms of the GNU Affero General Public License as
|
||||||
|
* published by the Free Software Foundation, either version 3 of the
|
||||||
|
* License, or (at your option) any later version.
|
||||||
|
*
|
||||||
|
* This program is distributed in the hope that it will be useful,
|
||||||
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
* GNU Affero General Public License for more details.
|
||||||
|
*
|
||||||
|
* You should have received a copy of the GNU Affero General Public License
|
||||||
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||||
|
*
|
||||||
|
*/
|
||||||
|
|
||||||
|
use Behat\Behat\Context\Context;
|
||||||
|
|
||||||
|
class FilesSharingAppContext implements Context, ActorAwareInterface {
|
||||||
|
|
||||||
|
use ActorAware;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function passwordField() {
|
||||||
|
return Locator::forThe()->field("password")->
|
||||||
|
describedAs("Password field in Authenticate page");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function authenticateButton() {
|
||||||
|
return Locator::forThe()->id("password-submit")->
|
||||||
|
describedAs("Authenticate button in Authenticate page");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function wrongPasswordMessage() {
|
||||||
|
return Locator::forThe()->content("The password is wrong. Try again.")->
|
||||||
|
describedAs("Wrong password message in Authenticate page");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @return Locator
|
||||||
|
*/
|
||||||
|
public static function textPreview() {
|
||||||
|
return Locator::forThe()->css(".text-preview")->
|
||||||
|
describedAs("Text preview in Shared file page");
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @When I visit the shared link I wrote down
|
||||||
|
*/
|
||||||
|
public function iVisitTheSharedLinkIWroteDown() {
|
||||||
|
$this->actor->getSession()->visit($this->actor->getSharedNotebook()["shared link"]);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @When I authenticate with password :password
|
||||||
|
*/
|
||||||
|
public function iAuthenticateWithPassword($password) {
|
||||||
|
$this->actor->find(self::passwordField(), 10)->setValue($password);
|
||||||
|
$this->actor->find(self::authenticateButton())->click();
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @Then I see that the current page is the Authenticate page for the shared link I wrote down
|
||||||
|
*/
|
||||||
|
public function iSeeThatTheCurrentPageIsTheAuthenticatePageForTheSharedLinkIWroteDown() {
|
||||||
|
PHPUnit_Framework_Assert::assertEquals(
|
||||||
|
$this->actor->getSharedNotebook()["shared link"] . "/authenticate",
|
||||||
|
$this->actor->getSession()->getCurrentUrl());
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @Then I see that the current page is the shared link I wrote down
|
||||||
|
*/
|
||||||
|
public function iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown() {
|
||||||
|
PHPUnit_Framework_Assert::assertEquals(
|
||||||
|
$this->actor->getSharedNotebook()["shared link"],
|
||||||
|
$this->actor->getSession()->getCurrentUrl());
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @Then I see that a wrong password for the shared file message is shown
|
||||||
|
*/
|
||||||
|
public function iSeeThatAWrongPasswordForTheSharedFileMessageIsShown() {
|
||||||
|
PHPUnit_Framework_Assert::assertTrue(
|
||||||
|
$this->actor->find(self::wrongPasswordMessage(), 10)->isVisible());
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @Then I see that the shared file preview shows the text :text
|
||||||
|
*/
|
||||||
|
public function iSeeThatTheSharedFilePreviewShowsTheText($text) {
|
||||||
|
PHPUnit_Framework_Assert::assertContains($text, $this->actor->find(self::textPreview(), 10)->getText());
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
Loading…
Reference in New Issue