Merge pull request #1554 from nextcloud/updatestate-can-be-empty

UpdateState is empty if no update is available

apps/updatenotification/lib/Controller/AdminController.php

@@ -113,7 +113,7 @@ class AdminController extends Controller implements ISettings {
 			'channels' => $channels,
 			'newVersionString' => (empty($updateState['updateVersion'])) ? '' : $updateState['updateVersion'],
 			'downloadLink' => (empty($updateState['downloadLink'])) ? '' : $updateState['downloadLink'],
-			'updaterEnabled' => $updateState['updaterEnabled'],
+			'updaterEnabled' => (empty($updateState['updaterEnabled'])) ? false : $updateState['updaterEnabled'],
 
 			'notify_groups' => implode('|', $notifyGroups),
 		];

apps/updatenotification/tests/Controller/AdminControllerTest.php

@@ -162,7 +162,7 @@ class AdminControllerTest extends TestCase {
 		$this->updateChecker
 			->expects($this->once())
 			->method('getUpdateState')
-			->willReturn(['updaterEnabled' => false]);
+			->willReturn([]);
 
 		$params = [
 			'isNewVersionAvailable' => false,