From 33409319be610dfa525e27a9d3ebf124f89fc030 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?John=20Molakvo=C3=A6=20=28skjnldsv=29?= Date: Tue, 2 Jul 2019 08:04:56 +0200 Subject: [PATCH] Do not fail hard on new user mail error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: John Molakvoæ (skjnldsv) --- apps/provisioning_api/lib/Controller/UsersController.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/provisioning_api/lib/Controller/UsersController.php b/apps/provisioning_api/lib/Controller/UsersController.php index 93b5d62db3..1fa1f1fa5b 100644 --- a/apps/provisioning_api/lib/Controller/UsersController.php +++ b/apps/provisioning_api/lib/Controller/UsersController.php @@ -328,12 +328,13 @@ class UsersController extends AUserData { $emailTemplate = $this->newUserMailHelper->generateTemplate($newUser, $generatePasswordResetToken); $this->newUserMailHelper->sendMail($newUser, $emailTemplate); } catch (\Exception $e) { + // Mail could be failing hard or just be plain not configured + // Logging error as it is the hardest of the two $this->logger->logException($e, [ - 'message' => "Can't send new user mail to $email", + 'message' => "Unable to send the invitation mail to $email", 'level' => ILogger::ERROR, 'app' => 'ocs_api', ]); - throw new OCSException('Unable to send the invitation mail', 109); } }