From 335619f6a4f0900171a0233354a3b168860ded01 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Tue, 8 May 2018 19:17:19 +0200 Subject: [PATCH] Check connection status and attempt to reconnect each each minute Signed-off-by: Robin Appelman --- lib/composer/composer/autoload_classmap.php | 1 + lib/composer/composer/autoload_static.php | 1 + lib/private/DB/Connection.php | 2 +- lib/private/DB/ReconnectWrapper.php | 52 +++++++++++++++++++++ 4 files changed, 55 insertions(+), 1 deletion(-) create mode 100644 lib/private/DB/ReconnectWrapper.php diff --git a/lib/composer/composer/autoload_classmap.php b/lib/composer/composer/autoload_classmap.php index 6f8c413154..e408e7b774 100644 --- a/lib/composer/composer/autoload_classmap.php +++ b/lib/composer/composer/autoload_classmap.php @@ -597,6 +597,7 @@ return array( 'OC\\DB\\QueryBuilder\\QueryBuilder' => $baseDir . '/lib/private/DB/QueryBuilder/QueryBuilder.php', 'OC\\DB\\QueryBuilder\\QueryFunction' => $baseDir . '/lib/private/DB/QueryBuilder/QueryFunction.php', 'OC\\DB\\QueryBuilder\\QuoteHelper' => $baseDir . '/lib/private/DB/QueryBuilder/QuoteHelper.php', + 'OC\\DB\\ReconnectWrapper' => $baseDir . '/lib/private/DB/ReconnectWrapper.php', 'OC\\DB\\SQLiteMigrator' => $baseDir . '/lib/private/DB/SQLiteMigrator.php', 'OC\\DB\\SQLiteSessionInit' => $baseDir . '/lib/private/DB/SQLiteSessionInit.php', 'OC\\DB\\SchemaWrapper' => $baseDir . '/lib/private/DB/SchemaWrapper.php', diff --git a/lib/composer/composer/autoload_static.php b/lib/composer/composer/autoload_static.php index 92726f7789..f506849898 100644 --- a/lib/composer/composer/autoload_static.php +++ b/lib/composer/composer/autoload_static.php @@ -627,6 +627,7 @@ class ComposerStaticInit53792487c5a8370acc0b06b1a864ff4c 'OC\\DB\\QueryBuilder\\QueryBuilder' => __DIR__ . '/../../..' . '/lib/private/DB/QueryBuilder/QueryBuilder.php', 'OC\\DB\\QueryBuilder\\QueryFunction' => __DIR__ . '/../../..' . '/lib/private/DB/QueryBuilder/QueryFunction.php', 'OC\\DB\\QueryBuilder\\QuoteHelper' => __DIR__ . '/../../..' . '/lib/private/DB/QueryBuilder/QuoteHelper.php', + 'OC\\DB\\ReconnectWrapper' => __DIR__ . '/../../..' . '/lib/private/DB/ReconnectWrapper.php', 'OC\\DB\\SQLiteMigrator' => __DIR__ . '/../../..' . '/lib/private/DB/SQLiteMigrator.php', 'OC\\DB\\SQLiteSessionInit' => __DIR__ . '/../../..' . '/lib/private/DB/SQLiteSessionInit.php', 'OC\\DB\\SchemaWrapper' => __DIR__ . '/../../..' . '/lib/private/DB/SchemaWrapper.php', diff --git a/lib/private/DB/Connection.php b/lib/private/DB/Connection.php index 8a8a2f100e..8bb959ffbc 100644 --- a/lib/private/DB/Connection.php +++ b/lib/private/DB/Connection.php @@ -43,7 +43,7 @@ use OCP\DB\QueryBuilder\IQueryBuilder; use OCP\IDBConnection; use OCP\PreConditionNotMetException; -class Connection extends \Doctrine\DBAL\Connection implements IDBConnection { +class Connection extends ReconnectWrapper implements IDBConnection { /** * @var string $tablePrefix */ diff --git a/lib/private/DB/ReconnectWrapper.php b/lib/private/DB/ReconnectWrapper.php new file mode 100644 index 0000000000..27a34c862a --- /dev/null +++ b/lib/private/DB/ReconnectWrapper.php @@ -0,0 +1,52 @@ + + * + * @license GNU AGPL version 3 or any later version + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +namespace OC\DB; + +use Doctrine\Common\EventManager; +use Doctrine\DBAL\Configuration; +use Doctrine\DBAL\Driver; + +class ReconnectWrapper extends \Doctrine\DBAL\Connection { + const CHECK_CONNECTION_INTERVAL = 60; + + private $lastConnectionCheck = null; + + public function __construct(array $params, Driver $driver, Configuration $config = null, EventManager $eventManager = null) { + parent::__construct($params, $driver, $config, $eventManager); + $this->lastConnectionCheck = time(); + } + + public function connect() { + $now = time(); + $checkTime = $now - self::CHECK_CONNECTION_INTERVAL; + + if ($this->lastConnectionCheck > $checkTime || $this->isTransactionActive()) { + return parent::connect(); + } else { + $this->lastConnectionCheck = $now; + if (!$this->ping()) { + $this->close(); + } + return parent::connect(); + } + } +}