mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Search tags case insensitive 

fixes: #22352

* Added unit tests
This commit is contained in:
Roeland Jago Douma 2016-02-14 20:41:39 +01:00
parent ac367b97f0
commit 33ef240b39
2 changed files with 55 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/js/systemtags/systemtagscollection.js
View File

@ -11,7 +11,7 @@
(function(OC) {
function filterFunction(model, term) {
return model.get('name').substr(0, term.length) === term;
return model.get('name').substr(0, term.length).toLowerCase() === term.toLowerCase();
}
/**

54
core/js/tests/specs/systemtags/systemtagsinputfieldSpec.js
View File

@ -346,6 +346,7 @@ describe('OC.SystemTags.SystemTagsInputField tests', function() {
new OC.SystemTags.SystemTagModel({id: '1', name: 'abc'}),
new OC.SystemTags.SystemTagModel({id: '2', name: 'def'}),
new OC.SystemTags.SystemTagModel({id: '3', name: 'abd', userAssignable: false}),
new OC.SystemTags.SystemTagModel({id: '4', name: 'Deg'}),
]);
});
afterEach(function() {
@ -377,6 +378,32 @@ describe('OC.SystemTags.SystemTagsInputField tests', function() {
}
]);
});
it('completes case insensitive', function() {
var callback = sinon.stub();
opts.query({
term: 'de',
callback: callback
});
expect(fetchStub.calledOnce).toEqual(true);
fetchStub.yieldTo('success', view.collection);
expect(callback.calledOnce).toEqual(true);
expect(callback.getCall(0).args[0].results).toEqual([
{
id: '2',
name: 'def',
userVisible: true,
userAssignable: true
},
{
id: '4',
name: 'Deg',
userVisible: true,
userAssignable: true
}
]);
});
});
});
@ -446,6 +473,7 @@ describe('OC.SystemTags.SystemTagsInputField tests', function() {
new OC.SystemTags.SystemTagModel({id: '1', name: 'abc'}),
new OC.SystemTags.SystemTagModel({id: '2', name: 'def'}),
new OC.SystemTags.SystemTagModel({id: '3', name: 'abd', userAssignable: false}),
new OC.SystemTags.SystemTagModel({id: '4', name: 'Deg'}),
]);
});
afterEach(function() {
@ -471,6 +499,32 @@ describe('OC.SystemTags.SystemTagsInputField tests', function() {
}
]);
});
it('completes case insensitive', function() {
var callback = sinon.stub();
opts.query({
term: 'de',
callback: callback
});
expect(fetchStub.calledOnce).toEqual(true);
fetchStub.yieldTo('success', view.collection);
expect(callback.calledOnce).toEqual(true);
expect(callback.getCall(0).args[0].results).toEqual([
{
id: '2',
name: 'def',
userVisible: true,
userAssignable: true
},
{
id: '4',
name: 'Deg',
userVisible: true,
userAssignable: true
}
]);
});
});
});
});