Merge pull request #8407 from owncloud/scale-pics-on-public-sharing-master
Images on public sharing get downscaled to increase use experience - thi...
This commit is contained in:
commit
341fcdc37a
|
@ -16,6 +16,7 @@ $maxX = array_key_exists('x', $_GET) ? (int) $_GET['x'] : '36';
|
|||
$maxY = array_key_exists('y', $_GET) ? (int) $_GET['y'] : '36';
|
||||
$scalingUp = array_key_exists('scalingup', $_GET) ? (bool) $_GET['scalingup'] : true;
|
||||
$token = array_key_exists('t', $_GET) ? (string) $_GET['t'] : '';
|
||||
$keepAspect = array_key_exists('a', $_GET) ? true : false;
|
||||
|
||||
if($token === ''){
|
||||
\OC_Response::setStatus(400); //400 Bad Request
|
||||
|
@ -70,6 +71,10 @@ if(substr($path, 0, 1) === '/') {
|
|||
$path = substr($path, 1);
|
||||
}
|
||||
|
||||
if ($keepAspect === true) {
|
||||
$maxY = $maxX;
|
||||
}
|
||||
|
||||
if($maxX === 0 || $maxY === 0) {
|
||||
\OC_Response::setStatus(400); //400 Bad Request
|
||||
\OC_Log::write('core-preview', 'x and/or y set to 0', \OC_Log::DEBUG);
|
||||
|
@ -84,8 +89,9 @@ try{
|
|||
$preview->setMaxX($maxX);
|
||||
$preview->setMaxY($maxY);
|
||||
$preview->setScalingUp($scalingUp);
|
||||
$preview->setKeepAspect($keepAspect);
|
||||
|
||||
$preview->show();
|
||||
$preview->showPreview();
|
||||
} catch (\Exception $e) {
|
||||
\OC_Response::setStatus(500);
|
||||
\OC_Log::write('core', $e->getmessage(), \OC_Log::DEBUG);
|
||||
|
|
|
@ -1,9 +1,9 @@
|
|||
<?php
|
||||
/** @var $this \OCP\Route\IRouter */
|
||||
$this->create('core_ajax_public_preview', '/publicpreview.png')->action(
|
||||
function() {
|
||||
$this->create('core_ajax_public_preview', '/publicpreview')->action(
|
||||
function() {
|
||||
require_once __DIR__ . '/../ajax/publicpreview.php';
|
||||
});
|
||||
});
|
||||
|
||||
// OCS API
|
||||
|
||||
|
|
|
@ -12,10 +12,11 @@
|
|||
|
||||
$(document).ready(function() {
|
||||
|
||||
if (typeof FileActions !== 'undefined') {
|
||||
var mimetype = $('#mimetype').val();
|
||||
|
||||
if (typeof FileActions !== 'undefined') {
|
||||
// Show file preview if previewer is available, images are already handled by the template
|
||||
if (mimetype.substr(0, mimetype.indexOf('/')) != 'image' && $('.publicpreview').length === 0) {
|
||||
if (mimetype.substr(0, mimetype.indexOf('/')) !== 'image' && $('.publicpreview').length === 0) {
|
||||
// Trigger default action if not download TODO
|
||||
var action = FileActions.getDefault(mimetype, 'file', OC.PERMISSION_READ);
|
||||
if (typeof action !== 'undefined') {
|
||||
|
@ -24,7 +25,23 @@ $(document).ready(function() {
|
|||
}
|
||||
}
|
||||
|
||||
// dynamically load image previews
|
||||
if (mimetype.substr(0, mimetype.indexOf('/')) === 'image' ) {
|
||||
|
||||
var params = {
|
||||
x: $(document).width() * window.devicePixelRatio,
|
||||
a: 'true',
|
||||
file: encodeURIComponent($('#dir').val() + $('#filename').val()),
|
||||
t: $('#sharingToken').val()
|
||||
};
|
||||
|
||||
var img = $('<img class="publicpreview">');
|
||||
img.attr('src', OC.filePath('files_sharing', 'ajax', 'publicpreview.php') + '?' + OC.buildQueryString(params));
|
||||
img.appendTo('#imgframe');
|
||||
}
|
||||
|
||||
// override since the format is different
|
||||
if (typeof Files !== 'undefined') {
|
||||
Files.getDownloadUrl = function(filename, dir) {
|
||||
if ($.isArray(filename)) {
|
||||
filename = JSON.stringify(filename);
|
||||
|
@ -75,6 +92,7 @@ $(document).ready(function() {
|
|||
file_directory: fileDirectory
|
||||
};
|
||||
});
|
||||
}
|
||||
|
||||
$(document).on('click', '#directLink', function() {
|
||||
$(this).focus();
|
||||
|
|
|
@ -30,7 +30,6 @@
|
|||
<?php else: ?>
|
||||
<?php if (substr($_['mimetype'], 0, strpos($_['mimetype'], '/')) == 'image'): ?>
|
||||
<div id="imgframe">
|
||||
<img src="<?php p($_['downloadURL']); ?>" alt="" />
|
||||
</div>
|
||||
<?php elseif (substr($_['mimetype'], 0, strpos($_['mimetype'], '/')) == 'video'): ?>
|
||||
<div id="imgframe">
|
||||
|
|
|
@ -1,5 +1,6 @@
|
|||
<?php
|
||||
$this->create('core_ajax_trashbin_preview', '/preview.png')->action(
|
||||
/** @var $this \OCP\Route\IRouter */
|
||||
$this->create('core_ajax_trashbin_preview', '/preview')->action(
|
||||
function() {
|
||||
require_once __DIR__ . '/../ajax/preview.php';
|
||||
});
|
|
@ -8,7 +8,8 @@
|
|||
// Register with the capabilities API
|
||||
OC_API::register('get', '/cloud/capabilities', array('OCA\Files_Versions\Capabilities', 'getCapabilities'), 'files_versions', OC_API::USER_AUTH);
|
||||
|
||||
$this->create('core_ajax_versions_preview', '/preview.png')->action(
|
||||
/** @var $this \OCP\Route\IRouter */
|
||||
$this->create('core_ajax_versions_preview', '/preview')->action(
|
||||
function() {
|
||||
require_once __DIR__ . '/../ajax/preview.php';
|
||||
});
|
||||
|
|
|
@ -11,6 +11,7 @@ $file = array_key_exists('file', $_GET) ? (string)$_GET['file'] : '';
|
|||
$maxX = array_key_exists('x', $_GET) ? (int)$_GET['x'] : '36';
|
||||
$maxY = array_key_exists('y', $_GET) ? (int)$_GET['y'] : '36';
|
||||
$scalingUp = array_key_exists('scalingup', $_GET) ? (bool)$_GET['scalingup'] : true;
|
||||
$keepAspect = array_key_exists('a', $_GET) ? true : false;
|
||||
$always = array_key_exists('forceIcon', $_GET) ? (bool)$_GET['forceIcon'] : true;
|
||||
|
||||
if ($file === '') {
|
||||
|
@ -20,6 +21,10 @@ if ($file === '') {
|
|||
exit;
|
||||
}
|
||||
|
||||
if ($keepAspect === true) {
|
||||
$maxY = $maxX;
|
||||
}
|
||||
|
||||
if ($maxX === 0 || $maxY === 0) {
|
||||
//400 Bad Request
|
||||
\OC_Response::setStatus(400);
|
||||
|
@ -36,9 +41,10 @@ try {
|
|||
$preview->setMaxX($maxX);
|
||||
$preview->setMaxY($maxY);
|
||||
$preview->setScalingUp($scalingUp);
|
||||
$preview->setKeepAspect($keepAspect);
|
||||
}
|
||||
|
||||
$preview->show();
|
||||
$preview->showPreview();
|
||||
} catch (\Exception $e) {
|
||||
\OC_Response::setStatus(500);
|
||||
\OC_Log::write('core', $e->getmessage(), \OC_Log::DEBUG);
|
||||
|
|
|
@ -66,6 +66,8 @@ $this->create('core_tags_delete', '/tags/{type}/delete')
|
|||
$this->create('js_config', '/core/js/oc.js')
|
||||
->actionInclude('core/js/config.php');
|
||||
// Routing
|
||||
$this->create('core_ajax_preview', '/core/preview')
|
||||
->actionInclude('core/ajax/preview.php');
|
||||
$this->create('core_ajax_preview', '/core/preview.png')
|
||||
->actionInclude('core/ajax/preview.php');
|
||||
$this->create('core_lostpassword_index', '/lostpassword/')
|
||||
|
|
|
@ -43,6 +43,7 @@ class Preview {
|
|||
private $maxY;
|
||||
private $scalingUp;
|
||||
private $mimeType;
|
||||
private $keepAspect = false;
|
||||
|
||||
//filemapper used for deleting previews
|
||||
// index is path, value is fileinfo
|
||||
|
@ -267,6 +268,11 @@ class Preview {
|
|||
return $this;
|
||||
}
|
||||
|
||||
public function setKeepAspect($keepAspect) {
|
||||
$this->keepAspect = $keepAspect;
|
||||
return $this;
|
||||
}
|
||||
|
||||
/**
|
||||
* @brief check if all parameters are valid
|
||||
* @return bool
|
||||
|
@ -297,7 +303,7 @@ class Preview {
|
|||
if($fileInfo !== null && $fileInfo !== false) {
|
||||
$fileId = $fileInfo->getId();
|
||||
|
||||
$previewPath = $this->getThumbnailsFolder() . '/' . $fileId . '/' . $this->getMaxX() . '-' . $this->getMaxY() . '.png';
|
||||
$previewPath = $this->buildCachePath($fileId);
|
||||
return $this->userView->unlink($previewPath);
|
||||
}
|
||||
return false;
|
||||
|
@ -331,14 +337,11 @@ class Preview {
|
|||
return false;
|
||||
}
|
||||
|
||||
$maxX = $this->getMaxX();
|
||||
$maxY = $this->getMaxY();
|
||||
|
||||
$previewPath = $this->getThumbnailsFolder() . '/' . $fileId . '/';
|
||||
$preview = $this->buildCachePath($fileId);
|
||||
|
||||
//does a preview with the wanted height and width already exist?
|
||||
if ($this->userView->file_exists($previewPath . $maxX . '-' . $maxY . '.png')) {
|
||||
return $previewPath . $maxX . '-' . $maxY . '.png';
|
||||
if ($this->userView->file_exists($preview)) {
|
||||
return $preview;
|
||||
}
|
||||
|
||||
return $this->isCachedBigger($fileId);
|
||||
|
@ -355,6 +358,11 @@ class Preview {
|
|||
return false;
|
||||
}
|
||||
|
||||
// in order to not loose quality we better generate aspect preserving previews from the original file
|
||||
if ($this->keepAspect) {
|
||||
return false;
|
||||
}
|
||||
|
||||
$maxX = $this->getMaxX();
|
||||
|
||||
//array for usable cached thumbnails
|
||||
|
@ -466,12 +474,12 @@ class Preview {
|
|||
$fileId = $fileInfo->getId();
|
||||
|
||||
$cached = $this->isCached($fileId);
|
||||
|
||||
if ($cached) {
|
||||
$stream = $this->userView->fopen($cached, 'r');
|
||||
$image = new \OC_Image();
|
||||
$image->loadFromFileHandle($stream);
|
||||
$this->preview = $image->valid() ? $image : null;
|
||||
|
||||
$this->resizeAndCrop();
|
||||
fclose($stream);
|
||||
}
|
||||
|
@ -497,7 +505,7 @@ class Preview {
|
|||
$this->resizeAndCrop();
|
||||
|
||||
$previewPath = $this->getThumbnailsFolder() . '/' . $fileId . '/';
|
||||
$cachePath = $previewPath . $maxX . '-' . $maxY . '.png';
|
||||
$cachePath = $this->buildCachePath($fileId);
|
||||
|
||||
if ($this->userView->is_dir($this->getThumbnailsFolder() . '/') === false) {
|
||||
$this->userView->mkdir($this->getThumbnailsFolder() . '/');
|
||||
|
@ -524,20 +532,12 @@ class Preview {
|
|||
* @brief show preview
|
||||
* @return void
|
||||
*/
|
||||
public function showPreview() {
|
||||
public function showPreview($mimeType = null) {
|
||||
\OCP\Response::enableCaching(3600 * 24); // 24 hours
|
||||
if (is_null($this->preview)) {
|
||||
$this->getPreview();
|
||||
}
|
||||
$this->preview->show('image/png');
|
||||
}
|
||||
|
||||
/**
|
||||
* @brief show preview
|
||||
* @return void
|
||||
*/
|
||||
public function show() {
|
||||
$this->showPreview();
|
||||
$this->preview->show($mimeType);
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -561,6 +561,11 @@ class Preview {
|
|||
$realX = (int)$image->width();
|
||||
$realY = (int)$image->height();
|
||||
|
||||
// compute $maxY using the aspect of the generated preview
|
||||
if ($this->keepAspect) {
|
||||
$y = $x / ($realX / $realY);
|
||||
}
|
||||
|
||||
if ($x === $realX && $y === $realY) {
|
||||
$this->preview = $image;
|
||||
return;
|
||||
|
@ -743,4 +748,21 @@ class Preview {
|
|||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
/**
|
||||
* @param $fileId
|
||||
* @return string
|
||||
*/
|
||||
private function buildCachePath($fileId) {
|
||||
$maxX = $this->getMaxX();
|
||||
$maxY = $this->getMaxY();
|
||||
|
||||
$previewPath = $this->getThumbnailsFolder() . '/' . $fileId . '/';
|
||||
$preview = $previewPath . $maxX . '-' . $maxY . '.png';
|
||||
if ($this->keepAspect) {
|
||||
$preview = $previewPath . $maxX . '-with-aspect.png';
|
||||
return $preview;
|
||||
}
|
||||
return $preview;
|
||||
}
|
||||
}
|
||||
|
|
|
@ -31,6 +31,7 @@ class Image extends Provider {
|
|||
|
||||
return $image->valid() ? $image : false;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
\OC\Preview::registerProvider('OC\Preview\Image');
|
|
@ -40,6 +40,7 @@ if (extension_loaded('imagick')) {
|
|||
//check if image object is valid
|
||||
return $image->valid() ? $image : false;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
\OC\Preview::registerProvider('OC\Preview\PDF');
|
||||
|
|
|
@ -22,4 +22,5 @@ abstract class Provider {
|
|||
* OC_Image object of the preview
|
||||
*/
|
||||
abstract public function getThumbnail($path, $maxX, $maxY, $scalingup, $fileview);
|
||||
|
||||
}
|
||||
|
|
|
@ -45,6 +45,7 @@ if (extension_loaded('imagick')) {
|
|||
//check if image object is valid
|
||||
return $image->valid() ? $image : false;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
\OC\Preview::registerProvider('OC\Preview\SVG');
|
||||
|
|
Loading…
Reference in New Issue