From 38b88422a807c9ef0b57879aa189e3329c1258d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Sat, 6 Mar 2021 14:45:25 +0100 Subject: [PATCH] Do not send "enter" key when not needed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sending the "enter" key is not needed in those input fields that auto save while the user is typing or when the focus is lost (which since version 1.4.0 the Selenium driver for Mink is automatically done after setting the value). Signed-off-by: Daniel Calviño Sánchez --- tests/acceptance/features/bootstrap/ContactsMenuContext.php | 2 +- tests/acceptance/features/bootstrap/SearchContext.php | 2 +- tests/acceptance/features/bootstrap/ThemingAppContext.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/acceptance/features/bootstrap/ContactsMenuContext.php b/tests/acceptance/features/bootstrap/ContactsMenuContext.php index 3578606215..ae4eab89ec 100644 --- a/tests/acceptance/features/bootstrap/ContactsMenuContext.php +++ b/tests/acceptance/features/bootstrap/ContactsMenuContext.php @@ -82,7 +82,7 @@ class ContactsMenuContext implements Context, ActorAwareInterface { * @When I search for the user :user */ public function iSearchForTheUser($user) { - $this->actor->find(self::contactsMenuSearchInput(), 10)->setValue($user . "\r"); + $this->actor->find(self::contactsMenuSearchInput(), 10)->setValue($user); } /** diff --git a/tests/acceptance/features/bootstrap/SearchContext.php b/tests/acceptance/features/bootstrap/SearchContext.php index ba0d9d9933..db7aeb90ff 100644 --- a/tests/acceptance/features/bootstrap/SearchContext.php +++ b/tests/acceptance/features/bootstrap/SearchContext.php @@ -86,7 +86,7 @@ class SearchContext implements Context, ActorAwareInterface { * @When I search for :query */ public function iSearchFor($query) { - $this->actor->find(self::searchBoxInput(), 10)->setValue($query . "\r"); + $this->actor->find(self::searchBoxInput(), 10)->setValue($query); } /** diff --git a/tests/acceptance/features/bootstrap/ThemingAppContext.php b/tests/acceptance/features/bootstrap/ThemingAppContext.php index 70fb2b01e1..d17d9c1810 100644 --- a/tests/acceptance/features/bootstrap/ThemingAppContext.php +++ b/tests/acceptance/features/bootstrap/ThemingAppContext.php @@ -65,7 +65,7 @@ class ThemingAppContext implements Context, ActorAwareInterface { * @When I set the :parameterName parameter in the Theming app to :parameterValue */ public function iSetTheParameterInTheThemingAppTo($parameterName, $parameterValue) { - $this->actor->find(self::inputFieldFor($parameterName), 10)->setValue($parameterValue . "\r"); + $this->actor->find(self::inputFieldFor($parameterName), 10)->setValue($parameterValue); } /**