mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #13767 from owncloud/issue/13764-mimetype-racecondition 

Use insertIfNotExists() and reload mimetypes after inserting one
This commit is contained in:
Thomas Müller 2015-02-20 17:39:17 +01:00
parent df2e712a8e a575dcf78f
commit 3a6b11d018
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/private/files/cache/cache.php vendored
View File

@ -74,9 +74,11 @@ class Cache {
if (!isset(self::$mimetypeIds[$mime])) { if (!isset(self::$mimetypeIds[$mime])) {
try { try {
$result = \OC_DB::executeAudited('INSERT INTO `*PREFIX*mimetypes`(`mimetype`) VALUES(?)', array($mime)); $connection = \OC_DB::getConnection();
self::$mimetypeIds[$mime] = \OC_DB::insertid('*PREFIX*mimetypes'); $connection->insertIfNotExist('*PREFIX*mimetypes', [
self::$mimetypes[self::$mimetypeIds[$mime]] = $mime; 'mimetype' => $mime,
]);
$this->loadMimetypes();
} catch (\Doctrine\DBAL\DBALException $e) { } catch (\Doctrine\DBAL\DBALException $e) {
\OC_Log::write('core', 'Exception during mimetype insertion: ' . $e->getmessage(), \OC_Log::DEBUG); \OC_Log::write('core', 'Exception during mimetype insertion: ' . $e->getmessage(), \OC_Log::DEBUG);
return -1; return -1;
@ -95,6 +97,8 @@ class Cache {
} }
public function loadMimetypes() { public function loadMimetypes() {
self::$mimetypeIds = self::$mimetypes = array();
$result = \OC_DB::executeAudited('SELECT `id`, `mimetype` FROM `*PREFIX*mimetypes`', array()); $result = \OC_DB::executeAudited('SELECT `id`, `mimetype` FROM `*PREFIX*mimetypes`', array());
if ($result) { if ($result) {
while ($row = $result->fetchRow()) { while ($row = $result->fetchRow()) {